[servicebus] Precise Typechecking (#32118)

Author: deyaaeldeen

.gitignore

@@ -195,3 +195,6 @@ sdk/**/sshKey.pub
 
 # vitest results
 .vite/vitest/results.json
+
+# typescript
+*.tsbuildinfo

common/tools/eslint-plugin-azure-sdk/src/index.ts

@@ -49,7 +49,13 @@ function config(customConfigs?: FlatConfig.ConfigArray) {
       })
     : [];
 
-  return [...configs.recommended, ...updated];
+  return [
+    ...configs.recommended,
+    ...updated,
+    {
+      ignores: ["**/test/snippets.spec.ts", "**/test/stress"],
+    },
+  ];
 }
 
 export = {

sdk/servicebus/service-bus/eslint.config.mjs

@@ -2,11 +2,11 @@ import azsdkEslint from "@azure/eslint-plugin-azure-sdk";
 
 export default azsdkEslint.config([
   {
-    ignores: ["test/stress/"],
-  },
-  {
-    rules: {
-      "@azure/azure-sdk/ts-package-json-types": "off",
+    files: ["**/*.ts", "**/*.cts", "**/*.mts"],
+    languageOptions: {
+      parserOptions: {
+        project: ["./tsconfig.test.json"],
+      },
     },
   },
 ]);

sdk/servicebus/service-bus/package.json

@@ -42,7 +42,7 @@
     "format": "dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"samples/**/*.{ts,js}\" \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
     "integration-test:browser": "dev-tool run build-package && dev-tool run build-test && dev-tool run test:vitest --browser --no-test-proxy",
-    "integration-test:node": "dev-tool run test:vitest --no-test-proxy",
+    "integration-test:node": "dev-tool run test:vitest --no-test-proxy --esm",
     "lint": "eslint package.json api-extractor.json README.md src test",
     "lint:fix": "eslint package.json api-extractor.json README.md src test --fix --fix-type [problem,suggestion]",
     "pack": "npm pack 2>&1",
@@ -137,6 +137,7 @@
   },
   "type": "module",
   "tshy": {
+    "project": "./tsconfig.src.json",
     "exports": {
       "./package.json": "./package.json",
       ".": "./src/index.ts",

sdk/servicebus/service-bus/src/core/managementClient.ts

@@ -52,7 +52,6 @@ import {
   throwTypeErrorIfParameterTypeMismatch,
 } from "../util/errors.js";
 import { max32BitNumber } from "../util/constants.js";
-// eslint-disable-next-line @typescript-eslint/no-redeclare
 import { Buffer } from "buffer";
 import type { OperationOptionsBase } from "./../modelsToBeSharedWithEventHubs.js";
 import type { AbortSignalLike } from "@azure/abort-controller";

sdk/servicebus/service-bus/src/dataTransformer.ts

@@ -3,7 +3,6 @@
 
 import { message } from "rhea-promise";
 import isBuffer from "is-buffer";
-// eslint-disable-next-line @typescript-eslint/no-redeclare
 import { Buffer } from "buffer";
 import { logErrorStackTrace, logger } from "./log.js";
 

sdk/servicebus/service-bus/src/receivers/receiverCommon.ts

@@ -387,7 +387,6 @@ export async function retryForever<T>(
 
   // The retries are broken up into cycles, giving the user some control over how often
   // we actually attempt to retry.
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     ++numRetryCycles;
 

sdk/servicebus/service-bus/src/serviceBusMessage.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT License.
 
 import { AmqpAnnotatedMessage, Constants } from "@azure/core-amqp";
-// eslint-disable-next-line @typescript-eslint/no-redeclare
 import { Buffer } from "buffer";
 import Long from "long";
 import type {

sdk/servicebus/service-bus/src/util/atomXmlHelper.ts

@@ -12,7 +12,6 @@ import { parseXML, stringifyXML } from "@azure/core-xml";
 
 import * as Constants from "./constants.js";
 import { administrationLogger as logger } from "../log.js";
-// eslint-disable-next-line @typescript-eslint/no-redeclare
 import { Buffer } from "buffer";
 
 import { parseURL } from "./parseUrl.js";

sdk/servicebus/service-bus/src/util/utils.ts

@@ -562,7 +562,6 @@ export async function waitForTimeoutOrAbortOrResolve<T>(args: {
     }
   };
 
-  // eslint-disable-next-line promise/param-names
   const abortOrTimeoutPromise = new Promise<T>((_resolve, reject) => {
     clearAbortSignal = checkAndRegisterWithAbortSignal(reject, args.abortSignal);
 

sdk/servicebus/service-bus/test/internal/unit/dataTransformer.spec.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-// eslint-disable-next-line @typescript-eslint/no-redeclare
 import { Buffer } from "buffer";
 import isBuffer from "is-buffer";
 import { defaultDataTransformer } from "../../../src/dataTransformer.js";

sdk/servicebus/service-bus/tsconfig.json

@@ -1,15 +1,9 @@
 {
   "extends": "../../../tsconfig",
-  "compilerOptions": {
-    "target": "ES2020",
-    "module": "NodeNext",
-    "paths": {
-      "@azure/service-bus": ["./src/index"]
-    },
-    "moduleResolution": "NodeNext",
-    "rootDir": ".",
-    "skipLibCheck": true
-  },
-  "exclude": ["node_modules", "./types/**/*.d.ts", "./samples/**/*.ts", "test/stress*"],
-  "include": ["src/**/*.ts", "src/**/*.mts", "src/**/*.cts", "samples-dev/**/*.ts", "test/**/*.ts"]
+  "references": [
+    { "path": "./tsconfig.src.json" },
+    { "path": "./tsconfig.samples.json" },
+    { "path": "./tsconfig.test.json" }
+  ],
+  "files": []
 }

sdk/servicebus/service-bus/tsconfig.samples.json

@@ -0,0 +1,8 @@
+{
+  "extends": "../../../tsconfig.samples.base.json",
+  "compilerOptions": {
+    "paths": {
+      "@azure/service-bus": ["./dist/esm"]
+    }
+  }
+}

sdk/servicebus/service-bus/tsconfig.src.json

@@ -0,0 +1,6 @@
+{
+  "extends": "../../../tsconfig.lib.json",
+  "compilerOptions": {
+    "skipLibCheck": true
+  }
+}

sdk/servicebus/service-bus/tsconfig.test.json

@@ -0,0 +1,3 @@
+{
+  "extends": ["./tsconfig.src.json", "../../../tsconfig.test.base.json"]
+}

sdk/servicebus/service-bus/vitest.config.ts

@@ -24,6 +24,11 @@ export default mergeConfig(
           "Date",
         ],
       },
+      typecheck: {
+        enabled: true,
+        tsconfig: "tsconfig.test.json",
+        include: ["test/**/*.ts", "test/**/*.mts", "test/**/*.cts"],
+      },
     },
   }),
 );

sdk/servicebus/service-bus/vitest.esm.config.ts

@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+import { mergeConfig } from "vitest/config";
+import vitestConfig from "./vitest.config.ts";
+import vitestEsmConfig from "../../../vitest.esm.shared.config.ts";
+
+export default mergeConfig(
+  vitestConfig,
+  vitestEsmConfig
+);

tsconfig.test.base.json

@@ -3,5 +3,6 @@
   "compilerOptions": {
     "skipLibCheck": true
   },
-  "include": ["${configDir}/test", "${configDir}/src"]
+  "include": ["${configDir}/test", "${configDir}/src"],
+  "exclude": ["${configDir}/test/stress"]
 }