Implement skeleton for Resource collection (#49364)

live1206 · web-flow · commit 51a402c03f92 · 2025-04-15T09:28:17.000+08:00
diff --git a/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/ManagementOutputLibrary.cs b/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/ManagementOutputLibrary.cs
@@ -18,40 +18,46 @@ public class ManagementOutputLibrary : AzureOutputLibrary
         private ManagementLongRunningOperationProvider? _genericArmOperation;
         internal ManagementLongRunningOperationProvider GenericArmOperation => _genericArmOperation ??= new ManagementLongRunningOperationProvider(true);
 
-        private IReadOnlyList<ResourceClientProvider> BuildResources()
+        private (IReadOnlyList<ResourceClientProvider> Resources, IReadOnlyList<ResourceCollectionClientProvider> Collection) BuildResources()
         {
-            var result = new List<ResourceClientProvider>();
+            var resources = new List<ResourceClientProvider>();
+            var collections = new List<ResourceCollectionClientProvider>();
             foreach (var client in ManagementClientGenerator.Instance.InputLibrary.InputNamespace.Clients)
             {
-                BuildResourceCore(result, client);
+                BuildResourceCore(resources, collections, client);
             }
-            return result;
+            return (resources, collections);
         }
 
-        private static void BuildResourceCore(List<ResourceClientProvider> result, Microsoft.TypeSpec.Generator.Input.InputClient client)
+        private static void BuildResourceCore(List<ResourceClientProvider> resources, List<ResourceCollectionClientProvider> collections, Microsoft.TypeSpec.Generator.Input.InputClient client)
         {
             // A resource client should contain the decorator "Azure.ResourceManager.@resourceMetadata"
             var resourceMetadata = client.Decorators.FirstOrDefault(d => d.Name.Equals(KnownDecorators.ResourceMetadata));
             if (resourceMetadata is not null)
             {
                 var resource = new ResourceClientProvider(client);
                 ManagementClientGenerator.Instance.AddTypeToKeep(resource.Name);
-                result.Add(resource);
+                resources.Add(resource);
+                var isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var result) == true ? result.ToObjectFromJson<string>() == "true" : false;
+                if (!isSingleton)
+                {
+                    var collection = new ResourceCollectionClientProvider(client, resource);
+                    ManagementClientGenerator.Instance.AddTypeToKeep(collection.Name);
+                    collections.Add(collection);
+                }
             }
 
             foreach (var child in client.Children)
             {
-                BuildResourceCore(result, child);
+                BuildResourceCore(resources, collections, child);
             }
         }
 
         /// <inheritdoc/>
-        // TODO: generate collections
         protected override TypeProvider[] BuildTypeProviders()
         {
-            var resources = BuildResources();
-            var test = base.BuildTypeProviders();
-            return [.. test, ArmOperation, GenericArmOperation, .. resources, .. resources.Select(r => r.Source)];
+            var (resources, collections) = BuildResources();
+            return [.. base.BuildTypeProviders(), ArmOperation, GenericArmOperation, .. resources, .. collections, .. resources.Select(r => r.Source)];
         }
     }
 }
diff --git a/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/Providers/ResourceClientProvider.cs b/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/Providers/ResourceClientProvider.cs
@@ -32,20 +32,20 @@ namespace Azure.Generator.Management.Providers
     internal class ResourceClientProvider : TypeProvider
     {
         private IReadOnlyCollection<InputOperation> _resourceOperations;
-        private ClientProvider _clientProvider;
         private readonly IReadOnlyList<string> _contextualParameters;
         private bool _isSingleton;
 
         private FieldProvider _dataField;
-        private FieldProvider _clientDiagonosticsField;
-        private FieldProvider _restClientField;
         private FieldProvider _resourcetypeField;
+        protected ClientProvider _clientProvider;
+        protected FieldProvider _clientDiagonosticsField;
+        protected FieldProvider _restClientField;
 
         public ResourceClientProvider(InputClient inputClient)
         {
             var resourceMetadata = inputClient.Decorators.Single(d => d.Name.Equals(KnownDecorators.ResourceMetadata));
             var codeModelId = resourceMetadata.Arguments?[KnownDecorators.ResourceModel].ToObjectFromJson<string>()!;
-            _isSingleton = _isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var isSingleton) == true ? isSingleton.ToObjectFromJson<string>() == "true" : false;
+            _isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var isSingleton) == true ? isSingleton.ToObjectFromJson<string>() == "true" : false;
             var resourceType = resourceMetadata.Arguments?[KnownDecorators.ResourceType].ToObjectFromJson<string>()!;
             _resourcetypeField = new FieldProvider(FieldModifiers.Public | FieldModifiers.Static | FieldModifiers.ReadOnly, typeof(ResourceType), "ResourceType", this, description: $"Gets the resource type for the operations.", initializationValue: Literal(resourceType));
             var resourceModel = ManagementClientGenerator.Instance.InputLibrary.GetModelByCrossLanguageDefinitionId(codeModelId)!;
@@ -144,7 +144,7 @@ private ConstructorProvider BuildPrimaryConstructor()
             return new ConstructorProvider(signature, bodyStatements, this);
         }
 
-        private ConstructorProvider BuildInitializationConstructor()
+        protected ConstructorProvider BuildInitializationConstructor()
         {
             var idParameter = new ParameterProvider("id", $"The identifier of the resource that is the target of operations.", typeof(ResourceIdentifier));
             var parameters = new List<ParameterProvider>
@@ -164,7 +164,7 @@ private ConstructorProvider BuildInitializationConstructor()
 
             var bodyStatements = new MethodBodyStatement[]
             {
-                _clientDiagonosticsField.Assign(New.Instance(typeof(ClientDiagnostics), Literal(Type.Namespace), _resourcetypeField.Property(nameof(ResourceType.Namespace)), This.Property("Diagnostics"))).Terminate(),
+                _clientDiagonosticsField.Assign(New.Instance(typeof(ClientDiagnostics), Literal(Type.Namespace), ResourceTypeExpression.Property(nameof(ResourceType.Namespace)), This.Property("Diagnostics"))).Terminate(),
                 TryGetApiVersion(out var apiVersion).Terminate(),
                 _restClientField.Assign(New.Instance(_clientProvider.Type, This.Property("Pipeline"), This.Property("Endpoint"), apiVersion)).Terminate(),
                 Static(Type).Invoke(ValidateResourceIdMethodName, idParameter).Terminate()
@@ -174,7 +174,7 @@ private ConstructorProvider BuildInitializationConstructor()
         }
 
         private const string ValidateResourceIdMethodName = "ValidateResourceId";
-        private MethodProvider BuildValidateResourceIdMethod()
+        protected MethodProvider BuildValidateResourceIdMethod()
         {
             var idParameter = new ParameterProvider("id", $"", typeof(ResourceIdentifier));
             var signature = new MethodSignature(
@@ -187,13 +187,17 @@ private MethodProvider BuildValidateResourceIdMethod()
                     idParameter
                 ],
                 [new AttributeStatement(typeof(ConditionalAttribute), Literal("DEBUG"))]);
-            var bodyStatements = new IfStatement(idParameter.NotEqual(_resourcetypeField))
+            var bodyStatements = new IfStatement(idParameter.NotEqual(ExpectedResourceTypeForValidation))
             {
-                Throw(New.ArgumentException(idParameter, StringSnippets.Format(Literal("Invalid resource type {0} expected {1}"), idParameter.Property(nameof(ResourceIdentifier.ResourceType)), _resourcetypeField), false))
+                Throw(New.ArgumentException(idParameter, StringSnippets.Format(Literal("Invalid resource type {0} expected {1}"), idParameter.Property(nameof(ResourceIdentifier.ResourceType)), ResourceTypeExpression), false))
             };
             return new MethodProvider(signature, bodyStatements, this);
         }
 
+        protected virtual ValueExpression ResourceTypeExpression => _resourcetypeField;
+
+        protected virtual ValueExpression ExpectedResourceTypeForValidation => _resourcetypeField;
+
         protected override CSharpType[] BuildImplements() => [typeof(ArmResource)];
 
         protected override MethodProvider[] BuildMethods()
@@ -246,7 +250,7 @@ private MethodProvider BuildOperationMethod(InputOperation operation, MethodProv
             return new MethodProvider(signature, bodyStatements, this);
         }
 
-        private IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProvider convenienceMethod, bool isLongRunning)
+        protected IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProvider convenienceMethod, bool isLongRunning)
         {
             var result = new List<ParameterProvider>();
             if (isLongRunning)
@@ -263,7 +267,7 @@ private IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProv
             return result;
         }
 
-        private CSharpType GetOperationMethodReturnType(bool isAsync, bool isLongRunningOperation, IReadOnlyList<InputOperationResponse> operationResponses, out bool isGeneric)
+        protected CSharpType GetOperationMethodReturnType(bool isAsync, bool isLongRunningOperation, IReadOnlyList<InputOperationResponse> operationResponses, out bool isGeneric)
         {
             isGeneric = false;
             if (isLongRunningOperation)
@@ -372,7 +376,7 @@ private ValueExpression[] PopulateArguments(IReadOnlyList<ParameterProvider> par
         }
 
         // TODO: get clean name of operation Name
-        private MethodProvider GetCorrespondingConvenienceMethod(InputOperation operation, bool isAsync)
+        protected MethodProvider GetCorrespondingConvenienceMethod(InputOperation operation, bool isAsync)
             => _clientProvider.CanonicalView.Methods.Single(m => m.Signature.Name.Equals(isAsync ? $"{operation.Name}Async" : operation.Name, StringComparison.OrdinalIgnoreCase) && m.Signature.Parameters.Any(p => p.Type.Equals(typeof(CancellationToken))));
 
         private MethodProvider GetCorrespondingRequestMethod(InputOperation operation)
@@ -382,7 +386,7 @@ public ScopedApi<bool> TryGetApiVersion(out ScopedApi<string> apiVersion)
         {
             var apiVersionDeclaration = new VariableExpression(typeof(string), $"{SpecName.ToLower()}ApiVersion");
             apiVersion = apiVersionDeclaration.As<string>();
-            var invocation = new InvokeMethodExpression(This, "TryGetApiVersion", [_resourcetypeField, new DeclarationExpression(apiVersionDeclaration, true)]);
+            var invocation = new InvokeMethodExpression(This, "TryGetApiVersion", [ResourceTypeExpression, new DeclarationExpression(apiVersionDeclaration, true)]);
             return invocation.As<bool>();
         }
     }
diff --git a/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/Providers/ResourceCollectionClientProvider.cs b/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Mgmt/src/Providers/ResourceCollectionClientProvider.cs
@@ -0,0 +1,126 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using Azure.Generator.Management.Primitives;
+using Azure.Generator.Management.Utilities;
+using Azure.ResourceManager;
+using Azure.ResourceManager.Resources;
+using Microsoft.TypeSpec.Generator.Expressions;
+using Microsoft.TypeSpec.Generator.Input;
+using Microsoft.TypeSpec.Generator.Primitives;
+using Microsoft.TypeSpec.Generator.Providers;
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Net.Http;
+using static Microsoft.TypeSpec.Generator.Snippets.Snippet;
+
+namespace Azure.Generator.Management.Providers
+{
+    internal class ResourceCollectionClientProvider : ResourceClientProvider
+    {
+        private ResourceClientProvider _resource;
+        private InputOperation? _getAll;
+        private InputOperation? _create;
+        private InputOperation? _get;
+
+        public ResourceCollectionClientProvider(InputClient inputClient, ResourceClientProvider resource) : base(inputClient)
+        {
+            _resource = resource;
+
+            foreach (var operation in inputClient.Operations)
+            {
+                if (operation.HttpMethod == HttpMethod.Get.ToString())
+                {
+                    if (operation.Name == "list")
+                    {
+                        _getAll = operation;
+                    }
+                    else if (operation.Name == "get")
+                    {
+                        _get = operation;
+                    }
+                }
+                if (operation.HttpMethod == HttpMethod.Put.ToString() && operation.Name == "createOrUpdate")
+                {
+                    _create = operation;
+                }
+            }
+        }
+
+        protected override string BuildName() => $"{SpecName}Collection";
+
+        protected override CSharpType[] BuildImplements() =>
+            _getAll is null
+            ? [typeof(ArmCollection)]
+            : [typeof(ArmCollection), new CSharpType(typeof(IEnumerable<>), _resource.Type), new CSharpType(typeof(IAsyncEnumerable<>), _resource.Type)];
+
+        protected override PropertyProvider[] BuildProperties() => [];
+
+        protected override FieldProvider[] BuildFields() => [_clientDiagonosticsField, _restClientField];
+
+        protected override ConstructorProvider[] BuildConstructors()
+            => [ConstructorProviderHelper.BuildMockingConstructor(this), BuildInitializationConstructor()];
+
+        protected override ValueExpression ExpectedResourceTypeForValidation => Static(typeof(ResourceGroupResource)).Property("ResourceType");
+
+        protected override ValueExpression ResourceTypeExpression => Static(_resource.Type).Property("ResourceType");
+
+        // TODO: build GetIfExists, GetIfExistsAsync, Exists, ExistsAsync, Get, GetAsync, CreateOrUpdate, CreateOrUpdateAsync methods
+        protected override MethodProvider[] BuildMethods() => [BuildValidateResourceIdMethod(), .. BuildGetAllMethods()];
+
+        private MethodProvider[] BuildGetAllMethods()
+        {
+            // implement paging method GetAll
+            var getAll = BuildGetAllMethod(false);
+            var getAllAsync = BuildGetAllMethod(true);
+
+            return [getAll, getAllAsync, .. BuildEnumeratorMethods()];
+        }
+
+        private MethodProvider[] BuildEnumeratorMethods()
+        {
+            if (_getAll is null)
+            {
+                return [];
+            }
+
+            const string getEnumeratormethodName = "GetEnumerator";
+            var body = Return(This.Invoke("GetAll").Invoke("GetEnumerator"));
+            var getEnumeratorMethod = new MethodProvider(
+                new MethodSignature(getEnumeratormethodName, null, MethodSignatureModifiers.None, typeof(IEnumerator), null, [], ExplicitInterface: typeof(IEnumerable)),
+                body,
+                this);
+            var getEnumeratorOfTMethod = new MethodProvider(
+                new MethodSignature(getEnumeratormethodName, null, MethodSignatureModifiers.None, new CSharpType(typeof(IEnumerator<>), _resource.Type), null, [], ExplicitInterface: new CSharpType(typeof(IEnumerable<>), _resource.Type)),
+                body,
+                this);
+            var getEnumeratorAsyncMethod = new MethodProvider(
+                new MethodSignature("GetAsyncEnumerator", null, MethodSignatureModifiers.None, new CSharpType(typeof(IAsyncEnumerator<>), _resource.Type), null, [KnownAzureParameters.CancellationTokenWithoutDefault], ExplicitInterface: new CSharpType(typeof(IAsyncEnumerable<>), _resource.Type)),
+                Return(This.Invoke("GetAllAsync", [KnownAzureParameters.CancellationTokenWithoutDefault]).Invoke("GetAsyncEnumerator", [KnownAzureParameters.CancellationTokenWithoutDefault])),
+                this);
+            return [getEnumeratorMethod, getEnumeratorOfTMethod, getEnumeratorAsyncMethod];
+        }
+
+        private MethodProvider BuildGetAllMethod(bool isAsync)
+        {
+            var convenienceMethod = GetCorrespondingConvenienceMethod(_getAll!, isAsync);
+            var isLongRunning = _getAll?.LongRunning != null;
+            var signature = new MethodSignature(
+                isAsync ? "GetAllAsync" : "GetAll",
+                convenienceMethod.Signature.Description,
+                convenienceMethod.Signature.Modifiers,
+                isAsync ? new CSharpType(typeof(AsyncPageable<>), _resource.Type) : new CSharpType(typeof(Pageable<>), _resource.Type),
+                convenienceMethod.Signature.ReturnDescription,
+                GetOperationMethodParameters(convenienceMethod, isLongRunning),
+                convenienceMethod.Signature.Attributes,
+                convenienceMethod.Signature.GenericArguments,
+                convenienceMethod.Signature.GenericParameterConstraints,
+                convenienceMethod.Signature.ExplicitInterface,
+                convenienceMethod.Signature.NonDocumentComment);
+
+            // TODO: implement paging method properly
+            return new MethodProvider(signature, ThrowExpression(New.Instance(typeof(NotImplementedException))), this);
+        }
+    }
+}
diff --git a/eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/FooCollection.cs b/eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/FooCollection.cs

Original file line number	Diff line number	Diff line change
`@@ -18,40 +18,46 @@ public class ManagementOutputLibrary : AzureOutputLibrary`
`18`	`18`	`private ManagementLongRunningOperationProvider? _genericArmOperation;`
`19`	`19`	`internal ManagementLongRunningOperationProvider GenericArmOperation => _genericArmOperation ??= new ManagementLongRunningOperationProvider(true);`
`20`	`20`
`21`		`- private IReadOnlyList<ResourceClientProvider> BuildResources()`
	`21`	`+ private (IReadOnlyList<ResourceClientProvider> Resources, IReadOnlyList<ResourceCollectionClientProvider> Collection) BuildResources()`
`22`	`22`	`{`
`23`		`- var result = new List<ResourceClientProvider>();`
	`23`	`+ var resources = new List<ResourceClientProvider>();`
	`24`	`+ var collections = new List<ResourceCollectionClientProvider>();`
`24`	`25`	`foreach (var client in ManagementClientGenerator.Instance.InputLibrary.InputNamespace.Clients)`
`25`	`26`	`{`
`26`		`- BuildResourceCore(result, client);`
	`27`	`+ BuildResourceCore(resources, collections, client);`
`27`	`28`	`}`
`28`		`- return result;`
	`29`	`+ return (resources, collections);`
`29`	`30`	`}`
`30`	`31`
`31`		`- private static void BuildResourceCore(List<ResourceClientProvider> result, Microsoft.TypeSpec.Generator.Input.InputClient client)`
	`32`	`+ private static void BuildResourceCore(List<ResourceClientProvider> resources, List<ResourceCollectionClientProvider> collections, Microsoft.TypeSpec.Generator.Input.InputClient client)`
`32`	`33`	`{`
`33`	`34`	`// A resource client should contain the decorator "Azure.ResourceManager.@resourceMetadata"`
`34`	`35`	`var resourceMetadata = client.Decorators.FirstOrDefault(d => d.Name.Equals(KnownDecorators.ResourceMetadata));`
`35`	`36`	`if (resourceMetadata is not null)`
`36`	`37`	`{`
`37`	`38`	`var resource = new ResourceClientProvider(client);`
`38`	`39`	`ManagementClientGenerator.Instance.AddTypeToKeep(resource.Name);`
`39`		`- result.Add(resource);`
	`40`	`+ resources.Add(resource);`
	`41`	`+ var isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var result) == true ? result.ToObjectFromJson<string>() == "true" : false;`
	`42`	`+ if (!isSingleton)`
	`43`	`+ {`
	`44`	`+ var collection = new ResourceCollectionClientProvider(client, resource);`
	`45`	`+ ManagementClientGenerator.Instance.AddTypeToKeep(collection.Name);`
	`46`	`+ collections.Add(collection);`
	`47`	`+ }`
`40`	`48`	`}`
`41`	`49`
`42`	`50`	`foreach (var child in client.Children)`
`43`	`51`	`{`
`44`		`- BuildResourceCore(result, child);`
	`52`	`+ BuildResourceCore(resources, collections, child);`
`45`	`53`	`}`
`46`	`54`	`}`
`47`	`55`
`48`	`56`	`/// <inheritdoc/>`
`49`		`- // TODO: generate collections`
`50`	`57`	`protected override TypeProvider[] BuildTypeProviders()`
`51`	`58`	`{`
`52`		`- var resources = BuildResources();`
`53`		`- var test = base.BuildTypeProviders();`
`54`		`- return [.. test, ArmOperation, GenericArmOperation, .. resources, .. resources.Select(r => r.Source)];`
	`59`	`+ var (resources, collections) = BuildResources();`
	`60`	`+ return [.. base.BuildTypeProviders(), ArmOperation, GenericArmOperation, .. resources, .. collections, .. resources.Select(r => r.Source)];`
`55`	`61`	`}`
`56`	`62`	`}`
`57`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,20 +32,20 @@ namespace Azure.Generator.Management.Providers`
`32`	`32`	`internal class ResourceClientProvider : TypeProvider`
`33`	`33`	`{`
`34`	`34`	`private IReadOnlyCollection<InputOperation> _resourceOperations;`
`35`		`- private ClientProvider _clientProvider;`
`36`	`35`	`private readonly IReadOnlyList<string> _contextualParameters;`
`37`	`36`	`private bool _isSingleton;`
`38`	`37`
`39`	`38`	`private FieldProvider _dataField;`
`40`		`- private FieldProvider _clientDiagonosticsField;`
`41`		`- private FieldProvider _restClientField;`
`42`	`39`	`private FieldProvider _resourcetypeField;`
	`40`	`+ protected ClientProvider _clientProvider;`
	`41`	`+ protected FieldProvider _clientDiagonosticsField;`
	`42`	`+ protected FieldProvider _restClientField;`
`43`	`43`
`44`	`44`	`public ResourceClientProvider(InputClient inputClient)`
`45`	`45`	`{`
`46`	`46`	`var resourceMetadata = inputClient.Decorators.Single(d => d.Name.Equals(KnownDecorators.ResourceMetadata));`
`47`	`47`	`var codeModelId = resourceMetadata.Arguments?[KnownDecorators.ResourceModel].ToObjectFromJson<string>()!;`
`48`		`- _isSingleton = _isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var isSingleton) == true ? isSingleton.ToObjectFromJson<string>() == "true" : false;`
	`48`	`+ _isSingleton = resourceMetadata.Arguments?.TryGetValue("isSingleton", out var isSingleton) == true ? isSingleton.ToObjectFromJson<string>() == "true" : false;`
`49`	`49`	`var resourceType = resourceMetadata.Arguments?[KnownDecorators.ResourceType].ToObjectFromJson<string>()!;`
`50`	`50`	`_resourcetypeField = new FieldProvider(FieldModifiers.Public \| FieldModifiers.Static \| FieldModifiers.ReadOnly, typeof(ResourceType), "ResourceType", this, description: $"Gets the resource type for the operations.", initializationValue: Literal(resourceType));`
`51`	`51`	`var resourceModel = ManagementClientGenerator.Instance.InputLibrary.GetModelByCrossLanguageDefinitionId(codeModelId)!;`
`@@ -144,7 +144,7 @@ private ConstructorProvider BuildPrimaryConstructor()`
`144`	`144`	`return new ConstructorProvider(signature, bodyStatements, this);`
`145`	`145`	`}`
`146`	`146`
`147`		`- private ConstructorProvider BuildInitializationConstructor()`
	`147`	`+ protected ConstructorProvider BuildInitializationConstructor()`
`148`	`148`	`{`
`149`	`149`	`var idParameter = new ParameterProvider("id", $"The identifier of the resource that is the target of operations.", typeof(ResourceIdentifier));`
`150`	`150`	`var parameters = new List<ParameterProvider>`
`@@ -164,7 +164,7 @@ private ConstructorProvider BuildInitializationConstructor()`
`164`	`164`
`165`	`165`	`var bodyStatements = new MethodBodyStatement[]`
`166`	`166`	`{`
`167`		`- _clientDiagonosticsField.Assign(New.Instance(typeof(ClientDiagnostics), Literal(Type.Namespace), _resourcetypeField.Property(nameof(ResourceType.Namespace)), This.Property("Diagnostics"))).Terminate(),`
	`167`	`+ _clientDiagonosticsField.Assign(New.Instance(typeof(ClientDiagnostics), Literal(Type.Namespace), ResourceTypeExpression.Property(nameof(ResourceType.Namespace)), This.Property("Diagnostics"))).Terminate(),`
`168`	`168`	`TryGetApiVersion(out var apiVersion).Terminate(),`
`169`	`169`	`_restClientField.Assign(New.Instance(_clientProvider.Type, This.Property("Pipeline"), This.Property("Endpoint"), apiVersion)).Terminate(),`
`170`	`170`	`Static(Type).Invoke(ValidateResourceIdMethodName, idParameter).Terminate()`
`@@ -174,7 +174,7 @@ private ConstructorProvider BuildInitializationConstructor()`
`174`	`174`	`}`
`175`	`175`
`176`	`176`	`private const string ValidateResourceIdMethodName = "ValidateResourceId";`
`177`		`- private MethodProvider BuildValidateResourceIdMethod()`
	`177`	`+ protected MethodProvider BuildValidateResourceIdMethod()`
`178`	`178`	`{`
`179`	`179`	`var idParameter = new ParameterProvider("id", $"", typeof(ResourceIdentifier));`
`180`	`180`	`var signature = new MethodSignature(`
`@@ -187,13 +187,17 @@ private MethodProvider BuildValidateResourceIdMethod()`
`187`	`187`	`idParameter`
`188`	`188`	`],`
`189`	`189`	`[new AttributeStatement(typeof(ConditionalAttribute), Literal("DEBUG"))]);`
`190`		`- var bodyStatements = new IfStatement(idParameter.NotEqual(_resourcetypeField))`
	`190`	`+ var bodyStatements = new IfStatement(idParameter.NotEqual(ExpectedResourceTypeForValidation))`
`191`	`191`	`{`
`192`		`- Throw(New.ArgumentException(idParameter, StringSnippets.Format(Literal("Invalid resource type {0} expected {1}"), idParameter.Property(nameof(ResourceIdentifier.ResourceType)), _resourcetypeField), false))`
	`192`	`+ Throw(New.ArgumentException(idParameter, StringSnippets.Format(Literal("Invalid resource type {0} expected {1}"), idParameter.Property(nameof(ResourceIdentifier.ResourceType)), ResourceTypeExpression), false))`
`193`	`193`	`};`
`194`	`194`	`return new MethodProvider(signature, bodyStatements, this);`
`195`	`195`	`}`
`196`	`196`
	`197`	`+ protected virtual ValueExpression ResourceTypeExpression => _resourcetypeField;`
	`198`	`+`
	`199`	`+ protected virtual ValueExpression ExpectedResourceTypeForValidation => _resourcetypeField;`
	`200`	`+`
`197`	`201`	`protected override CSharpType[] BuildImplements() => [typeof(ArmResource)];`
`198`	`202`
`199`	`203`	`protected override MethodProvider[] BuildMethods()`
`@@ -246,7 +250,7 @@ private MethodProvider BuildOperationMethod(InputOperation operation, MethodProv`
`246`	`250`	`return new MethodProvider(signature, bodyStatements, this);`
`247`	`251`	`}`
`248`	`252`
`249`		`- private IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProvider convenienceMethod, bool isLongRunning)`
	`253`	`+ protected IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProvider convenienceMethod, bool isLongRunning)`
`250`	`254`	`{`
`251`	`255`	`var result = new List<ParameterProvider>();`
`252`	`256`	`if (isLongRunning)`
`@@ -263,7 +267,7 @@ private IReadOnlyList<ParameterProvider> GetOperationMethodParameters(MethodProv`
`263`	`267`	`return result;`
`264`	`268`	`}`
`265`	`269`
`266`		`- private CSharpType GetOperationMethodReturnType(bool isAsync, bool isLongRunningOperation, IReadOnlyList<InputOperationResponse> operationResponses, out bool isGeneric)`
	`270`	`+ protected CSharpType GetOperationMethodReturnType(bool isAsync, bool isLongRunningOperation, IReadOnlyList<InputOperationResponse> operationResponses, out bool isGeneric)`
`267`	`271`	`{`
`268`	`272`	`isGeneric = false;`
`269`	`273`	`if (isLongRunningOperation)`
`@@ -372,7 +376,7 @@ private ValueExpression[] PopulateArguments(IReadOnlyList<ParameterProvider> par`
`372`	`376`	`}`
`373`	`377`
`374`	`378`	`// TODO: get clean name of operation Name`
`375`		`- private MethodProvider GetCorrespondingConvenienceMethod(InputOperation operation, bool isAsync)`
	`379`	`+ protected MethodProvider GetCorrespondingConvenienceMethod(InputOperation operation, bool isAsync)`
`376`	`380`	`=> _clientProvider.CanonicalView.Methods.Single(m => m.Signature.Name.Equals(isAsync ? $"{operation.Name}Async" : operation.Name, StringComparison.OrdinalIgnoreCase) && m.Signature.Parameters.Any(p => p.Type.Equals(typeof(CancellationToken))));`
`377`	`381`
`378`	`382`	`private MethodProvider GetCorrespondingRequestMethod(InputOperation operation)`
`@@ -382,7 +386,7 @@ public ScopedApi<bool> TryGetApiVersion(out ScopedApi<string> apiVersion)`
`382`	`386`	`{`
`383`	`387`	`var apiVersionDeclaration = new VariableExpression(typeof(string), $"{SpecName.ToLower()}ApiVersion");`
`384`	`388`	`apiVersion = apiVersionDeclaration.As<string>();`
`385`		`- var invocation = new InvokeMethodExpression(This, "TryGetApiVersion", [_resourcetypeField, new DeclarationExpression(apiVersionDeclaration, true)]);`
	`389`	`+ var invocation = new InvokeMethodExpression(This, "TryGetApiVersion", [ResourceTypeExpression, new DeclarationExpression(apiVersionDeclaration, true)]);`
`386`	`390`	`return invocation.As<bool>();`
`387`	`391`	`}`
`388`	`392`	`}`