Exception messages for file share clients when for emulator connection string (#48484)

* Implement emulator checks

* Add tests

* Change from recorded tests into unit tests

* Fix unit test issues

* Use correct connection string

Author: lilinus

sdk/storage/Azure.Storage.Files.Shares/src/ShareClient.cs

@@ -158,6 +158,7 @@ public ShareClient(
             Argument.AssertNotNullOrWhiteSpace(shareName, nameof(shareName));
             options ??= new ShareClientOptions();
             var conn = StorageConnectionString.Parse(connectionString);
+            ShareErrors.AssertNotDevelopment(conn, nameof(connectionString));
             ShareUriBuilder uriBuilder = new ShareUriBuilder(conn.FileEndpoint) { ShareName = shareName };
             _uri = uriBuilder.ToUri();
             _accountName = conn.AccountName;

sdk/storage/Azure.Storage.Files.Shares/src/ShareDirectoryClient.cs

@@ -193,6 +193,7 @@ public ShareDirectoryClient(
             Argument.AssertNotNullOrWhiteSpace(shareName, nameof(shareName));
             options ??= new ShareClientOptions();
             var conn = StorageConnectionString.Parse(connectionString);
+            ShareErrors.AssertNotDevelopment(conn, nameof(connectionString));
             ShareUriBuilder uriBuilder =
                 new ShareUriBuilder(conn.FileEndpoint)
                 {

sdk/storage/Azure.Storage.Files.Shares/src/ShareErrors.cs

@@ -32,5 +32,13 @@ public static void AssertAlgorithmSupport(StorageChecksumAlgorithm? algorithm)
                     throw new ArgumentException($"{nameof(StorageChecksumAlgorithm)} does not support value {Enum.GetName(typeof(StorageChecksumAlgorithm), resolved) ?? ((int)resolved).ToString(CultureInfo.InvariantCulture)}.");
             }
         }
+
+        public static void AssertNotDevelopment(StorageConnectionString conn, string argumentName)
+        {
+            if (conn.IsDevStoreAccount)
+            {
+                throw new ArgumentException("Connection string for emulator is not valid for Azure File Shares", argumentName);
+            }
+        }
     }
 }

sdk/storage/Azure.Storage.Files.Shares/src/ShareFileClient.cs

@@ -203,6 +203,7 @@ public ShareFileClient(
             Argument.AssertNotNullOrWhiteSpace(filePath, nameof(filePath));
             options ??= new ShareClientOptions();
             var conn = StorageConnectionString.Parse(connectionString);
+            ShareErrors.AssertNotDevelopment(conn, nameof(connectionString));
             ShareUriBuilder uriBuilder =
                 new ShareUriBuilder(conn.FileEndpoint)
                 {

sdk/storage/Azure.Storage.Files.Shares/src/ShareServiceClient.cs

@@ -129,6 +129,7 @@ public ShareServiceClient(
         {
             options ??= new ShareClientOptions();
             var conn = StorageConnectionString.Parse(connectionString);
+            ShareErrors.AssertNotDevelopment(conn, nameof(connectionString));
             _uri = conn.FileEndpoint;
             _accountName = conn.AccountName;
             _clientConfiguration = new ShareClientConfiguration(

sdk/storage/Azure.Storage.Files.Shares/tests/DirectoryClientTests.cs

@@ -198,6 +198,13 @@ public async Task Ctor_CustomAudience()
             Assert.IsNotNull(exists);
         }
 
+        [Test]
+        public void Ctor_DevelopmentThrows()
+        {
+            var ex = Assert.Throws<ArgumentException>(() => new ShareDirectoryClient("UseDevelopmentStorage=true", "share", "dir"));
+            Assert.AreEqual("connectionString", ex.ParamName);
+        }
+
         [RecordedTest]
         public async Task Ctor_StorageAccountAudience()
         {

sdk/storage/Azure.Storage.Files.Shares/tests/FileClientTests.cs

@@ -182,6 +182,13 @@ public async Task Ctor_DefaultAudience()
             Assert.IsNotNull(exists);
         }
 
+        [Test]
+        public void Ctor_DevelopmentThrows()
+        {
+            var ex = Assert.Throws<ArgumentException>(() => new ShareFileClient("UseDevelopmentStorage=true", "share", "dir/file"));
+            Assert.AreEqual("connectionString", ex.ParamName);
+        }
+
         [RecordedTest]
         public async Task Ctor_CustomAudience()
         {

sdk/storage/Azure.Storage.Files.Shares/tests/ServiceClientTests.cs

@@ -103,6 +103,13 @@ public void Ctor_AzureSasCredential_VerifyNoSasInUri()
                 e => e.Message.Contains($"You cannot use {nameof(AzureSasCredential)} when the resource URI also contains a Shared Access Signature"));
         }
 
+        [Test]
+        public void Ctor_DevelopmentThrows()
+        {
+            var ex = Assert.Throws<ArgumentException>(() => new ShareServiceClient("UseDevelopmentStorage=true"));
+            Assert.AreEqual("connectionString", ex.ParamName);
+        }
+
         [RecordedTest]
         public async Task GetPropertiesAsync()
         {

sdk/storage/Azure.Storage.Files.Shares/tests/ShareClientTests.cs

@@ -303,6 +303,13 @@ await TestHelper.AssertExpectedExceptionAsync<RequestFailedException>(
                 e => Assert.AreEqual("InvalidAuthenticationInfo", e.ErrorCode));
         }
 
+        [Test]
+        public void Ctor_DevelopmentThrows()
+        {
+            var ex = Assert.Throws<ArgumentException>(() => new ShareClient("UseDevelopmentStorage=true", "share"));
+            Assert.AreEqual("connectionString", ex.ParamName);
+        }
+
         [RecordedTest]
         public void WithSnapshot()
         {