-
Notifications
You must be signed in to change notification settings - Fork 343
Fix C++ deprecated packages support and migrate track 1 packages from .NET CSV #8999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… index Co-authored-by: RickWinter <[email protected]>
Co-authored-by: RickWinter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the deprecated package listing for C++, adds a C++ section to the deprecated index, and moves three C++ Track 1 packages from the .NET CSV into the C++ CSV.
- Corrects the Liquid filter logic in
_includes/releases/cpp.mdso deprecated C++ packages display properly - Adds the C++ include to
releases/deprecated/index.md - Removes misclassified C++ packages from
.NETCSV and adds them tocpp-packages.csv
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| releases/deprecated/index.md | Added releases/cpp.md include for deprecated C++ |
| _includes/releases/cpp.md | Fixed conflicting filter logic for deprecated packages |
| _data/releases/latest/dotnet-packages.csv | Removed three C++ Track 1 packages |
| _data/releases/latest/cpp-packages.csv | Added the three migrated C++ Track 1 packages |
Comments suppressed due to low confidence (1)
releases/deprecated/index.md:14
- Indent this include line to match the surrounding entries (e.g., two spaces before
{% include ... %}) for consistent formatting.
{% include releases/cpp.md type="deprecated" %}
Co-authored-by: weshaggard <[email protected]>
Co-authored-by: weshaggard <[email protected]>
…oach Co-authored-by: ronniegeraghty <[email protected]>
|
@copilot The generated output is referencing broken links. Fix the links. |
Co-authored-by: RickWinter <[email protected]>
Fixed the broken package download links. The Microsoft.Azure.Storage.CPP packages now point to their actual NuGet URLs instead of generating broken GitHub archive links. The wastorage packages already had "NA" RepoPath values to avoid broken links. All package links should now resolve correctly. Commit 6194798. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR addresses the issue of listing package deprecations for track 1 SDKs in C++ by fixing the infrastructure and migrating misclassified packages.
Changes Made
1. Fixed Template Bug
Fixed a critical bug in
_includes/releases/cpp.mdwhere the deprecated packages filter had conflicting logic:{% elsif include.type == "deprecated" %} {% assign packages = site.data.releases.latest.cpp-packages | where: 'Support', 'deprecated' | where_exp: 'item', "item.Support <> 'deprecated'" %}This was filtering FOR deprecated packages AND AGAINST deprecated packages simultaneously, resulting in no packages being displayed. Fixed to:
{% elsif include.type == "deprecated" %} {% assign packages = site.data.releases.latest.cpp-packages | where: 'Support', 'deprecated' %}2. Added C++ to Deprecated Index
Added C++ section to the deprecated packages page (
releases/deprecated/index.md) so that C++ deprecated packages will be displayed alongside other languages.3. Migrated C++ Track 1 Packages
Found 3 C++ track 1 packages that were incorrectly classified in the .NET CSV file and moved them to the C++ CSV:
Microsoft.Azure.Storage.CPP(deprecated 3/31/2023)Microsoft.Azure.Storage.CPP.v120(deprecated 3/31/2023)Microsoft.Azure.Storage.CPP.v140(deprecated 3/31/2023)All packages include appropriate replacement guidance pointing to the modern
azure-storage-blobspackage and migration documentation.4. Fixed Broken Package Links
Impact
Verification
Fixes #6512.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.