Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make etags, gzip a compile time option #16

Closed
mhaberler opened this issue Jul 27, 2024 · 5 comments · Fixed by #21
Closed

make etags, gzip a compile time option #16

mhaberler opened this issue Jul 27, 2024 · 5 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@mhaberler
Copy link

Hi @BCsabaEngine
thanks for the great package! really appreciated.

If I may add a suggestion - neither substantial nor urgent:

move from build-time to compile time options - which will in many cases take out the build step (when testing or doing variants) - i.e: always generate code for Etags and compression support, but make it conditional with cpp symbols

thanks

Michael

@BCsabaEngine
Copy link
Owner

Would you like to use the options (etag, pre-zip) within cpp directives? Interrest request, I will investigate it. Thanks for idea!

@mhaberler
Copy link
Author

yes, that is the idea
size of the generate header doesnt really matter these days
and it moves all the options to the build stage

in the case of a platformio, this also removes the need to pass build parameters to a pre: script

@BCsabaEngine
Copy link
Owner

With v1.3.x we are prepared to generate (and use it in future) c++ defines: https://github.com/BCsabaEngine/svelteesp32?tab=readme-ov-file#c-defines

@BCsabaEngine
Copy link
Owner

BCsabaEngine commented Aug 18, 2024

v1.4.0 released: https://github.com/BCsabaEngine/svelteesp32/releases/tag/v1.4.0

You can use: --etag=compiler --gzip=compiler command line args to create a (larger) .h file where c++ compiler directives are available: SVELTEESP32_ENABLE_ETAG and SVELTEESP32_ENABLE_GZIP

Give us feedback on whether it meets your expectations!

@BCsabaEngine BCsabaEngine self-assigned this Aug 18, 2024
@BCsabaEngine BCsabaEngine added the enhancement New feature or request label Aug 18, 2024
@BCsabaEngine BCsabaEngine linked a pull request Aug 18, 2024 that will close this issue
@mhaberler
Copy link
Author

bravo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants