Skip to content

Commit a95c5b0

Browse files
committed
Remove GitHub provider hacking code.
1 parent 865a65d commit a95c5b0

File tree

2 files changed

+18
-26
lines changed

2 files changed

+18
-26
lines changed

web/src/Setting.js

+1-9
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,7 @@ export function isProviderVisible(providerItem) {
7070
return false;
7171
}
7272

73-
if (providerItem.provider.type === "GitHub") {
74-
if (isLocalhost()) {
75-
return providerItem.provider.name.includes("localhost");
76-
} else {
77-
return !providerItem.provider.name.includes("localhost");
78-
}
79-
} else {
80-
return true;
81-
}
73+
return true;
8274
}
8375

8476
export function isProviderVisibleForSignUp(providerItem) {

web/src/auth/Provider.js

+17-17
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import React from "react";
1616
import {Tooltip} from "antd";
1717
import * as Util from "./Util";
18-
import {StaticBaseUrl} from "../Setting";
18+
import * as Setting from "../Setting";
1919

2020
const authInfo = {
2121
Google: {
@@ -105,79 +105,79 @@ const authInfo = {
105105
const otherProviderInfo = {
106106
SMS: {
107107
"Aliyun SMS": {
108-
logo: `${StaticBaseUrl}/img/social_aliyun.png`,
108+
logo: `${Setting.StaticBaseUrl}/img/social_aliyun.png`,
109109
url: "https://aliyun.com/product/sms",
110110
},
111111
"Tencent Cloud SMS": {
112-
logo: `${StaticBaseUrl}/img/social_tencent_cloud.jpg`,
112+
logo: `${Setting.StaticBaseUrl}/img/social_tencent_cloud.jpg`,
113113
url: "https://cloud.tencent.com/product/sms",
114114
},
115115
"Volc Engine SMS": {
116-
logo: `${StaticBaseUrl}/img/social_volc_engine.jpg`,
116+
logo: `${Setting.StaticBaseUrl}/img/social_volc_engine.jpg`,
117117
url: "https://www.volcengine.com/products/cloud-sms",
118118
},
119119
"Huawei Cloud SMS": {
120-
logo: `${StaticBaseUrl}/img/social_huawei.png`,
120+
logo: `${Setting.StaticBaseUrl}/img/social_huawei.png`,
121121
url: "https://www.huaweicloud.com/product/msgsms.html",
122122
},
123123
},
124124
Email: {
125125
"Default": {
126-
logo: `${StaticBaseUrl}/img/social_default.png`,
126+
logo: `${Setting.StaticBaseUrl}/img/social_default.png`,
127127
url: "",
128128
},
129129
},
130130
Storage: {
131131
"Local File System": {
132-
logo: `${StaticBaseUrl}/img/social_file.png`,
132+
logo: `${Setting.StaticBaseUrl}/img/social_file.png`,
133133
url: "",
134134
},
135135
"AWS S3": {
136-
logo: `${StaticBaseUrl}/img/social_aws.png`,
136+
logo: `${Setting.StaticBaseUrl}/img/social_aws.png`,
137137
url: "https://aws.amazon.com/s3",
138138
},
139139
"Aliyun OSS": {
140-
logo: `${StaticBaseUrl}/img/social_aliyun.png`,
140+
logo: `${Setting.StaticBaseUrl}/img/social_aliyun.png`,
141141
url: "https://aliyun.com/product/oss",
142142
},
143143
"Tencent Cloud COS": {
144-
logo: `${StaticBaseUrl}/img/social_tencent_cloud.jpg`,
144+
logo: `${Setting.StaticBaseUrl}/img/social_tencent_cloud.jpg`,
145145
url: "https://cloud.tencent.com/product/cos",
146146
},
147147
},
148148
SAML: {
149149
"Aliyun IDaaS": {
150-
logo: `${StaticBaseUrl}/img/social_aliyun.png`,
150+
logo: `${Setting.StaticBaseUrl}/img/social_aliyun.png`,
151151
url: "https://aliyun.com/product/idaas"
152152
},
153153
"Keycloak": {
154-
logo: `${StaticBaseUrl}/img/social_keycloak.png`,
154+
logo: `${Setting.StaticBaseUrl}/img/social_keycloak.png`,
155155
url: "https://www.keycloak.org/"
156156
},
157157
},
158158
Payment: {
159159
"Alipay": {
160-
logo: `${StaticBaseUrl}/img/payment_alipay.png`,
160+
logo: `${Setting.StaticBaseUrl}/img/payment_alipay.png`,
161161
url: "https://www.alipay.com/"
162162
},
163163
"WeChat Pay": {
164-
logo: `${StaticBaseUrl}/img/payment_wechat_pay.png`,
164+
logo: `${Setting.StaticBaseUrl}/img/payment_wechat_pay.png`,
165165
url: "https://pay.weixin.qq.com/"
166166
},
167167
"PayPal": {
168-
logo: `${StaticBaseUrl}/img/payment_paypal.png`,
168+
logo: `${Setting.StaticBaseUrl}/img/payment_paypal.png`,
169169
url: "https://www.paypal.com/"
170170
},
171171
"GC": {
172-
logo: `${StaticBaseUrl}/img/payment_gc.png`,
172+
logo: `${Setting.StaticBaseUrl}/img/payment_gc.png`,
173173
url: "https://gc.org"
174174
},
175175
},
176176
};
177177

178178
export function getProviderLogo(provider) {
179179
if (provider.category === "OAuth") {
180-
return `${StaticBaseUrl}/img/social_${provider.type.toLowerCase()}.png`;
180+
return `${Setting.StaticBaseUrl}/img/social_${provider.type.toLowerCase()}.png`;
181181
} else {
182182
return otherProviderInfo[provider.category][provider.type].logo;
183183
}

0 commit comments

Comments
 (0)