Skip to content

Commit bda3722

Browse files
authored
DX-2930 Fix RemoveImportTnOrder Model (#56)
* DX-2930 Fix `RemoveImportTnOrder` Model * DX-2930 Hosted Messaging Updates Broke ImportTn and RemoveImportedTn models to use a String List as opposed to a TelephoneNumber list for telephoneNumberList This breaks the interface but allows the models to serialize correctly.
1 parent 5430540 commit bda3722

File tree

5 files changed

+48
-34
lines changed

5 files changed

+48
-34
lines changed

README.md

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export BANDWIDTH_IRIS_URL=https://dashboard.bandwidth.com
4747
```
4848

4949

50-
## API Objects
50+
## API Objects
5151
### General principles
5252
When fetching objects from the API, it will always return an object that has the client
5353
instantiated so that you can call dependent methods as well as update, delete.
@@ -120,7 +120,7 @@ for(CoveredRateCenter rc : rateCenters){
120120
```
121121

122122

123-
## Disconnect Numbers
123+
## Disconnect Numbers
124124
The Disconnect object is used to disconnect numbers from an account. Creates a disconnect order that can be tracked
125125

126126
### Create Disconnect
@@ -327,7 +327,7 @@ peer.moveTns(sipPeerTelephoneNumbers);
327327
## Sites
328328

329329
### Create A Site
330-
A site is what is called Location in the web UI.
330+
A site is what is called Location in the web UI.
331331
```Java
332332
Site s = new Site();
333333
s.setName("My New Site");
@@ -438,10 +438,8 @@ sub.setFirstName("Band");
438438
sub.setLastName("Width");
439439
sub.setServiceAddress(address);
440440

441-
TelephoneNumber tn1 = new TelephoneNumber();
442-
tn1.setTelephoneNumber("9195551234");
443-
List<TelephoneNumber> telephoneNumberList = new ArrayList<TelephoneNumber>();
444-
telephoneNumberList.add(tn1);
441+
List<String> telephoneNumberList = new ArrayList<String>();
442+
telephoneNumberList.add("9195551234");
445443

446444
order.setSiteId(14480);
447445
order.setSipPeer(522211);
@@ -452,7 +450,7 @@ order.setLoaAuthorizingPerson("Bandwidth");
452450
ImportTnOrderResponse response = ImportTnOrder.Create(client, order );
453451
```
454452

455-
### List ImportTnOrders
453+
### List ImportTnOrders
456454

457455
```Java
458456
Map<String, Object> query = new HashMap<>();
@@ -473,18 +471,21 @@ ImportTnOrder response = ImportTnOrder.Get(client, orderId );
473471
OrderHistoryWrapper response = ImportTnOrder.GetHistory(client, orderId );
474472
```
475473

476-
## RemoveImportedTnOrders
474+
## RemoveImportedTnOrders
477475

478476
### Create RemoveImportedTnOrder
479477

480478
```Java
479+
List<String> tnList = new ArrayList<String>();
480+
telephoneNumberList.add("9195551234");
481+
481482
RemoveImportedTnOrder order = new RemoveImportedTnOrder();
482483
order.setTelephoneNumberList( tnList );
483484

484485
RemoveImportedTnOrderResponse response = RemoveImportedTnOrder.Create(client, order);
485486
```
486487

487-
### List RemoveImportedTnOrders
488+
### List RemoveImportedTnOrders
488489

489490
```Java
490491
Map<String, Object> query = new HashMap<>();
@@ -505,7 +506,7 @@ RemoveImportedTnOrder response = RemoveImportedTnOrder.Get(client, orderId);
505506
OrderHistoryWrapper response = RemoveImportedTnOrder.GetHistory(client, orderId);
506507
```
507508

508-
## ImportTnChecker
509+
## ImportTnChecker
509510

510511
### Check Importability of Tns
511512

@@ -516,9 +517,9 @@ payload.setTelephoneNumberList( tnList );
516517
ImportTnCheckerResponse response = ImportTnChecker.Check(client, payload);
517518
```
518519

519-
## Csr Order
520+
## Csr Order
520521

521-
### Create Csr
522+
### Create Csr
522523

523524
```Java
524525
Csr csr = new Csr();
@@ -542,7 +543,7 @@ csr.setCity("Raleigh");
542543
CsrResponse response = Csr.Replace(client, orderId, csr);
543544
```
544545

545-
### Get Csr Notes
546+
### Get Csr Notes
546547

547548
```Java
548549
Notes response = Csr.GetNotes(client, orderId);
@@ -566,17 +567,17 @@ note.setDescription("This is a csr note");
566567
IrisResponse response = Csr.UpdateNote(client, orderId, noteId, note );
567568
```
568569

569-
## Emergency Notification
570+
## Emergency Notification
570571

571-
### Create Recipients
572+
### Create Recipients
572573
```java
573574
EmergencyNotificationRecipient recipient = new EmergencyNotificationRecipient();
574575
recipient.setEmailAddress("[email protected]");
575576

576577
EmergencyNotificationRecipientsResponse response = EmergencyNotification.createRecipients(client, recipient);
577578
```
578579

579-
### List Recipients
580+
### List Recipients
580581
```java
581582
Map<String, String> query = new HashMap<String, Object>();
582583
query.add("ModifiedByUser", "jgilmore");
@@ -589,7 +590,7 @@ EmergencyNotificationRecipientsResponse response = EmergencyNotification.listRec
589590
EmergencyNotificationRecipientsResponse response = EmergencyNotification.getRecipients(client, recipientsId);
590591
```
591592

592-
### Replace Recipients
593+
### Replace Recipients
593594
```java
594595
EmergencyNotificationRecipient recipient = new EmergencyNotificationRecipient();
595596
recipient.setEmailAddress("[email protected]");
@@ -640,7 +641,7 @@ EmergencyNotificationGroupsResponse response = EmergencyNotification.getGroups(c
640641
EmergencyNotificationEndpointOrderResponse response = EmergencyNotification.createEndpointOrder(client, new EmergencyNotificationEndpointOrder());
641642
```
642643

643-
### List Endpoint Orders
644+
### List Endpoint Orders
644645
```java
645646
EmergencyNotificationEndpointOrderResponse response = EmergencyNotification.listEndpointOrders(client, query);
646647
```
@@ -650,7 +651,7 @@ EmergencyNotificationEndpointOrderResponse response = EmergencyNotification.list
650651
EmergencyNotificationEndpointOrderResponse response = EmergencyNotification.getEndpointOrder(client, orderId);
651652
```
652653

653-
## Aeuis
654+
## Aeuis
654655

655656
### Get Aeui
656657

@@ -659,7 +660,7 @@ AlternateEndUserIdentifierResponse response = Aeui.get(client, id);
659660
```
660661

661662
### List Aeuis
662-
```java
663+
```java
663664
AlternateEndUserIdentifiersResponse response = Aeui.list(client, query);
664665
```
665666

src/main/java/com/bandwidth/iris/sdk/model/ImportTnOrder.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ public class ImportTnOrder extends BaseModel {
4343
@XmlElement(name = "LoaAuthorizingPerson")
4444
private String loaAuthorizingPerson;
4545

46-
@XmlElement(name = "TelephoneNumbers")
47-
private List<TelephoneNumber> telephoneNumberList;
46+
@XmlElementWrapper(name = "TelephoneNumbers")
47+
@XmlElement(name = "TelephoneNumber")
48+
private List<String> telephoneNumberList;
4849

4950
@XmlElement(name="ProcessingStatus")
5051
private String processingStatus;
@@ -173,11 +174,11 @@ public void setLoaAuthorizingPerson(String loaAuthorizingPerson) {
173174
this.loaAuthorizingPerson = loaAuthorizingPerson;
174175
}
175176

176-
public List<TelephoneNumber> getTelephoneNumberList() {
177+
public List<String> getTelephoneNumberList() {
177178
return telephoneNumberList;
178179
}
179180

180-
public void setTelephoneNumberList(List<TelephoneNumber> telephoneNumberList) {
181+
public void setTelephoneNumberList(List<String> telephoneNumberList) {
181182
this.telephoneNumberList = telephoneNumberList;
182183
}
183184

src/main/java/com/bandwidth/iris/sdk/model/RemoveImportedTnOrder.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,29 @@ public class RemoveImportedTnOrder extends BaseModel{
1313

1414
@XmlElement(name = "CustomerOrderId")
1515
private String customerOrderId;
16+
1617
@XmlElement(name = "OrderCreateDate")
1718
private String orderCreateDate;
19+
1820
@XmlElement(name= "AccountId")
1921
private String accountId;
22+
2023
@XmlElement(name = "CreatedByUser")
2124
private String createdByUser;
25+
2226
@XmlElement(name = "OrderId")
2327
private String orderId;
28+
2429
@XmlElement(name = "LastModifiedDate")
2530
private String lastModifiedDate;
31+
2632
@XmlElementWrapper(name = "TelephoneNumbers")
2733
@XmlElement(name = "TelephoneNumber")
28-
private List<TelephoneNumber> telephoneNumberList;
34+
private List<String> telephoneNumberList;
35+
2936
@XmlElement(name = "ProcessingStatus")
3037
private String processingStatus;
38+
3139
@XmlElementWrapper(name = "Errors")
3240
@XmlElement(name = "Error")
3341
private List<Error> errors;
@@ -97,11 +105,11 @@ public void setLastModifiedDate(String lastModifiedDate) {
97105
this.lastModifiedDate = lastModifiedDate;
98106
}
99107

100-
public List<TelephoneNumber> getTelephoneNumberList() {
108+
public List<String> getTelephoneNumberList() {
101109
return telephoneNumberList;
102110
}
103111

104-
public void setTelephoneNumberList(List<TelephoneNumber> telephoneNumberList) {
112+
public void setTelephoneNumberList(List<String> telephoneNumberList) {
105113
this.telephoneNumberList = telephoneNumberList;
106114
}
107115

src/main/java/com/bandwidth/iris/sdk/model/TelephoneNumber.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import javax.xml.bind.annotation.XmlAccessorType;
55
import javax.xml.bind.annotation.XmlElement;
66
import javax.xml.bind.annotation.XmlRootElement;
7+
78
import java.util.Date;
89

910
@XmlRootElement(name = "TelephoneNumber")
@@ -24,14 +25,19 @@ public class TelephoneNumber {
2425

2526
@XmlElement(name = "State")
2627
protected String state;
28+
2729
@XmlElement(name = "RateCenter")
2830
protected String rateCenter;
31+
2932
@XmlElement(name = "Tier")
3033
private String tier;
34+
3135
@XmlElement(name = "VendorId")
3236
private String vendorId;
37+
3338
@XmlElement(name = "VendorName")
3439
private String vendorName;
40+
3541
@XmlElement(name = "Status")
3642
private String status;
3743

@@ -50,8 +56,8 @@ public String getFullNumber() {
5056

5157
public void setFullNumber(String fullNumber) {
5258
this.fullNumber = fullNumber;
53-
}
54-
59+
}
60+
5561
public String getTelephoneNumber() {
5662
return telephoneNumber;
5763
}

src/test/java/com/bandwidth/iris/sdk/ImportTnOrderTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,8 @@ public void TestCreate() throws Exception {
3939
sub.setLastName("Width");
4040
sub.setServiceAddress(address);
4141

42-
TelephoneNumber tn1 = new TelephoneNumber();
43-
tn1.setTelephoneNumber("9195551234");
44-
List<TelephoneNumber> telephoneNumberList = new ArrayList<TelephoneNumber>();
45-
telephoneNumberList.add(tn1);
42+
List<String> telephoneNumberList = new ArrayList<String>();
43+
telephoneNumberList.add("9195551234");
4644

4745
order.setSiteId(14480);
4846
order.setSipPeer(522211);

0 commit comments

Comments
 (0)