Commit 11bae04
authored
feat move This Device memory filter into the filter sheet (#9978)
## What
Moves the **This Device** memory filter chip out of the memories search
row and into the filter bottom sheet (opened by the last icon on the
search row). It now sits below the category options (All / System /
Interesting / Manual), separated by a divider, and toggles without
closing the sheet — matching the category options' behavior.
- [page.dart](app/lib/pages/memories/page.dart): removed the standalone
`FilterChip` from the search row (and its shimmer placeholder).
-
[memory_management_sheet.dart](app/lib/pages/memories/widgets/memory_management_sheet.dart):
added the This Device row to the sheet; extracted a shared
`_buildFilterOption` row builder reused by the category options.
<img width="603" alt="This Device filter inside the filter sheet"
src="https://github.com/user-attachments/assets/eabc6fad-5296-4840-870a-27d85d310fb2"
/>
## Product invariants affected
- INV-MEM-1 — UI-only relocation of the This Device filter control;
filtering semantics and memory-tier behavior are unchanged.
## Verification
- `dart format --line-length 120` on both files (no changes).
- `flutter analyze` on both files — only pre-existing info-level lints,
no warnings or errors.
- `scripts/pr-preflight` local lane passes with this body.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/BasedHardware/omi/pull/9978?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->2 files changed
Lines changed: 30 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
215 | | - | |
216 | 214 | | |
217 | 215 | | |
218 | 216 | | |
| |||
293 | 291 | | |
294 | 292 | | |
295 | 293 | | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | 294 | | |
305 | 295 | | |
306 | 296 | | |
| |||
Lines changed: 30 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
72 | 82 | | |
73 | 83 | | |
74 | 84 | | |
75 | 85 | | |
76 | 86 | | |
77 | | - | |
| 87 | + | |
78 | 88 | | |
79 | 89 | | |
80 | 90 | | |
| |||
84 | 94 | | |
85 | 95 | | |
86 | 96 | | |
87 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
88 | 101 | | |
89 | 102 | | |
90 | 103 | | |
| |||
93 | 106 | | |
94 | 107 | | |
95 | 108 | | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
96 | 120 | | |
97 | 121 | | |
98 | 122 | | |
| |||
0 commit comments