Skip to content

Commit 5146dae

Browse files
committed
fix(backend): migrate TemplateResponse to starlette 1.x API
Starlette 1.x changed TemplateResponse signature from: TemplateResponse(name, {'request': request, ...}) to: TemplateResponse(request, name, {...}) Pass 'request' as first positional arg and remove it from context dict. 3 call sites fixed: - backend/routers/auth.py (2 sites) - backend/routers/integrations.py (1 site) Failure-Class: none
1 parent 9dc4422 commit 5146dae

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

backend/routers/auth.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,9 +411,9 @@ async def auth_callback_google(
411411
# The original ``redirect_uri`` was validated by ``_validate_redirect_uri`` at
412412
# ``/authorize`` time and cannot be overridden by the caller here.
413413
return templates.TemplateResponse(
414+
request,
414415
"auth_callback.html",
415416
{
416-
"request": request,
417417
"code": auth_code,
418418
"state": session_data['state'] or '',
419419
"redirect_uri": app_redirect_uri,
@@ -512,9 +512,9 @@ async def auth_callback_apple_post(
512512
# The original ``redirect_uri`` was validated by ``_validate_redirect_uri`` at
513513
# ``/authorize`` time and cannot be overridden by the caller here.
514514
return templates.TemplateResponse(
515+
request,
515516
"auth_callback.html",
516517
{
517-
"request": request,
518518
"code": auth_code,
519519
"state": session_data['state'] or '',
520520
"redirect_uri": app_redirect_uri,

backend/routers/integrations.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ def render_oauth_response(
9393

9494
if success:
9595
context: Dict[str, Any] = {
96-
'request': request,
9796
'title': f"{config['name']} Auth",
9897
'icon': '✓',
9998
'message': 'Authentication Successful!',
@@ -110,7 +109,6 @@ def render_oauth_response(
110109
}
111110

112111
context = {
113-
'request': request,
114112
'title': f"{config['name']} Auth Error",
115113
'icon': '❌',
116114
'message': f"{'Security' if error_type == 'invalid_state' else 'Configuration' if error_type == 'config_error' else 'Authentication'} Error",
@@ -119,7 +117,7 @@ def render_oauth_response(
119117
'show_spinner': False,
120118
}
121119

122-
return templates.TemplateResponse('oauth_callback.html', context)
120+
return templates.TemplateResponse(request, 'oauth_callback.html', context)
123121

124122

125123
def validate_and_consume_oauth_state(state_token: Optional[str]) -> Optional[Dict[str, str]]:

0 commit comments

Comments
 (0)