Commit cdeff84
authored
fix(release): align trusted qualification CLI contract (#10269)
## Summary
- remove the stale unsupported `--no-promote` argument from the trusted
desktop Beta qualification workflow
- add a focused release-flow contract that locks the exact qualification
invocation and verifies every workflow option is accepted by
`qualify-desktop-beta.sh`
- keep evidence publication in the qualification workflow and downstream
Beta promotion in the existing reusable workflow
Failure-Class: FC-workflow-script-input-contract
## Failure mechanism
The trusted qualification workflow invoked `qualify-desktop-beta.sh`
with `--no-promote`, but that script's declared CLI rejects the option
before qualification begins. The script already has no promotion
authority when `--github-actions-artifact` is used; it qualifies the
candidate and leaves evidence publication and the reusable promotion
handoff to the workflow.
## Verification
- `python3 .github/scripts/test_desktop_release_flow_contract.py -v` — 6
passed
- `actionlint -shellcheck '' .github/workflows/desktop_qualify_beta.yml`
— passed
- `make preflight` — 12 selected checks passed
## Safety
- Beta-only architecture is unchanged
- no candidate assets, tags, release metadata, admission state, or
appcast pointers are modified
- Stable nomination and promotion remain untouched
- this PR does not build, release, deploy, qualify, promote, or enable
admission
<!-- This is an auto-generated description by cubic. -->
<a
href="https://cubic.dev/pr/BasedHardware/omi/pull/10269?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->2 files changed
Lines changed: 26 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
47 | 73 | | |
48 | 74 | | |
49 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
| |||
0 commit comments