Fix staticcheck findings

Author: BennettSchwartz

api/grpc/handlers.go

@@ -84,32 +84,6 @@ func validateSensitivity(name, value string, required bool) error {
 	return nil
 }
 
-func validateOutcomeStatus(name, value string, required bool) error {
-	if value == "" {
-		if required {
-			return status.Errorf(codes.InvalidArgument, "%s is required", name)
-		}
-		return nil
-	}
-	if !schema.IsValidOutcomeStatus(schema.OutcomeStatus(value)) {
-		return status.Errorf(codes.InvalidArgument, "%s must be one of: success, failure, partial", name)
-	}
-	return nil
-}
-
-func validateTaskState(name, value string, required bool) error {
-	if value == "" {
-		if required {
-			return status.Errorf(codes.InvalidArgument, "%s is required", name)
-		}
-		return nil
-	}
-	if !schema.IsValidTaskState(schema.TaskState(value)) {
-		return status.Errorf(codes.InvalidArgument, "%s must be one of: planning, executing, blocked, waiting, done", name)
-	}
-	return nil
-}
-
 func validateMemoryType(name, value string) error {
 	if !schema.IsValidMemoryType(schema.MemoryType(value)) {
 		return status.Errorf(codes.InvalidArgument, "%s must be one of: episodic, working, semantic, competence, plan_graph, entity", name)

pkg/ingestion/capture.go

@@ -178,7 +178,6 @@ func (s *Service) CaptureMemory(ctx context.Context, req CaptureMemoryRequest) (
 		return nil, err
 	} else if semanticRecord != nil {
 		createdRecords = append(createdRecords, semanticRecord)
-		candidates = append(candidates, semanticRecord)
 		edges = append(edges, semanticEdges...)
 		for _, edge := range semanticEdges {
 			if edge.SourceID != sourceRecord.ID {
@@ -302,12 +301,8 @@ func buildFallbackInterpretation(req CaptureMemoryRequest) *schema.Interpretatio
 		TopicalLabels:        uniqueStrings(req.Tags),
 		ExtractionConfidence: 0.25,
 	}
-	for _, mention := range inferMentionsFromContent(req.Content) {
-		interpretation.Mentions = append(interpretation.Mentions, mention)
-	}
-	for _, ref := range inferReferenceCandidates(req.Content, req.Context) {
-		interpretation.ReferenceCandidates = append(interpretation.ReferenceCandidates, ref)
-	}
+	interpretation.Mentions = append(interpretation.Mentions, inferMentionsFromContent(req.Content)...)
+	interpretation.ReferenceCandidates = append(interpretation.ReferenceCandidates, inferReferenceCandidates(req.Content, req.Context)...)
 	if interpretation.ProposedType == "" {
 		interpretation.ProposedType = inferProposedType(req.SourceKind)
 	}