Skip to content

Commit 1c75306

Browse files
author
didi
committed
Merge remote-tracking branch 'upstream/master'
2 parents 21aa914 + 7c36167 commit 1c75306

File tree

5 files changed

+758
-39
lines changed

5 files changed

+758
-39
lines changed

README.md

+20-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ View the help message output:
3838
--report output report to stdout (default)
3939
--ids-only output all way and relation IDs from given diff
4040
--ql-only output Overpass QL
41-
--rss-file RSS_FILE output report as rss file
41+
--rss-file RSS_FILE output / append report as rss file
4242

4343
`regional-diff.py` by default reports ways and relations with bicylce-tags[1] in
4444
Vorarlberg which were modified in the last minute.
@@ -80,11 +80,28 @@ created on `#Wed Jun 25 20:02:07 UTC 2014`. This should be the sample output:
8080
http://www.openstreetmap.org/relation/116941/history
8181
http://www.openstreetmap.org/changeset/23158682
8282

83+
RSS-Feed
84+
--------
85+
8386
To generate an RSS-file run:
8487

8588
$ scripts/regional-diff.py -f scripts/637.osc.gz --rss-file regional-diff.rss
8689

87-
Put the RSS-file to your `htdocs` folder and point your favourite RSS-Client to that URL to subscribe that feed.
90+
Put the RSS-file to your `htdocs` folder and point your favourite RSS-Client to
91+
that URL to subscribe that feed.
92+
93+
The RSS-File with an RSS-Item is only created if modification exist (in
94+
Vorarlberg). An RSS-Item (of a modification) is created and appended on every
95+
run of `regional-diff.py` (even if the modification is part of a previous item).
96+
97+
Note
98+
----
99+
100+
Please note that processing a daily-diff file is a very CPU and memory hungry
101+
task. Working with less than 16GB of RAM could cause the script to crash.
102+
103+
Used libraries
104+
--------------
88105

89-
Please be aware that the RSS-File will be overwriten on every run of `regional-diff.py`
106+
* *PyRSS2Gen* (version 1.1) taken from http://www.dalkescientific.com/Python/PyRSS2Gen.html
90107

doc/notes.txt

+29-1
Original file line numberDiff line numberDiff line change
@@ -179,4 +179,32 @@ Show only ways (from a given list of ways) which are part of a bicycle route
179179
way for our task is to select only the parent ways for all nodes from the input
180180
set with *way(bn*);
181181

182-
182+
Thu 10 Jul 16:04:02 CEST 2014 (and before) -MM
183+
==============================================
184+
Problems fixed:
185+
• Ways without node-changes have no spatial information in diff file, so get removed by crop
186+
· pick a node for each way missing spatial information
187+
· download them via overpass in bulk
188+
· there was need to limit the download to only 1000 nodes at once, and merge the results later
189+
· merge them into osm-file before crop
190+
191+
• filter out non-highway ways with osmosis instead of overpass → reduces load on overpass server
192+
· allow only highway types with --tag-filter that are allowed for bicyclists
193+
194+
• added handling of deleted ways: osmosis removes deleted items when converting osc→osm
195+
· regex <deleted> → <modified> in osc after simplify change → fixed it.
196+
197+
Testcases:
198+
• ./regional-diff.py -f minutely-796.osc.gz
199+
this includes changeset http://www.openstreetmap.org/api/0.6/changeset/24005065 from user species
200+
there should be 89 ways and 2 relations (all from this changeset)
201+
• ./regional-diff.py -f scripts/637.osc.gz
202+
there should be 5 ways and 2 relations
203+
204+
Notes for the future :
205+
206+
• overpass API does NOT return deleted nodes.
207+
· for ways without spatial information, some nodes (if deleted meanwhile on the server) will not come back on overpass quere → way gets removed (wrongly) on crop
208+
But: this should happen only (rareley) on fresh changesets.
209+
210+
• if a relation modified is only sorted or tag-changed without having modified members in the changesets, this is not reported.

0 commit comments

Comments
 (0)