feat(sdk-coin-near): added fungible token transfer builder

Ticket: COIN-4148

Author: ravibitgo

modules/bitgo/src/v2/coinFactory.ts

@@ -5,7 +5,7 @@ import { AdaToken } from '@bitgo/sdk-coin-ada';
 import { AlgoToken } from '@bitgo/sdk-coin-algo';
 import { Bcha, Tbcha } from '@bitgo/sdk-coin-bcha';
 import { HbarToken } from '@bitgo/sdk-coin-hbar';
-import { Near, TNear } from '@bitgo/sdk-coin-near';
+import { Near, TNear, Nep141Token } from '@bitgo/sdk-coin-near';
 import { SolToken } from '@bitgo/sdk-coin-sol';
 import { TrxToken } from '@bitgo/sdk-coin-trx';
 import { CoinFactory } from '@bitgo/sdk-core';
@@ -451,6 +451,10 @@ export function registerCoinConstructors(coinFactory: CoinFactory, coinMap: Coin
   Sip10Token.createTokenConstructors([...tokens.bitcoin.stx.tokens, ...tokens.testnet.stx.tokens]).forEach(
     ({ name, coinConstructor }) => coinFactory.register(name, coinConstructor)
   );
+
+  Nep141Token.createTokenConstructors([...tokens.bitcoin.near.tokens, ...tokens.testnet.near.tokens]).forEach(
+    ({ name, coinConstructor }) => coinFactory.register(name, coinConstructor)
+  );
 }
 
 export const GlobalCoinFactory: CoinFactory = new CoinFactory();

modules/bitgo/test/browser/browser.spec.ts

@@ -43,6 +43,7 @@ describe('Coins', () => {
       Polyx: 1,
       Tpolyx: 1,
       CoredaoToken: 1,
+      Nep141Token: 1,
     };
     Object.keys(BitGoJS.Coin)
       .filter((coinName) => !excludedKeys[coinName])

modules/sdk-coin-near/package.json

@@ -42,13 +42,14 @@
   "dependencies": {
     "@bitgo/sdk-core": "^35.0.0",
     "@bitgo/statics": "^54.0.0",
+    "@near-js/crypto": "^2.0.1",
+    "@near-js/transactions": "^2.0.1",
     "@stablelib/hex": "^1.0.0",
     "bignumber.js": "^9.0.0",
-    "bn.js": "^5.2.1",
     "bs58": "^4.0.1",
     "js-sha256": "^0.9.0",
     "lodash": "^4.17.14",
-    "near-api-js": "^0.44.2",
+    "near-api-js": "^5.1.1",
     "superagent": "^9.0.1",
     "tweetnacl": "^1.0.3"
   },

modules/sdk-coin-near/src/lib/constants.ts

@@ -9,4 +9,8 @@ export const StakingContractMethodNames = {
   Withdraw: 'withdraw',
 } as const;
 
+export const AdditionalAllowedMethods = ['ft_transfer', 'storage_deposit'];
+
+export const FT_TRANSFER = 'ft_transfer';
+
 export const HEX_REGEX = /^[0-9a-fA-F]+$/;

modules/sdk-coin-near/src/lib/contractCallWrapper.ts

@@ -7,7 +7,7 @@ import { FunctionCall } from './iface';
  */
 export class ContractCallWrapper {
   private _methodName: string;
-  private _args: Record<string, unknown>;
+  private _args: Record<string, unknown> = {};
   private _gas: string;
   private _deposit: string;
 
@@ -21,35 +21,35 @@ export class ContractCallWrapper {
     return this._methodName;
   }
 
-  /** Set gas, expresed on yocto */
+  /** Set gas, expressed on yocto */
   public set gas(gas: string) {
     if (!this.isValidAmount(new BigNumber(gas))) {
       throw new InvalidParameterValueError('Invalid gas value');
     }
     this._gas = gas;
   }
 
-  /** Get gas, expresed on yocto*/
+  /** Get gas, expressed on yocto*/
   public get gas(): string {
     return this._gas;
   }
 
-  /** Set deposit, expresed on yocto */
+  /** Set deposit, expressed on yocto */
   public set deposit(deposit: string) {
     if (!this.isValidAmount(new BigNumber(deposit))) {
       throw new InvalidParameterValueError('Invalid deposit value');
     }
     this._deposit = deposit;
   }
 
-  /** Get deposit, expresed on yocto */
+  /** Get deposit, expressed on yocto */
   public get deposit(): string {
     return this._deposit;
   }
 
   /** Get args, which are the parameters of a method */
   public set args(args: Record<string, unknown>) {
-    this._args = args;
+    this._args = { ...this._args, ...args };
   }
 
   /** Set args, which are the parameters of a method */

modules/sdk-coin-near/src/lib/fungibleTokenTransferBuilder.ts

@@ -0,0 +1,118 @@
+import assert from 'assert';
+import BigNumber from 'bignumber.js';
+import * as NearAPI from 'near-api-js';
+
+import { BaseCoin as CoinConfig } from '@bitgo/statics';
+import { BuildTransactionError, TransactionType } from '@bitgo/sdk-core';
+
+import { FT_TRANSFER } from './constants';
+import { ContractCallWrapper } from './contractCallWrapper';
+import { Transaction } from './transaction';
+import { TransactionBuilder } from './transactionBuilder';
+import utils from './utils';
+
+export class FungibleTokenTransferBuilder extends TransactionBuilder {
+  private contractCallWrapper: ContractCallWrapper;
+
+  constructor(_coinConfig: Readonly<CoinConfig>) {
+    super(_coinConfig);
+    this.contractCallWrapper = new ContractCallWrapper();
+    this.contractCallWrapper.methodName = FT_TRANSFER;
+  }
+
+  /**
+   * Initialize the transaction builder fields using the decoded transaction data
+   *
+   * @param {Transaction} tx the transaction data
+   */
+  initBuilder(tx: Transaction): void {
+    super.initBuilder(tx);
+    const functionCall = tx.nearTransaction.actions[0].functionCall;
+    if (functionCall) {
+      this.contractCallWrapper.deposit = functionCall.deposit.toString();
+      this.contractCallWrapper.gas = functionCall.gas.toString();
+    }
+  }
+
+  /**
+   * Sets the gas of this transaction.
+   *
+   * @param {String} gas the gas of this transaction
+   * @returns {TransactionBuilder} This transaction builder
+   */
+  public gas(gas: string): this {
+    this.validateValue(new BigNumber(gas));
+    this.contractCallWrapper.gas = gas;
+    return this;
+  }
+
+  /**
+   * Sets the deposit of at-least 1 yoctoNear
+   *
+   * @param {string} deposit the deposit in the minimum unit (1 Near = 1e24 yoctoNear) of this transaction
+   * @returns {TransactionBuilder} This transaction builder
+   */
+  public deposit(deposit: string): this {
+    this.validateValue(new BigNumber(deposit));
+    this.contractCallWrapper.deposit = deposit;
+    return this;
+  }
+
+  /**
+   * @inheritdoc
+   *
+   * We need to override this because for contract call the receiver id is the contract address
+   * And we need to pass the actual receiver id in the args
+   *
+   * @param accountId the contract address
+   */
+  public receiverId(accountId: string): this {
+    utils.isValidAddress(accountId);
+    this._receiverId = accountId;
+    return this;
+  }
+
+  /**
+   * Sets the actual receiver account id inside args
+   *
+   * @param accountId the receiver account id
+   */
+  public ftReceiverId(accountId: string): this {
+    utils.isValidAddress(accountId);
+    this.contractCallWrapper.args = { receiver_id: accountId };
+    return this;
+  }
+
+  /**
+   * Sets the ft amount to be transferred
+   *
+   * @param amount the amount of fungible token to be transferred
+   */
+  public amount(amount: string): this {
+    this.validateValue(new BigNumber(amount));
+    this.contractCallWrapper.args = { amount };
+    return this;
+  }
+
+  /**
+   * Sets the optional memo for the transfer
+   *
+   * @param memo
+   */
+  public memo(memo: string): this {
+    this.contractCallWrapper.args = { memo };
+    return this;
+  }
+
+  /** @inheritdoc */
+  protected async buildImplementation(): Promise<Transaction> {
+    const { methodName, args, gas, deposit } = this.contractCallWrapper.getParams();
+    assert(gas, new BuildTransactionError('gas is required before building fungible token transfer'));
+    assert(deposit, new BuildTransactionError('deposit is required before building fungible token transfer'));
+
+    super.actions([NearAPI.transactions.functionCall(methodName, args, BigInt(gas), BigInt(deposit))]);
+    const tx = await super.buildImplementation();
+    tx.setTransactionType(TransactionType.Send);
+    return tx;
+  }
+}

modules/sdk-coin-near/src/lib/iface.ts

@@ -1,21 +1,17 @@
-import BN from 'bn.js';
+import { KeyType } from '@near-js/crypto';
 import { TransactionType, TransactionExplanation as BaseTransactionExplanation } from '@bitgo/sdk-core';
 
 export interface TransactionExplanation extends BaseTransactionExplanation {
   type: TransactionType;
 }
 
-export enum KeyType {
-  ED25519 = 0,
-}
-
 export interface Signature {
   keyType: KeyType;
   data: Uint8Array;
 }
 
 export interface Transfer {
-  deposit: BN;
+  deposit: bigint;
 }
 
 /** Interface with parameters needed to perform  FunctionCall to a contract */
@@ -38,8 +34,8 @@ export interface Action {
 export interface TxData {
   id?: string;
   signerId: string;
-  publicKey: string;
-  nonce: number;
+  publicKey?: string;
+  nonce: bigint;
   receiverId: string;
   actions: Action[];
   signature?: Signature;

modules/sdk-coin-near/src/lib/stakingActivateBuilder.ts

@@ -4,7 +4,6 @@ import { Transaction } from './transaction';
 import BigNumber from 'bignumber.js';
 import * as NearAPI from 'near-api-js';
 import assert from 'assert';
-import BN from 'bn.js';
 
 import { ContractCallWrapper } from './contractCallWrapper';
 import { TransactionBuilder } from './transactionBuilder';
@@ -32,14 +31,16 @@ export class StakingActivateBuilder extends TransactionBuilder {
   initBuilder(tx: Transaction): void {
     super.initBuilder(tx);
     const functionCall = tx.nearTransaction.actions[0].functionCall;
-    this.contractCallWrapper.deposit = functionCall.deposit.toString();
-    this.contractCallWrapper.gas = functionCall.gas.toString();
+    if (functionCall) {
+      this.contractCallWrapper.deposit = functionCall.deposit.toString();
+      this.contractCallWrapper.gas = functionCall.gas.toString();
+    }
   }
 
   /**
    * Sets the gas of this transaction.
    *
-   * @param {string} value the gas of this transaction
+   * @param {string} gas the gas of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public gas(gas: string): this {
@@ -51,7 +52,7 @@ export class StakingActivateBuilder extends TransactionBuilder {
   /**
    * Sets the amount of this transaction.
    *
-   * @param {string} value the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
+   * @param {string} amount the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public amount(amount: string): this {
@@ -67,7 +68,7 @@ export class StakingActivateBuilder extends TransactionBuilder {
     assert(gas, new BuildTransactionError('gas is required before building staking activate'));
     assert(deposit, new BuildTransactionError('amount is required before building staking activate'));
 
-    super.actions([NearAPI.transactions.functionCall(methodName, args, new BN(gas), new BN(deposit, 10))]);
+    super.actions([NearAPI.transactions.functionCall(methodName, args, BigInt(gas), BigInt(deposit))]);
     const tx = await super.buildImplementation();
     tx.setTransactionType(TransactionType.StakingActivate);
     return tx;

modules/sdk-coin-near/src/lib/stakingDeactivateBuilder.ts

@@ -4,7 +4,6 @@ import { Transaction } from './transaction';
 import BigNumber from 'bignumber.js';
 import * as NearAPI from 'near-api-js';
 import assert from 'assert';
-import BN from 'bn.js';
 
 import { ContractCallWrapper } from './contractCallWrapper';
 import { TransactionBuilder } from './transactionBuilder';
@@ -32,14 +31,16 @@ export class StakingDeactivateBuilder extends TransactionBuilder {
   initBuilder(tx: Transaction): void {
     super.initBuilder(tx);
     const functionCall = tx.nearTransaction.actions[0].functionCall;
-    this.contractCallWrapper.args = JSON.parse(Buffer.from(functionCall.args).toString());
-    this.contractCallWrapper.gas = functionCall.gas.toString();
+    if (functionCall) {
+      this.contractCallWrapper.args = JSON.parse(Buffer.from(functionCall.args).toString());
+      this.contractCallWrapper.gas = functionCall.gas.toString();
+    }
   }
 
   /**
    * Sets the gas of this transaction.
    *
-   * @param {string} value the gas of this transaction
+   * @param {string} gas the gas of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public gas(gas: string): this {
@@ -51,7 +52,7 @@ export class StakingDeactivateBuilder extends TransactionBuilder {
   /**
    * Sets the amount of this transaction.
    *
-   * @param {string} value the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
+   * @param {string} amount the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public amount(amount: string): this {
@@ -66,7 +67,7 @@ export class StakingDeactivateBuilder extends TransactionBuilder {
     assert(gas, new BuildTransactionError('gas is required before building staking deactivate'));
     assert(args?.amount, new BuildTransactionError('amount is required before building staking deactivate'));
 
-    super.actions([NearAPI.transactions.functionCall(methodName, args, new BN(gas), new BN(deposit))]);
+    super.actions([NearAPI.transactions.functionCall(methodName, args, BigInt(gas), BigInt(deposit))]);
     const tx = await super.buildImplementation();
     tx.setTransactionType(TransactionType.StakingDeactivate);
     return tx;

modules/sdk-coin-near/src/lib/stakingWithdrawBuilder.ts

@@ -4,7 +4,6 @@ import { Transaction } from './transaction';
 import BigNumber from 'bignumber.js';
 import * as NearAPI from 'near-api-js';
 import assert from 'assert';
-import BN from 'bn.js';
 
 import { ContractCallWrapper } from './contractCallWrapper';
 import { TransactionBuilder } from './transactionBuilder';
@@ -32,14 +31,16 @@ export class StakingWithdrawBuilder extends TransactionBuilder {
   initBuilder(tx: Transaction): void {
     super.initBuilder(tx);
     const functionCall = tx.nearTransaction.actions[0].functionCall;
-    this.contractCallWrapper.args = JSON.parse(Buffer.from(functionCall.args).toString());
-    this.contractCallWrapper.gas = functionCall.gas.toString();
+    if (functionCall) {
+      this.contractCallWrapper.args = JSON.parse(Buffer.from(functionCall.args).toString());
+      this.contractCallWrapper.gas = functionCall.gas.toString();
+    }
   }
 
   /**
    * Sets the gas of this transaction.
    *
-   * @param {string} value the gas of this transaction
+   * @param {string} gas the gas of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public gas(gas: string): this {
@@ -51,7 +52,7 @@ export class StakingWithdrawBuilder extends TransactionBuilder {
   /**
    * Sets the amount of this transaction.
    *
-   * @param {string} value the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
+   * @param {string} amount the amount in the minimum unit (1 Near = 1e24 yoctos) of this transaction
    * @returns {TransactionBuilder} This transaction builder
    */
   public amount(amount: string): this {
@@ -66,7 +67,7 @@ export class StakingWithdrawBuilder extends TransactionBuilder {
     assert(gas, new BuildTransactionError('gas is required before building staking withdraw'));
     assert(args?.amount, new BuildTransactionError('amount is required before building staking withdraw'));
 
-    super.actions([NearAPI.transactions.functionCall(methodName, args, new BN(gas), new BN(deposit))]);
+    super.actions([NearAPI.transactions.functionCall(methodName, args, BigInt(gas), BigInt(deposit))]);
     const tx = await super.buildImplementation();
     tx.setTransactionType(TransactionType.StakingWithdraw);
     return tx;