chore(utxo-core): renamed files and moved helper to own file

TICKET: BTC-2047

Author: christopher-fong

modules/utxo-core/src/paygo/attestation.ts

@@ -0,0 +1,13 @@
+export const NILL_UUID = '00000000-0000-0000-0000-000000000000';
+
+/** This function reconstructs the proof <ENTROPY><ADDRESS><UUID>
+ * given the address and entropy.
+ *
+ * @param address
+ * @param entropy
+ * @returns
+ */
+export function createPayGoAttestationBuffer(address: string, entropy: Buffer): Buffer {
+  const addressBuffer = Buffer.from(address);
+  return Buffer.concat([entropy, addressBuffer, Buffer.from(NILL_UUID)]);
+}

modules/utxo-core/src/paygo/psbt/PayGoUtils.ts renamed to modules/utxo-core/src/paygo/psbt/payGoAddressProof.ts

@@ -2,6 +2,7 @@ import * as utxolib from '@bitgo/utxo-lib';
 import { checkForOutput } from 'bip174/src/lib/utils';
 
 import { verifyMessage } from '../../bip32utils';
+import { createPayGoAttestationBuffer } from '../attestation';
 
 import {
   ErrorMultiplePayGoProof,
@@ -11,8 +12,6 @@ import {
   ErrorPayGoAddressProofFailedVerification,
 } from './Errors';
 
-const NILLUUID = '00000000-0000-0000-0000-000000000000';
-
 /** This function adds the entropy and signature into the PSBT output unknown key vals.
  * We store the entropy so that we reconstruct the message <ENTROPY><ADDRESS><UUID>
  * to later verify.
@@ -109,15 +108,3 @@ export function getPayGoAddressProofOutputIndex(psbt: utxolib.bitgo.UtxoPsbt): n
 export function psbtOutputIncludesPaygoAddressProof(psbt: utxolib.bitgo.UtxoPsbt): boolean {
   return getPayGoAddressProofOutputIndex(psbt) !== undefined;
 }
-
-/** This function reconstructs the proof <ENTROPY><ADDRESS><UUID>
- * given the address and entropy.
- *
- * @param address
- * @param entropy
- * @returns
- */
-export function createPayGoAttestationBuffer(address: string, entropy: Buffer): Buffer {
-  const addressBuffer = Buffer.from(address);
-  return Buffer.concat([entropy, addressBuffer, Buffer.from(NILLUUID)]);
-}

modules/utxo-core/test/paygo/psbt/PayGoUtils.ts renamed to modules/utxo-core/test/paygo/psbt/payGoAddressProof.ts

@@ -8,14 +8,14 @@ import { checkForOutput } from 'bip174/src/lib/utils';
 
 import {
   addPayGoAddressProof,
-  createPayGoAttestationBuffer,
   getPayGoAddressProofOutputIndex,
   psbtOutputIncludesPaygoAddressProof,
   verifyPayGoAddressProof,
-} from '../../../src/paygo/psbt/PayGoUtils';
+} from '../../../src/paygo/psbt/payGoAddressProof';
 import { generatePayGoAttestationProof } from '../../../src/testutil/generatePayGoAttestationProof.utils';
 import { parseVaspProof } from '../../../src/testutil/parseVaspProof';
 import { signMessage } from '../../../src/bip32utils';
+import { createPayGoAttestationBuffer, NILL_UUID } from '../../../src/paygo/attestation';
 
 // To construct our PSBTs
 const network = utxolib.networks.bitcoin;
@@ -37,9 +37,6 @@ const dummyPub1 = rootWalletKeys.deriveForChainAndIndex(50, 200);
 const attestationPubKey = dummyPub1.user.publicKey;
 const attestationPrvKey = dummyPub1.user.privateKey!;
 
-// UUID structure
-const nillUUID = '00000000-0000-0000-0000-000000000000';
-
 // our xpub converted to base58 address
 const addressToVerify = utxolib.address.toBase58Check(
   utxolib.crypto.hash160(Buffer.from(dummyPub1.backup.publicKey)),
@@ -48,7 +45,7 @@ const addressToVerify = utxolib.address.toBase58Check(
 );
 
 // this should be retuning a Buffer
-const addressProofBuffer = generatePayGoAttestationProof(nillUUID, Buffer.from(addressToVerify));
+const addressProofBuffer = generatePayGoAttestationProof(NILL_UUID, Buffer.from(addressToVerify));
 const addressProofMsgBuffer = parseVaspProof(addressProofBuffer);
 // We know that that the entropy is a set 64 bytes.
 const addressProofEntropy = addressProofMsgBuffer.subarray(0, 65);