Skip to content

Commit 77950e6

Browse files
authored
Merge pull request #6432 from BitGo/coin-4755-msg-signing-support-ada-sol
feat: enable message signing for ADA and SOL
2 parents 5dc2488 + 1ee3499 commit 77950e6

File tree

3 files changed

+10
-23
lines changed

3 files changed

+10
-23
lines changed

modules/bitgo/test/v2/unit/wallet.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -3472,29 +3472,6 @@ describe('V2 Wallet:', function () {
34723472
nock.cleanAll();
34733473
});
34743474

3475-
describe('should throw error for unsupported coins', function () {
3476-
it('sol signMessage', async function () {
3477-
await tssSolWallet
3478-
.signMessage({
3479-
reqId,
3480-
message: { messageRaw },
3481-
prv: 'secretKey',
3482-
})
3483-
.should.be.rejectedWith('Message signing not supported for Testnet Solana');
3484-
});
3485-
3486-
it('sol create signMessage tx request', async function () {
3487-
await tssSolWallet
3488-
.buildSignMessageRequest({
3489-
message: {
3490-
messageRaw,
3491-
messageStandardType: MessageStandardType.EIP191,
3492-
},
3493-
})
3494-
.should.be.rejectedWith('Message signing not supported for Testnet Solana');
3495-
});
3496-
});
3497-
34983475
messageSigningCoins.map((coinName) => {
34993476
const expectedWithCoinField = { ...expected, coin: 'teth' };
35003477

modules/sdk-coin-ada/src/ada.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,11 @@ export class Ada extends BaseCoin {
605605
return true;
606606
}
607607

608+
/** @inheritDoc */
609+
supportsMessageSigning(): boolean {
610+
return true;
611+
}
612+
608613
/** inherited doc */
609614
getDefaultMultisigType(): MultisigType {
610615
return multisigTypes.tss;

modules/sdk-coin-sol/src/sol.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,11 @@ export class Sol extends BaseCoin {
194194
return true;
195195
}
196196

197+
/** @inheritDoc */
198+
supportsMessageSigning(): boolean {
199+
return true;
200+
}
201+
197202
/** inherited doc */
198203
getDefaultMultisigType(): MultisigType {
199204
return multisigTypes.tss;

0 commit comments

Comments
 (0)