feat(sdk-coin-dot): enhance DOT tx verification for consolidation to base address #7610
+92
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
requested changes
Nov 24, 2025
modules/sdk-coin-dot/src/dot.ts
Outdated
| } | ||
|
|
||
| const factory = this.getBuilder(); | ||
| const txBuilder = factory.from(txPrebuild.txHex) as any; |
Contributor
There was a problem hiding this comment.
let's try to update this to the appropriate type if possible
nvjsr
previously approved these changes
Nov 25, 2025
nvrakesh06
previously approved these changes
Nov 25, 2025
mohammadalfaiyazbitgo
previously approved these changes
Nov 26, 2025
mohd-kashif
previously approved these changes
Nov 26, 2025
danielpeng1
commented
Nov 26, 2025
Contributor
Author
danielpeng1
left a comment
danielpeng1
left a comment
There was a problem hiding this comment.
conflicts due to revert
| ); | ||
| } | ||
|
|
||
| async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> { |
Contributor
Author
There was a problem hiding this comment.
dot verifyTransaction has been reverted here #7634
Contributor
Author
There was a problem hiding this comment.
I looked at the JSON for a DOT wallet and the base address for DOT is called rootAddress so I use that to retrieve the address here. I also typed the txBuilder, changed the generic errors to be TxIntentMismatchRecipientError where appropriate, and I rebased those changes on top of the revert of revert PR.
danielpeng1
dismissed stale reviews from mohd-kashif, Ranjna-G, mohammadalfaiyazbitgo, and nvrakesh06
via
b72f323
danielpeng1
force-pushed
the
WP-5728/fix/dot-consolidation-blind-sign
branch
from
add4e11 to
b72f323
Compare
danielpeng1
requested review from
mohammadalfaiyazbitgo,
mohd-kashif and
nvrakesh06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifyTransactionmethod to include wallet base address verification for consolidation transactions.Ticket: WP-5728