Merge #381: Add sorting to is_consistent function for deterministic error ordering

4a21dcd refactor: add sorting to `is_consistent` function for deterministic error ordering (LesterEvSe)

Pull request description:

  Error output ordering was nondeterministic because `Arguments` and `Witness` used `HashMap` internally, causing diagnostics to be emitted in arbitrary iteration order across runs.

  This PR add sorting to `is_consistent` for deterministic error ordering.

ACKs for top commit:
  KyrylR:
    ACK 4a21dcd;

Tree-SHA512: f5262a9429a3eae5088d31f43db8206df44792e80dad3d2842e32097a1d52d57eea71fd0f198f9c54c4627608507806fac46ab9a0e16c0e24f00b12a7c584b0a

Author: LesterEvSe

src/witness.rs

@@ -112,7 +112,10 @@ impl WitnessValues {
     /// finalized Simplicity program. However, before the finalization, we cannot know which
     /// witnesses will be pruned and which won't be pruned.
     pub fn is_consistent(&self, witness_types: &WitnessTypes, diagnostics: &mut DiagnosticManager) {
-        for (name, declared_ty) in witness_types.iter() {
+        let mut entries: Vec<_> = witness_types.iter().collect();
+        entries.sort_unstable_by_key(|(k, _)| *k);
+
+        for (name, declared_ty) in entries {
             let Some(value) = self.get(name) else {
                 diagnostics.push(Diagnostic::global(Error::WitnessMissing {
                     name: name.shallow_clone(),
@@ -237,7 +240,10 @@ impl Arguments {
     ///
     /// Arguments without a corresponding parameter are ignored.
     pub fn is_consistent(&self, parameters: &Parameters, diagnostics: &mut DiagnosticManager) {
-        for (name, parameter_ty) in parameters.iter() {
+        let mut entries: Vec<_> = parameters.iter().collect();
+        entries.sort_unstable_by_key(|(k, _)| *k);
+
+        for (name, parameter_ty) in entries {
             let Some(argument) = self.get(name) else {
                 diagnostics.push(Diagnostic::global(Error::ArgumentMissing {
                     name: name.shallow_clone(),