Skip to content

Commit 2f741ad

Browse files
authored
Merge pull request #428 from BloomBooks/BL9514_FirstLastUploaded
Tweak messages for first and last uploaded dates (BL-9514)
2 parents a801ba8 + 87fc8ab commit 2f741ad

File tree

2 files changed

+40
-16
lines changed

2 files changed

+40
-16
lines changed

src/components/BookDetail/MetadataGroup.tsx

+34-14
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@ import { BookDetailInfoWidget } from "./BookDetailInfoWidget";
1818
export const LeftMetadata: React.FunctionComponent<{
1919
book: Book;
2020
}> = observer((props) => {
21+
const originalUploadDateAsString = props.book.uploadDate!.toLocaleDateString();
22+
const lastUploadDateAsString = props.book.lastUploadedDate
23+
? props.book.lastUploadedDate!.toLocaleDateString()
24+
: undefined;
25+
const displayLastUploadDate =
26+
originalUploadDateAsString !== lastUploadDateAsString;
27+
2128
return (
2229
<div
2330
css={css`
@@ -48,26 +55,39 @@ export const LeftMetadata: React.FunctionComponent<{
4855
/>{" "}
4956
<LicenseLink book={props.book} />
5057
</div>
51-
<div>
52-
<FormattedMessage
53-
id="book.metadata.uploadedBy"
54-
defaultMessage="Uploaded {date} by {email}"
55-
values={{
56-
date: props.book.uploadDate!.toLocaleDateString(),
57-
email: obfuscateEmail(props.book.uploader),
58-
}}
59-
/>
60-
</div>
61-
{props.book.lastUploadedDate && (
58+
{!displayLastUploadDate ? (
6259
<div>
6360
<FormattedMessage
64-
id="book.metadata.lastUploaded"
65-
defaultMessage="Last uploaded on {date}"
61+
id="book.metadata.uploadedBy"
62+
defaultMessage="Uploaded {date} by {email}"
6663
values={{
67-
date: props.book.lastUploadedDate!.toLocaleDateString(),
64+
date: originalUploadDateAsString,
65+
email: obfuscateEmail(props.book.uploader),
6866
}}
6967
/>
7068
</div>
69+
) : (
70+
<>
71+
<div>
72+
<FormattedMessage
73+
id="book.metadata.firstUploadedBy"
74+
defaultMessage="First uploaded {date} by {email}"
75+
values={{
76+
date: originalUploadDateAsString,
77+
email: obfuscateEmail(props.book.uploader),
78+
}}
79+
/>
80+
</div>
81+
<div>
82+
<FormattedMessage
83+
id="book.metadata.updatedOn"
84+
defaultMessage="Updated on {date}"
85+
values={{
86+
date: lastUploadDateAsString,
87+
}}
88+
/>
89+
</div>
90+
</>
7191
)}
7292
{props.book.importedBookSourceUrl &&
7393
props.book.importedBookSourceUrl.length > 0 && (

src/localization/Code Strings.json

+6-2
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,13 @@
242242
"description": "",
243243
"message": "Uploaded {date} by {email}"
244244
},
245-
"book.metadata.lastUploaded": {
245+
"book.metadata.firstUploadedBy": {
246246
"description": "",
247-
"message": "Last uploaded on {date}"
247+
"message": "First uploaded {date} by {email}"
248+
},
249+
"book.metadata.updatedOn": {
250+
"description": "",
251+
"message": "Updated on {date}"
248252
},
249253
"book.metadata.features": {
250254
"description": "",

0 commit comments

Comments
 (0)