Revert attempt to make project into type "module" (BL-12843)

This was causing an undetermined error when deployed to a real server.

Author: andrew-polk

.eslintrc.json

@@ -6,7 +6,6 @@
     },
     "parserOptions": {
         "ecmaVersion": 2021,
-        "sourceType": "module",
         "requireConfigFile": false
     },
     "parser": "@babel/eslint-parser",

.gitignore

@@ -28,4 +28,7 @@ node_modules
 
 # Emacs
 *~
+
 *.orig
+
+.eslintcache

bloomFirebaseAuthAdapter.js

@@ -1,5 +1,5 @@
-import jwt from "jsonwebtoken";
-import { get as httpGet } from "./httpsRequest.js";
+const httpsRequest = require("./httpsRequest");
+const jwt = require("jsonwebtoken");
 
 // This adapter, modified from the 'apple' one in parse-server, validates a user when
 // presented with a valid, current firebase-auth token from the appropriate domain whose email
@@ -21,7 +21,7 @@ let currentKey;
 const getPublicKeys = async () => {
     let data;
     try {
-        data = await httpGet(TOKEN_ISSUER);
+        data = await httpsRequest.get(TOKEN_ISSUER);
     } catch (e) {
         if (currentKey) {
             return currentKey;
@@ -121,7 +121,7 @@ function validateAppId() {
     return Promise.resolve();
 }
 
-export default {
+module.exports = {
     validateAppId,
     validateAuthData,
 };

cloud/emails.js

@@ -47,7 +47,7 @@ Parse.Cloud.define("testBookSaved", async () => {
 
 // Send an email to notify about a newly created book.
 // It is sent to an internal address, set by environment variable EMAIL_BOOK_EVENT_RECIPIENT on the server.
-export const sendEmailAboutNewBookAsync = async (parseBook) => {
+exports.sendEmailAboutNewBookAsync = async (parseBook) => {
     var bookId = parseBook.id;
     var query = new Parse.Query("books");
     query.equalTo("objectId", bookId);
@@ -105,7 +105,7 @@ function sendEmailAboutBookAsync(
             };
             Object.assign(/*target=*/ data, /*source=*/ dataForEmailClientJson);
 
-            const mailgun = import("mailgun-js");
+            const mailgun = require("mailgun-js");
             const mg = mailgun({
                 apiKey: process.env.MAILGUN_API_KEY,
                 domain: "bloomlibrary.org",

cloud/main.js

@@ -1,5 +1,5 @@
-import "./emails.js"; // allows email-specific cloud functions to be defined
-import "./utility.js"; // utility functions which don't belong in the main file
+require("./emails.js"); // allows email-specific could functions to be defined
+require("./utility.js"); // utility functions which don't belong in the main file
 
 // This function will call save on every book. This is useful for
 // applying the functionality in beforeSaveBook to every book,

httpsRequest.js

@@ -1,6 +1,6 @@
 // This helper file is needed by bloomFirebaseAuthAdapter.
 // It was copied (and slightly modified) from a file required by apple authAdapter in parser-server core code.
-import https from "https";
+const https = require("https");
 
 function makeCallback(resolve, reject, noJSON) {
     return function (res) {
@@ -23,19 +23,21 @@ function makeCallback(resolve, reject, noJSON) {
     };
 }
 
-export function get(options, noJSON = false) {
+function get(options, noJSON = false) {
     return new Promise((resolve, reject) => {
         https
             .get(options, makeCallback(resolve, reject, noJSON))
             .on("error", reject);
     });
 }
 
-export function request(options, postData) {
+function request(options, postData) {
     return new Promise((resolve, reject) => {
         const req = https.request(options, makeCallback(resolve, reject));
         req.on("error", reject);
         req.write(postData);
         req.end();
     });
 }
+
+module.exports = { get, request };

index.js

@@ -1,8 +1,10 @@
-import express from "express";
-import { ParseServer } from "parse-server";
-import http from "http";
-import ParseDashboard from "parse-dashboard";
-import BloomFirebaseAuthAdapter from "./bloomFirebaseAuthAdapter.js";
+// Feb 2023, we tried to upgrade this project to be of type "module" and use import/export instead of require.
+// It worked locally, but when we deployed to a real server, the parse server failed to start.
+// I never could determine why. So I punted and reverted to using require.
+const express = require("express");
+const ParseServer = require("parse-server").ParseServer;
+const ParseDashboard = require("parse-dashboard");
+const BloomFirebaseAuthAdapter = require("./bloomFirebaseAuthAdapter");
 
 const databaseUri = process.env.DATABASE_URI || process.env.MONGODB_URI;
 
@@ -11,10 +13,10 @@ if (!databaseUri) {
 }
 
 const serverConfig = {
-    databaseURI: databaseUri || "mongodb://localhost:27017/dev",
-    cloud: function () {
-        import("./cloud/main.js");
-    },
+    // Somehow, node 18 causes localhost to try to resolve as IPv6 here which can break things.
+    // Using 127.0.0.1 instead works around that.
+    databaseURI: databaseUri || "mongodb://127.0.0.1:27017/dev",
+    cloud: process.env.CLOUD_CODE_MAIN || __dirname + "/cloud/main.js",
     appId: process.env.APP_ID || "myAppId",
     masterKey: process.env.MASTER_KEY || "123",
     readOnlyMasterKey: process.env.READ_ONLY_MASTER_KEY || "ro",
@@ -61,24 +63,26 @@ const app = express();
 // Serve the Parse API on the /parse URL prefix
 const mountPath = process.env.PARSE_MOUNT || "/parse";
 const server = new ParseServer(serverConfig);
-await server.start();
-app.use(mountPath, server.app);
+// For an unknown reason, when deployed on a real server, await server.start() causes the server to never successfully start.
+server.start().then(() => {
+    app.use(mountPath, server.app);
 
-// The main thing here is the google-site-verification meta tag.
-// This lets us access the site on the Google Search Console.
-app.get("/", function (req, res) {
-    res.status(200).send(
-        "<html>" +
-            '<head><meta name="google-site-verification" content="dm8VsqC5uw-fikoD-4ZxYbPfzV-qYyrPCJq7aIgvlJo" /></head>' +
-            '<body><a href="https://bloomlibrary.org">Bloom Library</a></body>' +
-            "</html>"
-    );
-});
+    // The main thing here is the google-site-verification meta tag.
+    // This lets us access the site on the Google Search Console.
+    app.get("/", function (req, res) {
+        res.status(200).send(
+            "<html>" +
+                '<head><meta name="google-site-verification" content="dm8VsqC5uw-fikoD-4ZxYbPfzV-qYyrPCJq7aIgvlJo" /></head>' +
+                '<body><a href="https://bloomlibrary.org">Bloom Library</a></body>' +
+                "</html>"
+        );
+    });
 
-app.use("/dashboard", dashboard);
+    app.use("/dashboard", dashboard);
 
-const port = process.env.PORT || 1337;
-const httpServer = http.createServer(app);
-httpServer.listen(port, function () {
-    console.log("bloom-parse-server running on port " + port + ".");
+    const port = process.env.PORT || 1337;
+    const httpServer = require("http").createServer(app);
+    httpServer.listen(port, function () {
+        console.log("bloom-parse-server running on port " + port + ".");
+    });
 });

package-lock.json

@@ -10,6 +10,7 @@
   "main": "index.js",
   "scripts": {
     "start": "node index.js",
+    "lint": "eslint --cache ./cloud && eslint --cache index.js",
     "postinstall": "patch-package"
   },
   "// mailgun-js is deprecated; we should replace it with officially-supported mailgun.js": " ",
@@ -21,7 +22,6 @@
     "parse-server": "7.0.0-alpha.1",
     "patch-package": "8.0.0"
   },
-  "type": "module",
   "devDependencies": {
     "@babel/eslint-parser": "7.21.3",
     "eslint": "8.38.0",