You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The provided solution though, is limitade to disabling all predefined setups and require the user to define every flag
My suggestion is to rather add few flags to enable includes depending on flags presence, which would not have any downgrade compared to current possibilities but only improve usage for those who only need pre-defined setups
change 1 - this is only an example, it will have to be added for all newly defined flags though
//only include Uer_Setup.h if none of the defined flags are used. currently only one flag supported
#ifndef TTGO_T_DISPLAY
#include<User_Setup.h>// Default setup is root library folder
#endif
change 2 - this also would have to be wrapped for every include
//#include <User_Setups/Setup24_ST7789.h> // Setup file for DSTIKE/ESP32/ESP8266 configured for ST7789 240 x 240
#ifdef TTGO_T_DISPLAY
#include<User_Setups/Setup25_TTGO_T_Display.h>// Setup file for ESP32 and TTGO T-Display ST7789V SPI bus TFT
#endif//#include <User_Setups/Setup26_TTGO_T_Wristband.h> // Setup file for ESP32 and TTGO T-Wristband ST7735 SPI bus TFT
The platoformio.ini would look as nice as this and no modification in source code required
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This file has improved through time by considering platformio use case
https://github.com/Bodmer/TFT_eSPI/blob/master/User_Setup_Select.h
The provided solution though, is limitade to disabling all predefined setups and require the user to define every flag
My suggestion is to rather add few flags to enable includes depending on flags presence, which would not have any downgrade compared to current possibilities but only improve usage for those who only need pre-defined setups
change 1 - this is only an example, it will have to be added for all newly defined flags though
change 2 - this also would have to be wrapped for every include
The platoformio.ini would look as nice as this and no modification in source code required
This is a related issue #3154
I preferred not to raise an issue as this is not really a problem but an improvement
Beta Was this translation helpful? Give feedback.
All reactions