-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order of input contigs influences the results of combineTCR #293
Comments
Hey Michael, Thanks for outlining the problem above - is there a difference in the clone designations i.e. headers CTaa, CTnt, CTstrict, CTgene? The headers/columns you include above are actually ignored after combineTCR(). Nick |
Hi Nick, I think all the other columns look ok, but because |
Great! Then I'll start using the latest version from the main branch. |
removeNA
parameter (I use v1.11.0 installed from GitHub) doesn't work as expected.combineTCR
function returns different results depending on the order of the contigs in the input file. We don't see big difference unless we setremoveNA=TRUE
and/orfilterMulti=TRUE
.For example, for input where TRB is before TRA
the output of
combineTCR
function will beBut for input where TRA is before TRB (this also happens when we set
filterMulti=TRUE
, because in addition to deletion of one TRB we group by barcode and chain)The output of
combineTCR
function will include<NA>
ford_gene
. Thus, this line will be removed when we setremoveNA=TRUE
, because instead of checking onlyTCR1
andTCR2
columns we usena.omit
for all columns here.The text was updated successfully, but these errors were encountered: