Removed Massive Bottleneck when setting the Fitness manually due to calling IndexOF in the GeneticAlgorithm.

Also Note that Networks are now added to the end of the List when settings Fitness manually since its the fastest way. You may now need to do another SortToFitness-Call after setting the Fitness manually

Author: BotMaster3000

NeuralBotMasterFramework/NeuralBotMasterFramework/Logic/Algorithms/GeneticAlgorithm.cs

@@ -247,8 +247,8 @@ public void SetFitness(IWeightedNetwork network, double fitness)
         {
             ThrowIfNetworkNotInDictionary(network);
             KeyValuePair<IWeightedNetwork, double> temp = NetworksAndFitness.FirstOrDefault(x => x.Key == network);
-            int index = NetworksAndFitness.IndexOf(temp);
-            NetworksAndFitness[index] = new KeyValuePair<IWeightedNetwork, double>(network, fitness);
+            NetworksAndFitness.Remove(temp);
+            NetworksAndFitness.Add(new KeyValuePair<IWeightedNetwork, double>(network, fitness));
         }
 
         private void ThrowIfNetworkNotInDictionary(IWeightedNetwork network)

NeuralBotMasterFramework/NeuralBotMasterFrameworkTests/Logic/Algorithms/GeneticAlgorithmTests.cs

@@ -227,10 +227,10 @@ public void SetFitness_IWeightedNetworkAsParameter_NetworkNotFound_ShouldThrowAr
         public void SetFitness_NetworkIndexAsParameter()
         {
             int index = RandomNumberGenerator.GetNextNumber(0, Algorithm.NetworksAndFitness.Count);
-            double newFitnessValue = RandomNumberGenerator.GetNextDouble();
-            Algorithm.SetFitness(index, newFitnessValue);
-            KeyValuePair<IWeightedNetwork, double> networkAndFitness = Algorithm.NetworksAndFitness[index];
-            Assert.AreEqual(newFitnessValue, networkAndFitness.Value);
+            double newValue = RandomNumberGenerator.GetNextDouble();
+            IWeightedNetwork network = Algorithm.NetworksAndFitness.Select(x => x.Key).ElementAt(index);
+            Algorithm.SetFitness(index, newValue);
+            Assert.AreEqual(newValue, Algorithm.NetworksAndFitness.FirstOrDefault(x => x.Key == network).Value);
         }
     }
 }

NeuralBotMasterFramework/NeuralBotMasterFrameworkTests/Logic/PoolGenerators/FitnessBasedPoolGeneratorTests.cs

@@ -39,6 +39,7 @@ public void GenerateBreedingPoolTest()
         public void GenerateBreedingPool_ZeroFitnessScore_ShouldIgnoreZeroFitnesses()
         {
             algorithm.SetFitness(0, 100);
+            algorithm.SortByFitness();
             IBreedingPoolGenerator generator = new FitnessBasedPoolGenerator();
             List<IWeightedNetwork> networkList = generator.GenerateBreedingPool(algorithm.NetworksAndFitness.Take(NETWORKS_TO_KEEP).ToList());
             Assert.IsTrue(networkList.Count > 0);