Merge pull request #291 from BrainWise-DEV/PN-60-pay-on-account

feat: add support for credit sales in invoice submission process

Author: engahmed1190

POS/src/composables/useInvoice.js

@@ -974,6 +974,7 @@ export function useInvoice() {
 		targetDoctype = "Sales Invoice",
 		deliveryDate = null,
 		writeOffAmount = 0,
+		isCreditSale = false,
 	) {
 		/**
 		 * Two-step submission process with mutex protection:
@@ -1065,6 +1066,8 @@ export function useInvoice() {
 				if (redeemedCustomerCredit > 0 && customerCreditDict.length > 0) {
 					submitData.redeemed_customer_credit = redeemedCustomerCredit
 					submitData.customer_credit_dict = customerCreditDict
+				if (isCreditSale && invoicePayments.length === 0) {
+					submitData.is_credit_sale = 1
 				}
 
 				try {

POS/src/pages/POSSale.vue

@@ -2058,6 +2058,7 @@ async function handlePaymentCompleted(paymentData) {
 				total_discount: cartStore.totalDiscount,
 				write_off_amount: paymentData.write_off_amount || 0,
 				change_amount: paymentData.change_amount || 0,
+				is_credit_sale: paymentData.is_credit_sale ? 1 : 0,
 				edited_from: editingOfflineContext?.originalOfflineId || null,
 			};
 
@@ -2148,7 +2149,9 @@ async function handlePaymentCompleted(paymentData) {
 			// Get item codes from cart before clearing
 			const soldItemCodes = cartStore.invoiceItems.map((item) => item.item_code);
 
-			const result = await cartStore.submitInvoice();
+			const result = await cartStore.submitInvoice({
+				isCreditSale: Boolean(paymentData.is_credit_sale),
+			});
 
 			if (result) {
 				uiStore.clearLastOfflinePrintDoc();

POS/src/stores/posCart.js

@@ -254,7 +254,7 @@ export const usePOSCartStore = defineStore("posCart", () => {
 		writeOffAmount.value = amount || 0
 	}
 
-	async function submitInvoice() {
+	async function submitInvoice(options = {}) {
 		if (invoiceItems.value.length === 0) {
 			showWarning(__("Cart is empty"))
 			return
@@ -264,7 +264,12 @@ export const usePOSCartStore = defineStore("posCart", () => {
 			return
 		}
 
-		const result = await baseSubmitInvoice(targetDoctype.value, deliveryDate.value, writeOffAmount.value)
+		const result = await baseSubmitInvoice(
+			targetDoctype.value,
+			deliveryDate.value,
+			writeOffAmount.value,
+			Boolean(options.isCreditSale),
+		)
 		// Reset write-off amount after successful submission
 		if (result) {
 			writeOffAmount.value = 0

pos_next/api/invoices.py

@@ -1414,6 +1414,22 @@ def submit_invoice(invoice=None, data=None):
         if redeemed_customer_credit and not invoice_doc.payments:
             invoice_doc.flags.pos_next_redeemed_customer_credit = flt(redeemed_customer_credit)
 
+.
+        is_credit_sale = cint(data.get("is_credit_sale") or invoice.get("is_credit_sale"))
+        if (
+            is_credit_sale
+            and not invoice_doc.payments
+            and flt(invoice_doc.grand_total) > 0
+        ):
+            allow_credit_sale = cint(
+                frappe.db.get_value(
+                    DOCTYPE_POS_SETTINGS, {"pos_profile": pos_profile}, "allow_credit_sale"
+                )
+            )
+            if not allow_credit_sale:
+                frappe.throw(_("Credit sales are not enabled for this POS Profile."))
+            invoice_doc.flags.pos_next_credit_sale = 1
+
         # Save before submit
         invoice_doc.flags.ignore_permissions = True
         frappe.flags.ignore_account_permission = True

pos_next/overrides/sales_invoice.py

@@ -173,14 +173,21 @@ def make_pos_gl_entries(self, gl_entries):
 
 	def validate_pos_paid_amount(self):
 		"""
-		Allow pure customer-credit POS sales to submit without a payment row.
+		Allow POS sales to submit without a payment row in two cases:
 
-		POSNext redeems customer credit after submit through Journal Entries /
-		Payment Entry allocation, so there is no real Mode of Payment row to send.
-		Only bypass the core POS payment-row check when submit_invoice has explicitly
-		marked the document for customer-credit redemption.
+		1. Pure customer-credit redemption — POSNext redeems existing customer
+		   credit after submit through Journal Entries / Payment Entry allocation,
+		   so there is no real Mode of Payment row to send.
+		2. "Pay on Account" credit sales — the cashier intentionally puts the full
+		   amount on the customer's account, leaving the invoice outstanding.
+
+		Both are only honoured when submit_invoice has explicitly marked the
+		document via the corresponding flag (set after verifying the POS Settings
+		permit the operation), so a tampered client can't bypass the check.
 		"""
-		if getattr(self.flags, "pos_next_redeemed_customer_credit", 0):
+		if getattr(self.flags, "pos_next_redeemed_customer_credit", 0) or getattr(
+			self.flags, "pos_next_credit_sale", 0
+		):
 			if len(self.payments) == 0 and cint(self.is_pos) and flt(self.grand_total) > 0:
 				return