Personal page for uchechukwu #29
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
melanke
left a comment
melanke
left a comment
There was a problem hiding this comment.
Thanks for your page!
I'd like to ask you to improve your PR description:
- In the PR description template there are checkboxes that should be present in your PR description and checked.
And here comes my review. Things I think you should improve in your code:
There was a problem hiding this comment.
Oops! I think you're sending this file by mistake. It's completely unrelated to your personal page, so please keep it outside of this PR. Let me know if you need help removing it from the PR using Git.
There was a problem hiding this comment.
This change is also unrelated to your personal page, please remove it from the PR.
There was a problem hiding this comment.
This change is also unrelated to your personal page, please remove it from the PR.
There was a problem hiding this comment.
This change is also unrelated to your personal page, please remove it from the PR.
| <BlockieAvatar address={BUILDER_ADDRESS} size={120} /> | ||
| <h1 className="text-4xl font-bold mt-4 mb-2">Uchechukwu Ekezie</h1> | ||
| <div className="flex flex-col items-center gap-2 mb-4"> | ||
| <Address address={BUILDER_ADDRESS} format="long" blockExplorerAddressLink={blockExplorerAddressLink} /> |
There was a problem hiding this comment.
There is no property blockExplorerAddressLink on Address component.
|
|
||
| const BUILDER_ADDRESS: AddressType = "0xa91D5A0a64ED5eeF11c4359C4631279695A338ef"; | ||
|
|
||
| export default function BuilderPage() { |
There was a problem hiding this comment.
Please name your page with something more unique, like your name or nickname.
And you might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.
| {/* <a | ||
| href="https://etherscan.io/address/0xa91D5A0a64ED5eeF11c4359C4631279695A338ef" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="flex items-center gap-3 p-4 bg-base-200 rounded-xl hover:bg-base-300 transition-colors" | ||
| > | ||
| <svg className="w-6 h-6" fill="currentColor" viewBox="0 0 24 24"> | ||
| <path d="M12 2C6.48 2 2 6.48 2 12s4.48 10 10 10 10-4.48 10-10S17.52 2 12 2zm-2 15l-5-5 1.41-1.41L10 14.17l7.59-7.59L19 8l-9 9z" /> | ||
| </svg> | ||
| <span className="font-semibold">Etherscan</span> | ||
| </a> */} |
There was a problem hiding this comment.
It's bad practice to leave commented code. Other contributors might be confused about whether it should be uncommented or removed.
| <svg className="w-6 h-6" fill="currentColor" viewBox="0 0 24 24"> | ||
| <path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z" /> | ||
| </svg> |
There was a problem hiding this comment.
I think these SVGs could be stored in a separate file each, since they take up too much space in the code.
|
working on it sir am sorry for replying late |
2 participants
This PR adds my personal builder page for Batch 22 of BuidlGuidl. The page features:
Two-card layout with profile information and "About Me" section
Gradient title with custom styling using accent, info, and success colors
Avatar with "CD" initials in a gradient circle
Social links with GitHub and Twitter buttons (with SVG icons)
Responsive design that adapts to mobile and desktop views
Enhanced styling with shadows, borders, and hover effects
TypeScript with proper NextPage typing
The page is located at /builders/0x3Be7fbBDbC73Fc4731D60EF09c4BA1A94DC58E41 and includes:
Welcome section with gradient title
Profile card with avatar, address, bio, and social links
About Me card with sections for Learning, Interests, and Goals
Closes #10
Your ENS/address:
0xa91D5A0a64ED5eeF11c4359C4631279695A338ef