Skip to content

Conversation

@phipsae
Copy link
Contributor

@phipsae phipsae commented Aug 21, 2025

Hey,

With this PR I’m re-adding the link to the NFT contracts on OpenSea. Now that we’ve added the network field to the batch database, this is possible

Screenshot 2025-08-21 at 16 41 03

Let me know what you think and hope its okay :)

@phipsae phipsae requested review from Pabl0cks and carletex August 21, 2025 14:42
@vercel
Copy link

vercel bot commented Aug 21, 2025

@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@carletex carletex removed their request for review August 22, 2025 08:25
@vercel
Copy link

vercel bot commented Aug 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
buidlguidl-landing Ready Ready Preview Comment Aug 25, 2025 9:11pm

<td className="py-3 px-2 xs:px-4">{batch.name}</td>
<td className="py-3 px-2 xs:px-4 hidden lg:table-cell">{formatDate(batch.startDate)}</td>
<td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants || "-"}</td>
<td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants}</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the old fallback || "-" ?

Website
</TrackedLink>
<div className="flex items-center gap-1">
{batch.nftContractAddress && batch.graduates && batch.graduates > 0 ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add && batch.network validation here, or there is no need?

Comment on lines +427 to +428
graduates: batch.graduates,
network: batch.network,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant in this case?

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @phipsae ! It's working nicely to me.

Added a few nitpick comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants