-
Notifications
You must be signed in to change notification settings - Fork 10
Add opensea link back #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| <td className="py-3 px-2 xs:px-4">{batch.name}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden lg:table-cell">{formatDate(batch.startDate)}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants || "-"}</td> | ||
| <td className="py-3 px-2 xs:px-4 hidden sm:table-cell">{batch.totalParticipants}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the old fallback || "-" ?
| Website | ||
| </TrackedLink> | ||
| <div className="flex items-center gap-1"> | ||
| {batch.nftContractAddress && batch.graduates && batch.graduates > 0 ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add && batch.network validation here, or there is no need?
| graduates: batch.graduates, | ||
| network: batch.network, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this redundant in this case?
Pabl0cks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @phipsae ! It's working nicely to me.
Added a few nitpick comments
Hey,
With this PR I’m re-adding the link to the NFT contracts on OpenSea. Now that we’ve added the network field to the batch database, this is possible
Let me know what you think and hope its okay :)