Merge pull request #62 from escottalexander/readme

Readme

Author: escottalexander

README.md

@@ -9,10 +9,13 @@ contract SimpleOracle {
 
     constructor() {}
 
-    // Note: In a real oracle implementation, this function would typically have
-    // an onlyOwner modifier to restrict who can update prices. We've removed
-    // it here to make prices easily editable in the frontend.
-    function setPrice(uint256 _newPrice) public {
+    modifier onlyOwner() {
+        // Intentionally removing the owner requirement to make it easy for you to impersonate the owner
+        // require(msg.sender == owner, "Not the owner");
+        _;
+    }
+
+    function setPrice(uint256 _newPrice) public onlyOwner {
         price = _newPrice;
         timestamp = block.timestamp;
         emit PriceUpdated(_newPrice);

packages/hardhat/contracts/SimpleOracle.sol renamed to packages/hardhat/contracts/00_Whitelist/SimpleOracle.sol

@@ -16,7 +16,8 @@ contract WhitelistOracle {
     }
 
     modifier onlyOwner() {
-        require(msg.sender == owner, "Not the owner");
+        // Intentionally removing the owner requirement to make it easy for you to impersonate the owner
+        // require(msg.sender == owner, "Not the owner");
         _;
     }
 

packages/hardhat/contracts/WhitelistOracle.sol renamed to packages/hardhat/contracts/00_Whitelist/WhitelistOracle.sol

@@ -185,4 +185,6 @@ contract StakingOracle {
     function getNodeAddresses() public view returns (address[] memory) {
         return nodeAddresses;
     }
+
+    // Notably missing a way to unstake and exit your node but not needed for the challenge
 }

packages/hardhat/contracts/OracleToken.sol renamed to packages/hardhat/contracts/01_Staking/OracleToken.sol

@@ -71,6 +71,13 @@ contract OptimisticOracle {
         emit DeciderUpdated(oldDecider, _decider);
     }
 
+    /**
+     * @notice Get the assertion details.
+     */
+    function getAssertion(uint256 assertionId) external view returns (EventAssertion memory) {
+        return assertions[assertionId];
+    }
+
     /**
      * @notice Assert that an event will have a true/false outcome.
      * @dev The `description` is used to identify the event (e.g. "Did X happen by time Y?")
@@ -281,11 +288,4 @@ contract OptimisticOracle {
             return a.resolvedOutcome;
         }
     }
-
-    /**
-     * @notice Get the assertion details.
-     */
-    function getAssertion(uint256 assertionId) external view returns (EventAssertion memory) {
-        return assertions[assertionId];
-    }
 }

packages/hardhat/contracts/StakingOracle.sol renamed to packages/hardhat/contracts/01_Staking/StakingOracle.sol

@@ -11,8 +11,6 @@ const deployWhitelistOracleContracts: DeployFunction = async function (hre: Hard
   const { deployer } = await hre.getNamedAccounts();
   const { deploy } = hre.deployments;
   const { viem } = hre;
-  // Set your own address here
-  const whitelistContractNewOwner = deployer;
 
   const publicClient = await viem.getPublicClient();
 
@@ -107,17 +105,6 @@ const deployWhitelistOracleContracts: DeployFunction = async function (hre: Hard
   });
   console.log(`Initial median price: ${medianPrice.toString()}`);
 
-  if (deployer !== whitelistContractNewOwner) {
-    console.log("Transferring ownership of WhitelistOracle");
-    await deployerAccount.writeContract({
-      address: whitelistOracleAddress,
-      abi: whitelistOracleAbi,
-      functionName: "transferOwnership",
-      args: [whitelistContractNewOwner],
-    });
-    console.log("Ownership transferred successfully!");
-  }
-
   console.log("All oracle contracts deployed and configured successfully!");
 };