Skip to content

Commit ef692ab

Browse files
committed
fix: remove unused code. updated the deescription of unit test
1 parent 49c6374 commit ef692ab

File tree

5 files changed

+4
-52
lines changed

5 files changed

+4
-52
lines changed

packages/sdks-tests/src/e2e-tests/hit-content-api.spec.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -79,33 +79,4 @@ test.describe('Get Content', () => {
7979
expect(headers?.['x-builder-sdk-gen']).toBe(getSdkGeneration(sdk));
8080
expect(headers?.['x-builder-sdk-version']).toMatch(/\d+\.\d+\.\d+/); // Check for semver format
8181
});
82-
83-
test('should include componentsUsed by default when omit is empty string', async ({ page, sdk }) => {
84-
test.skip(!excludeGen1(sdk));
85-
86-
const urlMatch = /https:\/\/cdn\.builder\.io\/api\/v3\/content/;
87-
let requestUrl: string | undefined;
88-
89-
await page.route(urlMatch, async route => {
90-
requestUrl = route.request().url();
91-
return route.fulfill({
92-
status: 200,
93-
json: {
94-
meta: {
95-
componentsUsed: {
96-
MyFunComponent: 1,
97-
},
98-
}
99-
}
100-
});
101-
});
102-
103-
await page.goto('/get-content-with-omit', { waitUntil: 'networkidle' });
104-
105-
// Add null check before assertions
106-
expect(requestUrl).toBeDefined();
107-
expect(requestUrl!).not.toContain('omit=meta.componentsUsed');
108-
expect(requestUrl!.includes('omit=')).toBeTruthy();
109-
expect(new URL(requestUrl!).searchParams.get('omit')).toBe('');
110-
});
11182
});

packages/sdks-tests/src/specs/index.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -397,13 +397,6 @@ export const getProps = async (args: {
397397
apiEndpoint: 'content',
398398
};
399399
break;
400-
case '/get-content-with-omit':
401-
extraProps = {
402-
apiEndpoint: 'content',
403-
omit: '',
404-
apiKey: REAL_API_KEY,
405-
};
406-
break;
407400
case '/get-query':
408401
extraProps = {
409402
options: { apiEndpoint: 'query', format: 'html', model: 'abcd', key: 'abcd' },

packages/sdks/e2e/react/src/App.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,6 @@ function App() {
5454
}
5555
}, []);
5656

57-
useEffect(() => {
58-
if (window.location.pathname === '/get-content-with-omit' && props) {
59-
fetchOneEntry({
60-
model: 'page',
61-
userAttributes: {
62-
urlPath: window.location.pathname,
63-
},
64-
...props,
65-
});
66-
}
67-
}, [props]);
68-
6957
if (window.location.pathname === '/data-preview') {
7058
if (!props?.content) {
7159
return <div>Loading...</div>;

packages/sdks/src/functions/get-content/__snapshots__/generate-content-url.test.ts.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ exports[`Generate Content URL > generate content url with omit, fields, offset,
3030

3131
exports[`Generate Content URL > generates the proper value for a simple query 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit=meta.componentsUsed&query.id=%22c1b81bab59704599b997574eb0736def%22"`;
3232

33-
exports[`Generate Content URL > handles undefined, null, and empty string as omit parameter values > omit-empty-string 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit="`;
33+
exports[`Generate Content URL > handles empty string as omit parameter values > omit-empty-string 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit="`;
3434

35-
exports[`Generate Content URL > handles undefined, null, and empty string as omit parameter values > omit-null 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit=name"`;
35+
exports[`Generate Content URL > handles defined string as omit parameter values > omit-null 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit=name"`;
3636

37-
exports[`Generate Content URL > handles undefined, null, and empty string as omit parameter values > omit-undefined 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit=meta.componentsUsed"`;
37+
exports[`Generate Content URL > handles undefined as omit parameter values > omit-undefined 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&omit=meta.componentsUsed"`;
3838

3939
exports[`Generate Content URL > preserves both userAttributes.locale and top-level locale when both provided 1`] = `"https://cdn.builder.io/api/v3/content/page?apiKey=YJIGb4i01jvw0SRdL5Bt&limit=30&noTraverse=true&includeRefs=true&locale=en-US&omit=meta.componentsUsed&userAttributes=%7B%22locale%22%3A%22es-ES%22%2C%22foo%22%3A%22bar%22%7D"`;

packages/sdks/src/functions/get-content/generate-content-url.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('Generate Content URL', () => {
3535
expect(output).toMatchSnapshot();
3636
});
3737

38-
test('handles undefined, null, and empty string as omit parameter values', () => {
38+
test('handles undefined, defined, and empty string as omit parameter values', () => {
3939
// Test with undefined (should default to 'meta.componentsUsed')
4040
const outputUndefined = generateContentUrl({
4141
apiKey: testKey,

0 commit comments

Comments
 (0)