From eadae7ba9b867d568e4d648ca1276c5acc323222 Mon Sep 17 00:00:00 2001 From: Yash Wadhia Date: Wed, 12 Mar 2025 12:19:31 +0530 Subject: [PATCH 01/11] fix: force re-rendering the symbol for updating the values --- packages/sdks/src/blocks/symbol/symbol.lite.tsx | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/sdks/src/blocks/symbol/symbol.lite.tsx b/packages/sdks/src/blocks/symbol/symbol.lite.tsx index 37506452e02..007da98d06b 100644 --- a/packages/sdks/src/blocks/symbol/symbol.lite.tsx +++ b/packages/sdks/src/blocks/symbol/symbol.lite.tsx @@ -27,6 +27,7 @@ useMetadata({ export default function Symbol(props: SymbolProps) { const state = useStore({ + forceRenderCount: 0, get blocksWrapper() { return useTarget({ // eslint-disable-next-line @typescript-eslint/ban-ts-comment @@ -82,9 +83,17 @@ export default function Symbol(props: SymbolProps) { } }); }, + shouldForceRender() { + console.log('shouldForceRender', props.symbol); + return false; + }, }); onUpdate(() => { + if (state.shouldForceRender()) { + state.forceRenderCount = state.forceRenderCount + 1; + } + state.setContent(); }, [props.symbol]); @@ -103,6 +112,7 @@ export default function Symbol(props: SymbolProps) { return (
Date: Wed, 12 Mar 2025 17:31:07 +0530 Subject: [PATCH 02/11] feat: implemented test case 'symbol should update the data when nested values are updated' --- .../sdks-tests/src/e2e-tests/editing.spec.ts | 17 ++ packages/sdks-tests/src/specs/index.ts | 2 + .../sdks-tests/src/specs/nested-symbol.ts | 170 ++++++++++++++++++ .../sdks/src/blocks/symbol/symbol.lite.tsx | 8 +- 4 files changed, 190 insertions(+), 7 deletions(-) create mode 100644 packages/sdks-tests/src/specs/nested-symbol.ts diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 87516751d27..fec945c1676 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -19,6 +19,7 @@ import { ADD_A_TEXT_BLOCK } from '../specs/duplicated-content-using-nested-symbo import { EDITING_STYLES } from '../specs/editing-styles.js'; import { ACCORDION_WITH_NO_DETAIL } from '../specs/accordion.js'; import { NEW_BLOCK_ADD } from '../specs/new-block-add.js'; +import { NESTED_SYMBOL_CONTENT } from '../specs/nested-symbol.js'; const editorTests = ({ noTrustedHosts, @@ -548,4 +549,20 @@ test.describe('Visual Editing', () => { await page.frameLocator('iframe').getByText('new text').waitFor({ state: 'hidden' }); }); }); + + test.only('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk }) => { + await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); + + const newContent = cloneContent(NESTED_SYMBOL_CONTENT); + + await sendPatchOrUpdateMessage({ + page, + content: newContent, + model: 'page', + sdk, + path: '/data/blocks/0/component/options/symbol/data/language/1/code', + updateFn: () => 'AFK', + }); + await page.frameLocator('iframe').getByText('AFK').waitFor(); + }); }); diff --git a/packages/sdks-tests/src/specs/index.ts b/packages/sdks-tests/src/specs/index.ts index 2444fe5bcc5..52bd52f2dae 100644 --- a/packages/sdks-tests/src/specs/index.ts +++ b/packages/sdks-tests/src/specs/index.ts @@ -90,6 +90,7 @@ import { CUSTOM_CODE_DOM_UPDATE } from './custom-code-dom-update.js'; import { NEW_BLOCK_ADD } from './new-block-add.js'; import { DYNAMIC_BUTTON } from './dynamic-button.js'; +import { NESTED_SYMBOL_CONTENT } from './nested-symbol.js'; function isBrowser(): boolean { return typeof window !== 'undefined' && typeof document !== 'undefined'; } @@ -137,6 +138,7 @@ export const PAGES: Record = { '/image-high-priority': { content: imageHighPriority }, '/image-no-webp': { content: imageNoWebp }, '/data-bindings': { content: dataBindings }, + '/nested-symbol': { content: NESTED_SYMBOL_CONTENT }, '/data-binding-styles': { content: dataBindingStyles }, '/react-native-strict-style-mode': { content: REACT_NATIVE_STRICT_STYLE_MODE_CONTENT }, '/react-native-strict-style-mode-disabled': { content: REACT_NATIVE_STRICT_STYLE_MODE_CONTENT }, diff --git a/packages/sdks-tests/src/specs/nested-symbol.ts b/packages/sdks-tests/src/specs/nested-symbol.ts new file mode 100644 index 00000000000..ed902ac0766 --- /dev/null +++ b/packages/sdks-tests/src/specs/nested-symbol.ts @@ -0,0 +1,170 @@ +export const NESTED_SYMBOL_CONTENT = { + data: { + title: 'react-sdk', + themeId: false, + blocks: [ + { + '@type': '@builder.io/sdk:Element', + '@version': 2, + id: 'builder-fdc6514a5f0e4bcab8d3a981e5adb164', + component: { + name: 'Symbol', + options: { + symbol: { + content: { + data: { + inputs: [ + { + '@type': '@builder.io/core:Field', + meta: {}, + name: 'language', + type: 'list', + defaultValue: [{ code: 'HN' }], + required: false, + subFields: [ + { + '@type': '@builder.io/core:Field', + meta: {}, + name: 'code', + type: 'text', + required: false, + subFields: [], + helperText: '', + autoFocus: false, + simpleTextOnly: false, + disallowRemove: false, + broadcast: false, + bubble: false, + hideFromUI: false, + hideFromFieldsEditor: false, + showTemplatePicker: true, + permissionsRequiredToEdit: '', + advanced: false, + copyOnAdd: true, + onChange: '', + behavior: '', + showIf: '', + mandatory: false, + hidden: false, + noPhotoPicker: false, + model: '', + supportsAiGeneration: false, + defaultCollapsed: false, + }, + ], + helperText: '', + autoFocus: false, + simpleTextOnly: false, + disallowRemove: false, + broadcast: false, + bubble: false, + hideFromUI: false, + hideFromFieldsEditor: false, + showTemplatePicker: true, + permissionsRequiredToEdit: '', + advanced: false, + copyOnAdd: true, + onChange: '', + behavior: '', + showIf: '', + mandatory: false, + hidden: false, + noPhotoPicker: false, + model: '', + supportsAiGeneration: false, + defaultCollapsed: false, + }, + { + '@type': '@builder.io/core:Field', + meta: {}, + name: 'newField1', + type: 'text', + required: false, + subFields: [], + helperText: '', + autoFocus: false, + simpleTextOnly: false, + disallowRemove: false, + broadcast: false, + bubble: false, + hideFromUI: false, + hideFromFieldsEditor: false, + showTemplatePicker: true, + permissionsRequiredToEdit: '', + advanced: false, + copyOnAdd: true, + onChange: '', + behavior: '', + showIf: '', + mandatory: false, + hidden: false, + noPhotoPicker: false, + model: '', + supportsAiGeneration: false, + defaultCollapsed: false, + }, + ], + blocks: [ + { + '@type': '@builder.io/sdk:Element', + '@version': 2, + bindings: { + 'component.options.text': + 'var _virtual_index=state.languageItem.code;return _virtual_index', + }, + code: { bindings: { 'component.options.text': 'state.languageItem.code' } }, + repeat: { collection: 'state.language' }, + id: 'builder-080852d1360b4f08a54f436bbfe32b44', + meta: { + previousId: 'builder-8ede3ef8afbc499f9eb0152d1c3d63fc', + bindingActions: { + _newProperty: null, + component: { options: { text: null } }, + }, + }, + component: { name: 'Text', options: { text: 'Enter some text...' } }, + responsiveStyles: { + large: { + display: 'flex', + flexDirection: 'column', + position: 'relative', + flexShrink: '0', + boxSizing: 'border-box', + marginTop: '20px', + lineHeight: 'normal', + height: 'auto', + }, + }, + }, + ], + }, + }, + data: { + language: [ + { + code: 'HN', + }, + { + code: 'EN', + }, + ], + }, + model: 'symbol', + entry: 'acd89180466e478d9e9c2f0ca803e650', + ownerId: 'c59dc54530484a9cac6cbb759f637b2d', + }, + }, + }, + responsiveStyles: { + large: { + display: 'flex', + flexDirection: 'column', + position: 'relative', + flexShrink: '0', + boxSizing: 'border-box', + }, + }, + }, + ], + }, +}; diff --git a/packages/sdks/src/blocks/symbol/symbol.lite.tsx b/packages/sdks/src/blocks/symbol/symbol.lite.tsx index 007da98d06b..717c2e50818 100644 --- a/packages/sdks/src/blocks/symbol/symbol.lite.tsx +++ b/packages/sdks/src/blocks/symbol/symbol.lite.tsx @@ -83,16 +83,10 @@ export default function Symbol(props: SymbolProps) { } }); }, - shouldForceRender() { - console.log('shouldForceRender', props.symbol); - return false; - }, }); onUpdate(() => { - if (state.shouldForceRender()) { - state.forceRenderCount = state.forceRenderCount + 1; - } + state.forceRenderCount = state.forceRenderCount + 1; state.setContent(); }, [props.symbol]); From 87ba0cb01ed7c03b990b04c03f2ad631cf72db64 Mon Sep 17 00:00:00 2001 From: Yash Wadhia Date: Wed, 12 Mar 2025 17:47:44 +0530 Subject: [PATCH 03/11] fix: removed .only --- packages/sdks-tests/src/e2e-tests/editing.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index f4865259db4..1f0a37fbd20 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -646,7 +646,7 @@ test.describe('Visual Editing', () => { }); }); - test.only('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk }) => { + test('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk }) => { await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); const newContent = cloneContent(NESTED_SYMBOL_CONTENT); From 567f81cf93064681e95dd997335dd0ce9c25ee97 Mon Sep 17 00:00:00 2001 From: yash-builder Date: Wed, 19 Mar 2025 11:58:45 +0530 Subject: [PATCH 04/11] fix: update mitosis and skipping gen-1 sdk --- .../sdks-tests/src/e2e-tests/editing.spec.ts | 4 ++++ packages/sdks/package.json | 4 ++-- yarn.lock | 22 +++++++++---------- 3 files changed, 17 insertions(+), 13 deletions(-) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 1f0a37fbd20..5b6aba7a50a 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -647,6 +647,9 @@ test.describe('Visual Editing', () => { }); test('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk }) => { + + test.skip(excludeGen1(sdk)); + await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); const newContent = cloneContent(NESTED_SYMBOL_CONTENT); @@ -659,6 +662,7 @@ test.describe('Visual Editing', () => { path: '/data/blocks/0/component/options/symbol/data/language/1/code', updateFn: () => 'AFK', }); + await page.frameLocator('iframe').getByText('AFK').waitFor(); }); }); diff --git a/packages/sdks/package.json b/packages/sdks/package.json index aa1c8436945..33a7cafd151 100644 --- a/packages/sdks/package.json +++ b/packages/sdks/package.json @@ -57,8 +57,8 @@ "upgrade-example:all": "yarn loop upgrade-example latest" }, "dependencies": { - "@builder.io/mitosis": "^0.6.1", - "@builder.io/mitosis-cli": "^0.6.1", + "@builder.io/mitosis": "^0.7.3", + "@builder.io/mitosis-cli": "^0.7.3", "isolated-vm": "^5.0.0", "node-fetch": "^2.6.1", "seedrandom": "^3.0.5", diff --git a/yarn.lock b/yarn.lock index d3818c243ba..8f70d6db8af 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5544,11 +5544,11 @@ __metadata: languageName: node linkType: hard -"@builder.io/mitosis-cli@npm:^0.6.1": - version: 0.6.1 - resolution: "@builder.io/mitosis-cli@npm:0.6.1" +"@builder.io/mitosis-cli@npm:^0.7.3": + version: 0.7.3 + resolution: "@builder.io/mitosis-cli@npm:0.7.3" dependencies: - "@builder.io/mitosis": 0.6.1 + "@builder.io/mitosis": 0.7.3 debug: ^4.3.4 dedent: ^0.7.0 esbuild: ^0.12.16 @@ -5561,13 +5561,13 @@ __metadata: ts-morph: ^19.0.0 bin: mitosis: bin/mitosis - checksum: 2e98cd763b9c18ca7248a45d2f8dda3974822e6bf02327f0e9dbfb1253b8c71e5c71361d99957fe1cdea719a2c22f3154dea65d04c453ad8aa1e2b510fe2fe02 + checksum: 9971cc4eed1c00cbd6e8d613a72b4d028be4205296d07b9c4bf381248b86ef1a09c74e29828f34560b7de2aec70765057495e10544c317f467746e4701153a06 languageName: node linkType: hard -"@builder.io/mitosis@npm:0.6.1, @builder.io/mitosis@npm:^0.6.1": - version: 0.6.1 - resolution: "@builder.io/mitosis@npm:0.6.1" +"@builder.io/mitosis@npm:0.7.3, @builder.io/mitosis@npm:^0.7.3": + version: 0.7.3 + resolution: "@builder.io/mitosis@npm:0.7.3" dependencies: "@angular/compiler": ^11.2.11 "@babel/core": 7.14.5 @@ -5592,7 +5592,7 @@ __metadata: svelte-preprocess: ^5.0.3 ts-morph: ^19.0.0 typescript: ^5.3.2 - checksum: 258b7ee6edb275af5cf8d2822598057b603239b4a1e46d0e6c4f1bb67e39d3d78c4f2b1805c4f6316426b4317fa1d382e1e8fd46547727f8ee13b3fb22e5e94c + checksum: 6edbe375f8dfb121ab12eb694bc57bfae93bd6cb5a04d661cb8d9aa8f780e7dec6063553ca01657d54fcf0d9c3cdc07685685c924c06b811a4652cfbd0fd0e44 languageName: node linkType: hard @@ -5997,8 +5997,8 @@ __metadata: dependencies: "@arethetypeswrong/cli": ^0.13.3 "@builder.io/eslint-plugin-mitosis": ^0.0.16 - "@builder.io/mitosis": ^0.6.1 - "@builder.io/mitosis-cli": ^0.6.1 + "@builder.io/mitosis": ^0.7.3 + "@builder.io/mitosis-cli": ^0.7.3 "@types/node-fetch": ^2.5.12 "@types/seedrandom": ^3.0.4 "@types/traverse": ^0.6.32 From 5587367f52f765c6e6b48986a1407015c3cc5e98 Mon Sep 17 00:00:00 2001 From: yash-builder Date: Mon, 24 Mar 2025 10:30:04 +0530 Subject: [PATCH 05/11] fix: removed force update for updating data in list and added actual solution --- packages/sdks-tests/src/e2e-tests/editing.spec.ts | 3 ++- packages/sdks/src/blocks/symbol/symbol.lite.tsx | 4 ---- packages/sdks/src/components/block/block.helpers.ts | 8 ++++++++ packages/sdks/src/components/block/block.lite.tsx | 5 +++-- .../components/block/components/repeated-block.lite.tsx | 6 +++++- 5 files changed, 18 insertions(+), 8 deletions(-) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 5b6aba7a50a..c6af9d3666b 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -646,9 +646,10 @@ test.describe('Visual Editing', () => { }); }); - test('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk }) => { + test('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk, packageName }) => { test.skip(excludeGen1(sdk)); + test.skip(packageName === 'nextjs-sdk-next-app'); await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); diff --git a/packages/sdks/src/blocks/symbol/symbol.lite.tsx b/packages/sdks/src/blocks/symbol/symbol.lite.tsx index 717c2e50818..37506452e02 100644 --- a/packages/sdks/src/blocks/symbol/symbol.lite.tsx +++ b/packages/sdks/src/blocks/symbol/symbol.lite.tsx @@ -27,7 +27,6 @@ useMetadata({ export default function Symbol(props: SymbolProps) { const state = useStore({ - forceRenderCount: 0, get blocksWrapper() { return useTarget({ // eslint-disable-next-line @typescript-eslint/ban-ts-comment @@ -86,8 +85,6 @@ export default function Symbol(props: SymbolProps) { }); onUpdate(() => { - state.forceRenderCount = state.forceRenderCount + 1; - state.setContent(); }, [props.symbol]); @@ -106,7 +103,6 @@ export default function Symbol(props: SymbolProps) { return (
{ + if (TARGET === 'qwik') { + return `${index}-${Date.now()}`; + } + return index.toString(); +}; diff --git a/packages/sdks/src/components/block/block.lite.tsx b/packages/sdks/src/components/block/block.lite.tsx index 64048be8b3a..b74061347f3 100644 --- a/packages/sdks/src/components/block/block.lite.tsx +++ b/packages/sdks/src/components/block/block.lite.tsx @@ -20,6 +20,7 @@ import type { BuilderBlock } from '../../types/builder-block.js'; import DynamicDiv from '../dynamic-div.lite.jsx'; import { bindAnimations } from './animator.js'; import { + generateKey, getComponent, getInheritedStyles, getRepeatItemData, @@ -278,7 +279,7 @@ export default function Block(props: BlockProps) { {(data, index) => ( {(data, index) => ( { + store.value = props.repeatContext; + }, [props.repeatContext]); + return ( Date: Mon, 24 Mar 2025 11:53:52 +0530 Subject: [PATCH 06/11] doc: added changeset --- .changeset/short-poets-reflect.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .changeset/short-poets-reflect.md diff --git a/.changeset/short-poets-reflect.md b/.changeset/short-poets-reflect.md new file mode 100644 index 00000000000..76676a1a001 --- /dev/null +++ b/.changeset/short-poets-reflect.md @@ -0,0 +1,12 @@ +--- +"@builder.io/sdk-angular": patch +"@builder.io/sdk-react-nextjs": patch +"@builder.io/sdk-qwik": patch +"@builder.io/sdk-react": patch +"@builder.io/sdk-react-native": patch +"@builder.io/sdk-solid": patch +"@builder.io/sdk-svelte": patch +"@builder.io/sdk-vue": patch +--- + +Fix: list-type inputs within symbols were not updating in the preview From ba563f253c8faaace16dcb76972d9455818e8fd7 Mon Sep 17 00:00:00 2001 From: yash-builder Date: Tue, 25 Mar 2025 19:06:23 +0530 Subject: [PATCH 07/11] fix: naming conventions --- packages/sdks-tests/src/e2e-tests/editing.spec.ts | 4 ++-- packages/sdks-tests/src/specs/index.ts | 4 ++-- .../{nested-symbol.ts => symbols-with-list-content-input.ts} | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename packages/sdks-tests/src/specs/{nested-symbol.ts => symbols-with-list-content-input.ts} (99%) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 565105389ed..7d0b4123de7 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -18,7 +18,7 @@ import { MODIFIED_EDITING_COLUMNS } from '../specs/editing-columns-inner-layout. import { ADD_A_TEXT_BLOCK } from '../specs/duplicated-content-using-nested-symbols.js'; import { EDITING_STYLES } from '../specs/editing-styles.js'; import { ACCORDION_WITH_NO_DETAIL } from '../specs/accordion.js'; -import { NESTED_SYMBOL_CONTENT } from '../specs/nested-symbol.js'; +import { SYMBOLS_WITH_LIST_CONTENT_INPUT } from '../specs/symbols-with-list-content-input.js'; import { NEW_BLOCK_ADD, NEW_BLOCK_ADD_2 } from '../specs/new-block-add.js'; import { SECTION_CHILDREN } from '../specs/section-children.js'; @@ -654,7 +654,7 @@ test.describe('Visual Editing', () => { await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); - const newContent = cloneContent(NESTED_SYMBOL_CONTENT); + const newContent = cloneContent(SYMBOLS_WITH_LIST_CONTENT_INPUT); await sendPatchOrUpdateMessage({ page, diff --git a/packages/sdks-tests/src/specs/index.ts b/packages/sdks-tests/src/specs/index.ts index c877f370215..aa712665511 100644 --- a/packages/sdks-tests/src/specs/index.ts +++ b/packages/sdks-tests/src/specs/index.ts @@ -89,7 +89,7 @@ import { DYNAMIC_ELEMENT } from './dynamic-element.js'; import { CUSTOM_CODE_DOM_UPDATE } from './custom-code-dom-update.js'; import { NEW_BLOCK_ADD } from './new-block-add.js'; import { DYNAMIC_BUTTON } from './dynamic-button.js'; -import { NESTED_SYMBOL_CONTENT } from './nested-symbol.js'; +import { SYMBOLS_WITH_LIST_CONTENT_INPUT } from './symbols-with-list-content-input.js'; import { COLUMNS_VERTICAL_CENTERING } from './columns-vertical-centering.js'; import { SECTION_CHILDREN } from './section-children.js'; @@ -140,7 +140,7 @@ export const PAGES: Record = { '/image-high-priority': { content: imageHighPriority }, '/image-no-webp': { content: imageNoWebp }, '/data-bindings': { content: dataBindings }, - '/nested-symbol': { content: NESTED_SYMBOL_CONTENT }, + '/symbols-with-list-content-input': { content: SYMBOLS_WITH_LIST_CONTENT_INPUT }, '/data-binding-styles': { content: dataBindingStyles }, '/react-native-strict-style-mode': { content: REACT_NATIVE_STRICT_STYLE_MODE_CONTENT }, '/react-native-strict-style-mode-disabled': { content: REACT_NATIVE_STRICT_STYLE_MODE_CONTENT }, diff --git a/packages/sdks-tests/src/specs/nested-symbol.ts b/packages/sdks-tests/src/specs/symbols-with-list-content-input.ts similarity index 99% rename from packages/sdks-tests/src/specs/nested-symbol.ts rename to packages/sdks-tests/src/specs/symbols-with-list-content-input.ts index ed902ac0766..e60b5074a1f 100644 --- a/packages/sdks-tests/src/specs/nested-symbol.ts +++ b/packages/sdks-tests/src/specs/symbols-with-list-content-input.ts @@ -1,4 +1,4 @@ -export const NESTED_SYMBOL_CONTENT = { +export const SYMBOLS_WITH_LIST_CONTENT_INPUT = { data: { title: 'react-sdk', themeId: false, From c328f88d8966f4ec2cf8947375cba7e743a572ce Mon Sep 17 00:00:00 2001 From: yash-builder Date: Tue, 25 Mar 2025 19:58:27 +0530 Subject: [PATCH 08/11] fix: update the path --- packages/sdks-tests/src/e2e-tests/editing.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 7d0b4123de7..3804e19688d 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -652,7 +652,7 @@ test.describe('Visual Editing', () => { test.skip(excludeGen1(sdk)); test.skip(packageName === 'nextjs-sdk-next-app'); - await launchEmbedderAndWaitForSdk({ path: '/nested-symbol', basePort, page, sdk }); + await launchEmbedderAndWaitForSdk({ path: '/symbols-with-list-content-input', basePort, page, sdk }); const newContent = cloneContent(SYMBOLS_WITH_LIST_CONTENT_INPUT); From 541eb106c13924739a319b7c56e35ae46fe0ab71 Mon Sep 17 00:00:00 2001 From: yash-builder Date: Thu, 27 Mar 2025 09:01:23 +0530 Subject: [PATCH 09/11] note: skipping test for qwik. need to address this issue in different PR --- packages/sdks-tests/src/e2e-tests/editing.spec.ts | 4 ++-- packages/sdks/src/components/block/block.helpers.ts | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/sdks-tests/src/e2e-tests/editing.spec.ts b/packages/sdks-tests/src/e2e-tests/editing.spec.ts index 3804e19688d..47ee5584205 100644 --- a/packages/sdks-tests/src/e2e-tests/editing.spec.ts +++ b/packages/sdks-tests/src/e2e-tests/editing.spec.ts @@ -649,8 +649,8 @@ test.describe('Visual Editing', () => { test('Symbol should update the data when nested values are updated', async ({ page, basePort, sdk, packageName }) => { - test.skip(excludeGen1(sdk)); - test.skip(packageName === 'nextjs-sdk-next-app'); + test.skip(sdk === 'qwik', 'Qwik fails to update the data when nested values are updated. Need to raise another PR.'); + test.skip(excludeGen1(sdk) || packageName === 'nextjs-sdk-next-app'); await launchEmbedderAndWaitForSdk({ path: '/symbols-with-list-content-input', basePort, page, sdk }); diff --git a/packages/sdks/src/components/block/block.helpers.ts b/packages/sdks/src/components/block/block.helpers.ts index b635d0a7c5c..1691a411679 100644 --- a/packages/sdks/src/components/block/block.helpers.ts +++ b/packages/sdks/src/components/block/block.helpers.ts @@ -163,8 +163,6 @@ export const provideBuilderContext = ( }; export const generateKey = (index: number) => { - if (TARGET === 'qwik') { - return `${index}-${Date.now()}`; - } + //This does not handle the case in Qwik return index.toString(); }; From eaffc00028a482ae26752a72a9cab499affad7e1 Mon Sep 17 00:00:00 2001 From: yash-builder Date: Thu, 27 Mar 2025 11:03:34 +0530 Subject: [PATCH 10/11] fix: lint issues --- packages/sdks/src/components/block/block.helpers.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/sdks/src/components/block/block.helpers.ts b/packages/sdks/src/components/block/block.helpers.ts index 1691a411679..09a2007725c 100644 --- a/packages/sdks/src/components/block/block.helpers.ts +++ b/packages/sdks/src/components/block/block.helpers.ts @@ -9,7 +9,6 @@ import { extractTextStyles } from '../../functions/extract-text-styles.js'; import { getStyle } from '../../functions/get-style.js'; import type { BuilderBlock } from '../../types/builder-block.js'; import type { RepeatData } from './types.js'; -import { TARGET } from '../../constants/target.js'; const checkIsComponentRestricted = ( component: RegisteredComponent | null | undefined, From c1ae957a1dbfae5884a0553350453e55c3b08bd3 Mon Sep 17 00:00:00 2001 From: Yash Wadhia <188822535+yash-builder@users.noreply.github.com> Date: Thu, 27 Mar 2025 18:15:23 +0530 Subject: [PATCH 11/11] Update .changeset/short-poets-reflect.md Co-authored-by: Sidharth Mohanty --- .changeset/short-poets-reflect.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.changeset/short-poets-reflect.md b/.changeset/short-poets-reflect.md index 76676a1a001..a773a2411e1 100644 --- a/.changeset/short-poets-reflect.md +++ b/.changeset/short-poets-reflect.md @@ -1,7 +1,6 @@ --- "@builder.io/sdk-angular": patch "@builder.io/sdk-react-nextjs": patch -"@builder.io/sdk-qwik": patch "@builder.io/sdk-react": patch "@builder.io/sdk-react-native": patch "@builder.io/sdk-solid": patch