chore: finalize link dedupe and bid comment display updates

Author: dan13ram

packages/auction-ui/src/components/AllBids/BidCard.tsx

@@ -7,9 +7,10 @@ import React from 'react'
 
 export const BidCard = ({ bid }: { bid: AuctionBidFragment }) => {
   const { displayName, ensAvatar } = useEnsData(bid?.bidder)
+  const comment = bid.comment?.trim()
 
   return (
-    <Flex direction={'column'} my="x4" align="center" style={{ height: 35 }}>
+    <Flex direction={'column'} my="x4" align="center">
       <Flex direction="row" width={'100%'} align="center" justify="space-between">
         <Flex direction="row" align="center">
           <Avatar address={bid.bidder} src={ensAvatar} size="28" />
@@ -31,6 +32,17 @@ export const BidCard = ({ bid }: { bid: AuctionBidFragment }) => {
           </Flex>
         </Flex>
       </Flex>
+      {comment ? (
+        <Box mt="x2" width="100%">
+          <Text
+            variant="paragraph-sm"
+            color="secondary"
+            style={{ wordBreak: 'break-word' }}
+          >
+            {comment}
+          </Text>
+        </Box>
+      ) : null}
       <Box
         mt="x2"
         style={{

packages/auction-ui/src/components/CurrentAuction/RecentBids.tsx

@@ -15,28 +15,41 @@ export const RecentBids: React.FC<RecentBidsProps> = ({ bids }) => {
   return bids.length ? (
     <Box mt="x3">
       <Stack>
-        {bids.slice(0, 3).map(({ amount, bidder, id }) => (
+        {bids.slice(0, 3).map(({ amount, bidder, id, comment }) => (
           <Flex
+            direction="column"
             align="center"
             py="x2"
-            justify="space-between"
             key={`${bidder}_${amount}_${id}`}
             className={recentBid}
           >
-            <Bidder address={bidder} />
+            <Flex align="center" justify="space-between" width="100%">
+              <Bidder address={bidder} />
 
-            <Flex
-              align="center"
-              as="a"
-              href={`/profile/${bidder}`}
-              target="_blank"
-              rel="noopener noreferrer"
-            >
-              <Text mr="x2" variant="paragraph-md" color="tertiary">
-                {amount} ETH
-              </Text>
-              <Icon id="external-16" fill="text4" size="sm" align={'center'} />
+              <Flex
+                align="center"
+                as="a"
+                href={`/profile/${bidder}`}
+                target="_blank"
+                rel="noopener noreferrer"
+              >
+                <Text mr="x2" variant="paragraph-md" color="tertiary">
+                  {amount} ETH
+                </Text>
+                <Icon id="external-16" fill="text4" size="sm" align={'center'} />
+              </Flex>
             </Flex>
+
+            {comment?.trim() ? (
+              <Text
+                mt="x2"
+                variant="paragraph-sm"
+                color="secondary"
+                style={{ width: '100%', wordBreak: 'break-word' }}
+              >
+                {comment.trim()}
+              </Text>
+            ) : null}
           </Flex>
         ))}
         <Flex mt="x4" align="center" justify="center" className={recentBid}>

packages/constants/src/subgraph.ts

@@ -11,7 +11,7 @@ const createSubgraphUrl = (name: string, version = VERSION): string =>
 
 export const PUBLIC_SUBGRAPH_URL: Map<CHAIN_ID, string> = new Map([
   [CHAIN_ID.ETHEREUM, createSubgraphUrl('nouns-builder-ethereum-mainnet')],
-  [CHAIN_ID.SEPOLIA, createSubgraphUrl('nouns-builder-ethereum-sepolia')],
+  [CHAIN_ID.SEPOLIA, createSubgraphUrl('nouns-builder-ethereum-sepolia', '0.1.16')],
   [CHAIN_ID.OPTIMISM, createSubgraphUrl('nouns-builder-optimism-mainnet')],
   [CHAIN_ID.OPTIMISM_SEPOLIA, createSubgraphUrl('nouns-builder-optimism-sepolia')],
   [CHAIN_ID.BASE, createSubgraphUrl('nouns-builder-base-mainnet')],

packages/dao-ui/src/components/About/ExternalLinks.tsx

@@ -47,6 +47,9 @@ const normalizeLinkKey = (key: string): string => {
   return normalized === 'twitter' ? 'x' : normalized
 }
 
+const normalizeUrlForDedupe = (url: string): string =>
+  url.trim().replace(/\/+$/, '').toLowerCase()
+
 const getIconForLinkKey = (key: string): IconType => {
   if (key === 'x') return 'twitter'
   if (key === 'discord') return 'discord'
@@ -62,14 +65,18 @@ export const ExternalLinks: React.FC<ExternalLinksProps> = ({ links }) => {
   const normalizedLinks = React.useMemo(() => {
     const entries = Object.entries(links || {})
     const next: Record<string, string> = {}
+    const usedUrls: Record<string, boolean> = {}
 
     for (const [rawKey, rawUrl] of entries) {
       const key = normalizeLinkKey(rawKey)
       const url = rawUrl?.trim?.() || ''
+      const normalizedUrl = normalizeUrlForDedupe(url)
 
       if (!key || !url) continue
+      if (usedUrls[normalizedUrl]) continue
       if (!next[key]) {
         next[key] = url
+        usedUrls[normalizedUrl] = true
       }
     }
 

packages/dao-ui/src/utils/daoMetadata.ts

@@ -39,28 +39,32 @@ export const parseDaoMetadataString = (
   }
 
   const parseObject = (value: string): Record<string, unknown> | undefined => {
-    try {
-      const parsed = JSON.parse(value) as unknown
+    const candidates = [value]
 
-      if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
-        return parsed as Record<string, unknown>
-      }
+    for (const candidate of candidates) {
+      try {
+        const parsed = JSON.parse(candidate) as unknown
 
-      if (typeof parsed === 'string') {
-        const nestedParsed = JSON.parse(parsed) as unknown
-        if (
-          nestedParsed &&
-          typeof nestedParsed === 'object' &&
-          !Array.isArray(nestedParsed)
-        ) {
-          return nestedParsed as Record<string, unknown>
+        if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
+          return parsed as Record<string, unknown>
         }
-      }
 
-      return undefined
-    } catch {
-      return undefined
+        if (typeof parsed === 'string') {
+          const nestedParsed = JSON.parse(parsed) as unknown
+          if (
+            nestedParsed &&
+            typeof nestedParsed === 'object' &&
+            !Array.isArray(nestedParsed)
+          ) {
+            return nestedParsed as Record<string, unknown>
+          }
+        }
+      } catch {
+        continue
+      }
     }
+
+    return undefined
   }
 
   const parsed = parseObject(raw)

packages/sdk/codegen.yml

@@ -1,6 +1,6 @@
 generates:
   src/subgraph/sdk.generated.ts:
-    schema: 'https://api.goldsky.com/api/public/project_cm33ek8kjx6pz010i2c3w8z25/subgraphs/nouns-builder-base-mainnet/0.1.16/gn'
+    schema: 'https://api.goldsky.com/api/public/project_cm33ek8kjx6pz010i2c3w8z25/subgraphs/nouns-builder-ethereum-sepolia/0.1.16/gn'
     documents: 'src/subgraph/**/*.graphql'
     plugins:
       - typescript