Skip to content

Commit 18ae047

Browse files
author
Jonathan Visser
committed
Add support for PHP 8.5 images
1 parent bc51ef2 commit 18ae047

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎.github/workflows/publish.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ jobs:
1212
- "8.2"
1313
- "8.3"
1414
- "8.4"
15+
- "8.5"
1516
node_version:
1617
- 16
1718
- 18

‎.github/workflows/test.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
integration_test:
77
strategy:
88
matrix:
9-
php_version: [8.1, 8.2, 8.3, 8.4]
9+
php_version: [8.1, 8.2, 8.3, 8.4, 8.5]
1010
testsuite: [general, brancher]
1111
runs-on: ubuntu-latest
1212
steps:
@@ -34,6 +34,7 @@ jobs:
3434
code_quality:
3535
strategy:
3636
matrix:
37+
# PHP 8.5 is not yet compatible with our current version of deployer
3738
php_version: [8.1, 8.2, 8.3, 8.4]
3839
runs-on: ubuntu-latest
3940
steps:

‎ci/build/Dockerfile‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ RUN apt-get install -y --no-install-recommends \
7171
php${PHP_VERSION}-mbstring \
7272
php${PHP_VERSION}-mysql \
7373
php${PHP_VERSION}-odbc \
74-
php${PHP_VERSION}-opcache \
7574
php${PHP_VERSION}-pgsql \
7675
php${PHP_VERSION}-pspell \
7776
php${PHP_VERSION}-readline \
@@ -81,6 +80,11 @@ RUN apt-get install -y --no-install-recommends \
8180
php${PHP_VERSION}-xml \
8281
php${PHP_VERSION}-zip
8382

83+
# Since PHP 8.5 opcache is compiled into PHP itself and no separate package exists
84+
RUN if dpkg --compare-versions "${PHP_VERSION}" lt "8.5"; then \
85+
apt-get install -y --no-install-recommends php${PHP_VERSION}-opcache; \
86+
fi
87+
8488
# Confirm NodeJS & NPM are installed
8589
RUN node -v && npm -v
8690

‎ci/test/run-general.sh‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,17 @@ set -e
44
set -x
55

66
export PHP_VERSION_SHORT=$(echo "${PHP_VERSION:-8.2}" | sed 's/\.//')
7-
if [[ "${PHP_VERSION:-8.2}" == "8.4" ]]; then
7+
if [[ "${PHP_VERSION:-8.2}" == "8.4" || "${PHP_VERSION:-8.2}" == "8.5" ]]; then
88
export IMAGE_OS="bookworm"
99
else
1010
export IMAGE_OS="buster"
1111
fi
1212

1313
if [[ "${PHP_VERSION:-8.2}" == "8.1" ]]; then
1414
export MAGENTO_VERSION="2.4.6-p10"
15+
elif [[ "${PHP_VERSION:-8.2}" == "8.5" ]]; then
16+
# Magento 2.4.9 is the first release compatible with PHP 8.5
17+
export MAGENTO_VERSION="2.4.9"
1518
else
1619
export MAGENTO_VERSION="2.4.8"
1720
fi

0 commit comments

Comments
 (0)