Skip to content

Commit ef17d72

Browse files
authored
Remove unused soilsnow check routine (#694)
# CABLE ## Description The `spec_init_snowcheck` routine was not called anywhere in the CABLE code, nor in its coupled applications. `2026-02-23 17:11:47,253 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed` Fixes #693 ## Type of change - [x] Bug fix ## Checklist - [x] The new content is accessible and located in the appropriate section - [x] I have checked that links are valid and point to the intended content - [x] I have checked my code/text and corrected any misspellings ## Testing - [x] Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--694.org.readthedocs.build/en/694/ <!-- readthedocs-preview cable end -->
1 parent dfafe87 commit ef17d72

1 file changed

Lines changed: 0 additions & 81 deletions

File tree

‎src/science/soilsnow/cbl_soilsnow_init_special.F90‎

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ MODULE cbl_soil_snow_init_special_module
77
PRIVATE
88

99
PUBLIC spec_init_soil_snow
10-
PUBLIC spec_init_snowcheck
1110

1211
CONTAINS
1312

@@ -88,84 +87,4 @@ SUBROUTINE spec_init_soil_snow(dels, soil, ssnow, canopy, met, bal, veg,heat_cap
8887

8988
END SUBROUTINE spec_init_soil_snow
9089

91-
SUBROUTINE spec_init_snowcheck(dels, ssnow, soil, met )
92-
93-
USE cable_common_module
94-
95-
REAL, INTENT(IN) :: dels ! integration time step (s)
96-
97-
TYPE(soil_snow_type), INTENT(INOUT) :: ssnow
98-
TYPE(met_type), INTENT(INOUT) :: met ! all met forcing
99-
100-
TYPE(soil_parameter_type), INTENT(INOUT) :: soil ! soil parameters
101-
102-
INTEGER :: k,j
103-
104-
105-
DO j=1,mp
106-
107-
IF( ssnow%snowd(j) <= 0.0 ) THEN
108-
!H!ssnow%isflag(j) = 0
109-
!H!ssnow%ssdn(j,:) = 120.0
110-
!H!ssnow%ssdnn(j) = 120.0
111-
!H!ssnow%tggsn(j,:) = CTFRZ
112-
!H!ssnow%sdepth(j,1) = ssnow%snowd(j) / ssnow%ssdn(j,1)
113-
!H!ssnow%sdepth(j,2) = 0.
114-
!H!ssnow%sdepth(j,3) = 0.
115-
!H!ssnow%smass(j,1) = ssnow%snowd(j)
116-
!H!ssnow%smass(j,2) = 0.0 ! EK to fix -ve sdepth 21Dec2007
117-
!H!ssnow%smass(j,3) = 0.0 ! EK to fix -ve sdepth 21Dec2007
118-
ELSEIF( ssnow%snowd(j) < snmin * ssnow%ssdnn(j) ) THEN
119-
!H!IF( ssnow%isflag(j) == 1 ) THEN
120-
!H! ssnow%ssdn(j,1) = ssnow%ssdnn(j)
121-
!H! ssnow%tgg(j,1) = ssnow%tggsn(j,1)
122-
!H!ENDIF
123-
!H!ssnow%isflag(j) = 0
124-
!H!ssnow%ssdnn(j) = MIN( 400.0, MAX( 120.0, ssnow%ssdn(j,1) ) )
125-
!H!ssnow%tggsn(j,:) = MIN( CTFRZ,ssnow%tgg(j,1) )
126-
!H!ssnow%sdepth(j,1) = ssnow%snowd(j) / ssnow%ssdn(j,1)
127-
!H!ssnow%sdepth(j,2) = 0.0
128-
!H!ssnow%sdepth(j,3) = 0.0
129-
!H!ssnow%smass(j,1) = ssnow%snowd(j)
130-
!H!ssnow%smass(j,2) = 0.0
131-
!H!ssnow%smass(j,3) = 0.0
132-
!H!ssnow%ssdn(j,:) = ssnow%ssdnn(j)
133-
134-
IF( (cable_user%soilsnow_init_spec ) ) THEN
135-
IF( soil%isoilm(j) == 9 .AND. ktau_gl <= 2 ) &
136-
! permanent ice: fixed hard-wired number in next version
137-
ssnow%ssdnn(j) = 700.0
138-
ENDIF
139-
140-
ELSE ! in loop: IF( ssnow%snowd(j) <= 0.0 ) THEN
141-
! sufficient snow now for 3 layer snowpack
142-
143-
IF( ssnow%isflag(j) == 0 ) THEN
144-
!H!ssnow%tggsn(j,:) = MIN( CTFRZ, ssnow%tgg(j,1) )
145-
!H!ssnow%ssdn(j,2) = ssnow%ssdn(j,1)
146-
!H!ssnow%ssdn(j,3) = ssnow%ssdn(j,1)
147-
IF( (cable_user%soilsnow_init_spec ) ) THEN
148-
IF( soil%isoilm(j) == 9 .AND. ktau_gl <= 2 ) THEN
149-
! permanent ice: fix hard-wired number in next version
150-
ssnow%ssdn(j,1) = 450.0
151-
ssnow%ssdn(j,2) = 580.0
152-
ssnow%ssdn(j,3) = 600.0
153-
ENDIF
154-
ENDIF
155-
!H!ssnow%sdepth(j,1) = ssnow%t_snwlr(j)
156-
!H!ssnow%smass(j,1) = ssnow%t_snwlr(j) * ssnow%ssdn(j,1)
157-
!H!ssnow%smass(j,2) = ( ssnow%snowd(j) - ssnow%smass(j,1) ) * 0.4
158-
!H!ssnow%smass(j,3) = ( ssnow%snowd(j) - ssnow%smass(j,1) ) * 0.6
159-
!H!ssnow%sdepth(j,2) = ssnow%smass(j,2) / ssnow%ssdn(j,2)
160-
!H!ssnow%sdepth(j,3) = ssnow%smass(j,3) / ssnow%ssdn(j,3)
161-
!H!ssnow%ssdnn(j) = ( ssnow%ssdn(j,1) * ssnow%smass(j,1) + &
162-
!H! ssnow%ssdn(j,2) * ssnow%smass(j,2) + &
163-
!H! ssnow%ssdn(j,3) * ssnow%smass(j,3) ) &
164-
!H! / ssnow%snowd(j)
165-
ENDIF
166-
!H!ssnow%isflag(j) = 1
167-
ENDIF ! END: IF( ssnow%snowd(j) <= 0.0 ) THEN
168-
ENDDO ! END: DO j=1,mp
169-
170-
END SUBROUTINE spec_init_snowcheck
17190
END MODULE cbl_soil_snow_init_special_module

0 commit comments

Comments
 (0)