Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem while reading bookmark from safari #1

Open
alexisparis opened this issue Feb 23, 2018 · 2 comments
Open

problem while reading bookmark from safari #1

alexisparis opened this issue Feb 23, 2018 · 2 comments
Assignees

Comments

@alexisparis
Copy link

Hello,

It seems we have something special with bookmarks from safari.
When I try readFromHTMLFile on such file, I get :

Error: There are errors in your xml file: not well-formed (invalid token)
at Object.module.exports [as toJson] (/Users/para042/linkguardian/html2links/node_modules/xml2json/lib/xml2json.js:172:15)
at eachLine (/Users/para042/linkguardian/html2links/node_modules/bookmark-parser/lib/bookmark_parser/html_parser.js:50:39)
at /Users/para042/linkguardian/html2links/node_modules/line-reader/lib/line_reader.js:279:15
at getLine (/Users/para042/linkguardian/html2links/node_modules/line-reader/lib/line_reader.js:166:7)
at Object.nextLine (/Users/para042/linkguardian/html2links/node_modules/line-reader/lib/line_reader.js:183:7)
at Immediate.readNext [as _onImmediate] (/Users/para042/linkguardian/html2links/node_modules/line-reader/lib/line_reader.js:269:14)
at runCallback (timers.js:789:20)
at tryOnImmediate (timers.js:751:5)
at processImmediate [as _immediateCallback] (timers.js:722:5)

Safari Bookmarks.txt

@alexisparis
Copy link
Author

alexisparis commented Feb 23, 2018

seems related to the fact that safari generate folder like :
<DT><H3 FOLDED>Favorites</H3>

with FOLDED attribute without value

@CCharlieLi
Copy link
Owner

Thanks @alexisparis , good catch. Maybe it's time to make it work on Safari bookmark, I'll do some investigations and any pull request is welcome.

@CCharlieLi CCharlieLi self-assigned this Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants