You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add validation that true_match_threshold is less than the sum of the evaluator field log odds
Add good descriptive docstrings to describe the new values in the API docs
Remove kwargs information from site/reference.md
Test cases for all of the above
Details / Tasks
Use the snippet below as a basis for the additions that should be made to account for the deletion of the kwargs attribute. Note, specific require Algorithm/AlgorithmPass attributes have been omitted and replaced with ... as to highlight the additions that are being made.
kwargs is too vague and doesn't allow for the validation that we'd like when parsing changes to an Algorithm. Creating independent fields for the values we are trying to capture allows for those changes.
Notes / Comments
This will be a breaking change, and will need to be documented in our release notes accordingly. Specifically, we'll need to state that the algorithm and algorithm pass tables need to be deleted before upgrading to this release.
The text was updated successfully, but these errors were encountered:
Summary
Remove the
AlgorithmPass.kwargs
field and replace it with specific fields for fuzzy matching and log odds parameters.Acceptance Criteria
log_odds
to Algorithm in schema/algorithm.py and models/algorithm.pyfuzzy_match_threshold
to Algorithm in schema/algorithm.py and models/algorithm.pyfuzzy_match_measure
to Algorithm in schema/algorithm.py and models/algorithm.pyfuzzy_match_threshold
to AlgorithmPass.evaluators in schema/algorithm.py and models/algorithm.pyfuzzy_match_measure
to AlgorithmPass.evaluators in schema/algorithm.py and models/algorithm.pytrue_match_threshold
to AlgorithmPass in schema/algorithm.py and models/algorithm.pykwargs
from AlgorithmPass in schema/algorithm.py and models/algorithm.pyDetails / Tasks
Use the snippet below as a basis for the additions that should be made to account for the deletion of the
kwargs
attribute. Note, specific require Algorithm/AlgorithmPass attributes have been omitted and replaced with...
as to highlight the additions that are being made.Background / Context
kwargs is too vague and doesn't allow for the validation that we'd like when parsing changes to an Algorithm. Creating independent fields for the values we are trying to capture allows for those changes.
Notes / Comments
This will be a breaking change, and will need to be documented in our release notes accordingly. Specifically, we'll need to state that the algorithm and algorithm pass tables need to be deleted before upgrading to this release.
The text was updated successfully, but these errors were encountered: