From 3d2fd28beeadf781aa41712ebb851f2a52f0fdf1 Mon Sep 17 00:00:00 2001 From: Yuqi Zhang <35361994+yuz796@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:18:03 -0500 Subject: [PATCH 1/3] Update README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index aa0f112..e53584e 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,8 @@ # lab06-debugging +# Group +Yuqi Zhang, Dongying Liu, Wenqing Wang + # Setup Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc). @@ -11,6 +14,11 @@ It don't do that. Correct THREE of the FIVE bugs that are messing up the output. Extra credit if you can find all FIVE bugs. +1 . https://www.shadertoy.com/view/ddS3zt +I find the bug that it should be vec2 uv2 = 2.0 * uv - vec2(1.0); I need a "2" after "uv". I find that bug because it has a compile error that pointing to this spot. + + + # Submission - Create a pull request to this repository - In the README, include the names of both your team members From dc2689249a6a57d238a7ba2c100aba506ef6e451 Mon Sep 17 00:00:00 2001 From: Yuqi Zhang <35361994+yuz796@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:23:12 -0500 Subject: [PATCH 2/3] Update README.md --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e53584e..5e5203e 100644 --- a/README.md +++ b/README.md @@ -15,8 +15,12 @@ It don't do that. Correct THREE of the FIVE bugs that are messing up the output. Extra credit if you can find all FIVE bugs. 1 . https://www.shadertoy.com/view/ddS3zt -I find the bug that it should be vec2 uv2 = 2.0 * uv - vec2(1.0); I need a "2" after "uv". I find that bug because it has a compile error that pointing to this spot. +I find the bug that it should be vec2 uv2 = 2.0 * uv - vec2(1.0); I need a "2" after "vec". I find that bug because it has a compile error that pointing to this spot. +2. https://www.shadertoy.com/view/ddB3zt +I find the bug that I should pass the uv2 to the raycast function. I find that bug because I find the camera position is not right. I checked the iResolution and find that is correct. I checked raycast function and the input of the raycast. I find that I need to pass the uv2 instead of uv. + +3. # Submission From 807dbb083909c7b9c56671b25aeec2a972384608 Mon Sep 17 00:00:00 2001 From: Yuqi Zhang <35361994+yuz796@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:36:18 -0500 Subject: [PATCH 3/3] Update README.md --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 5e5203e..7bb794f 100644 --- a/README.md +++ b/README.md @@ -20,9 +20,14 @@ I find the bug that it should be vec2 uv2 = 2.0 * uv - vec2(1.0); I need a "2" a 2. https://www.shadertoy.com/view/ddB3zt I find the bug that I should pass the uv2 to the raycast function. I find that bug because I find the camera position is not right. I checked the iResolution and find that is correct. I checked raycast function and the input of the raycast. I find that I need to pass the uv2 instead of uv. -3. +3. https://www.shadertoy.com/view/msB3zt +The sphere is not look correct. It looks like Ellipsoid at this point. I find the bug that in raycast function, When we calculating the H vec, we should use iResolution.x / iResolution.y instead of iResolution.x / iResolution.x. +4. https://www.shadertoy.com/view/msSGRd +In the scene, my teammate noticed that there is a gap between the sphere and the background. We checked again the march function and we noticed that the iteration happens 64 times. We increased the iteration number and fixed this bug. +5. https://www.shadertoy.com/view/ddBGRd +We noticed the specular problem not solved, we checked the line 74 because there is a comment that Specular reflection applied to all surfaces. We checked the specular function, we should pass in the dir, the vector, instead of eye, the eye position. # Submission - Create a pull request to this repository - In the README, include the names of both your team members