From add26e17841a703d41dd66686e5051567e9412ec Mon Sep 17 00:00:00 2001 From: logancho <72320867+logancho@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:00:19 -0500 Subject: [PATCH 1/5] Update README.md --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index aa0f112..7e44d2a 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,7 @@ +Bug number 1: + +Spheres look deformed. Cause: aspect ratio was incorrect in the projection part of the raycast function! + # lab06-debugging # Setup From 95ade4102d182eea85deb22cbc1dba2b3ed83c5d Mon Sep 17 00:00:00 2001 From: logancho <72320867+logancho@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:09:10 -0500 Subject: [PATCH 2/5] Update README.md --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 7e44d2a..193a7be 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,10 @@ Bug number 1: Spheres look deformed. Cause: aspect ratio was incorrect in the projection part of the raycast function! +Bug number 2: + +Spheres are off center, rotation is weird. Cause: Incorrect uv coordinates sent! We calculated NDC uv2, but never actually inputted it into the raycast function. This would explain the offset. + # lab06-debugging # Setup From a4bafc4f9ee93df3b5bfe84a4f15c969dd0e5a4c Mon Sep 17 00:00:00 2001 From: logancho <72320867+logancho@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:13:59 -0500 Subject: [PATCH 3/5] Update README.md --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 193a7be..adc652e 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,10 @@ Bug number 2: Spheres are off center, rotation is weird. Cause: Incorrect uv coordinates sent! We calculated NDC uv2, but never actually inputted it into the raycast function. This would explain the offset. +Bug number 3: + +Specular reflection missing. I knew that the bug would have to be inside sdf3d. It turns out we were reflecting eye instead of dir! Replacing eye with dir fixed this bug. + # lab06-debugging # Setup From 541a304acf2b34498be927f2fbb2061d5ceaa9e1 Mon Sep 17 00:00:00 2001 From: logancho <72320867+logancho@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:34:02 -0500 Subject: [PATCH 4/5] Update README.md --- README.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/README.md b/README.md index adc652e..6286b3e 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,9 @@ +Submission: + +https://www.shadertoy.com/view/msBGzt + +Collaborators: None + Bug number 1: Spheres look deformed. Cause: aspect ratio was incorrect in the projection part of the raycast function! @@ -10,6 +16,14 @@ Bug number 3: Specular reflection missing. I knew that the bug would have to be inside sdf3d. It turns out we were reflecting eye instead of dir! Replacing eye with dir fixed this bug. +Bug number 0: + +Compiler error- fixed by adding type declaration vec2 to uv2! + +Bug number 5: + +Fixed floor artifacts by increasing number of iterations of march! + # lab06-debugging # Setup From 80811535516c420554e011a23cc870bb548a6a34 Mon Sep 17 00:00:00 2001 From: logancho <72320867+logancho@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:37:22 -0500 Subject: [PATCH 5/5] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6286b3e..ec8c7ea 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ Compiler error- fixed by adding type declaration vec2 to uv2! Bug number 5: -Fixed floor artifacts by increasing number of iterations of march! +Fixed floor artifacts by increasing number of iterations of march! This issue happens to rays that get very close but dont actually intersect objects in sphere tracing, since many iterations are used up by very small increments forward, resulting in no intersection if the number of iterations isnt high enough. # lab06-debugging