From 4c4da2162718dfb25c51a0694ca209e6c02892d0 Mon Sep 17 00:00:00 2001 From: Rhuta Joshi <35020308+rcj9719@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:46:25 -0500 Subject: [PATCH 1/2] Update README.md --- README.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/README.md b/README.md index aa0f112..4ec5e49 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,21 @@ It don't do that. Correct THREE of the FIVE bugs that are messing up the output. Extra credit if you can find all FIVE bugs. +# Solution + +### Team members: Joanna Fisch, Rhuta Joshi + +### Bugs: + +|Line No.|Artifact/Issue|Correction| +|---|---|---| +|99|Compile time error, vec not found| Replaced vec with vec2| +|102|Made the image appear flat or with incorrect resolution|Passed remapped uv2 instead of uv to rayCast function| +|11|Everything appeared stretched along x axis|`iResolution.x/iResolution.x` replaced with `iResolution.x/iResolution.y`| +|76|Reflection not working, spheres looked flat shaded|Was reflecting eye about normal instead of dir about normal| +|18|Disappearing floor plane around edges of spheres|Very small value of max ray steps, updated from 64 to 256| + + # Submission - Create a pull request to this repository - In the README, include the names of both your team members From f79cb356d5e6f4ea60816d0f352559eceb8cd36b Mon Sep 17 00:00:00 2001 From: Rhuta Joshi <35020308+rcj9719@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:48:00 -0500 Subject: [PATCH 2/2] Update README.md --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 4ec5e49..32dc91c 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Extra credit if you can find all FIVE bugs. ### Bugs: -|Line No.|Artifact/Issue|Correction| +|Line No.|Artifact/Issue that helped in identification|Correction| |---|---|---| |99|Compile time error, vec not found| Replaced vec with vec2| |102|Made the image appear flat or with incorrect resolution|Passed remapped uv2 instead of uv to rayCast function| @@ -25,6 +25,7 @@ Extra credit if you can find all FIVE bugs. |76|Reflection not working, spheres looked flat shaded|Was reflecting eye about normal instead of dir about normal| |18|Disappearing floor plane around edges of spheres|Very small value of max ray steps, updated from 64 to 256| +[Corrected shadertoy link](https://www.shadertoy.com/view/msBGRd) # Submission - Create a pull request to this repository