From d1b95caa90e7eb35de6cda90896532db86585aa2 Mon Sep 17 00:00:00 2001 From: Wayne Wu <77313916+wayne-wu@users.noreply.github.com> Date: Wed, 9 Nov 2022 11:51:32 -0500 Subject: [PATCH] Update README.md --- README.md | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index aa0f112..e9a5e30 100644 --- a/README.md +++ b/README.md @@ -1,19 +1,12 @@ # lab06-debugging -# Setup +Team members: +Wayne Wu, Leo Liang -Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc). +[Shader Toy](https://www.shadertoy.com/view/mdSGRt#) -Let's practice debugging! We have a broken shader. It should produce output that looks like this: -[Unbelievably beautiful shader](https://user-images.githubusercontent.com/1758825/200729570-8e10a37a-345d-4aff-8eff-6baf54a32a40.webm) -It don't do that. Correct THREE of the FIVE bugs that are messing up the output. You are STRONGLY ENCOURAGED to work with a partner and pair program to force you to talk about your debugging thought process out loud. - -Extra credit if you can find all FIVE bugs. - -# Submission -- Create a pull request to this repository -- In the README, include the names of both your team members -- In the README, create a link to your shader toy solution with the bugs corrected -- In the README, describe each bug you found and include a sentence about HOW you found it. -- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!) +* Bug 1: Syntax error (vec should be vec2) -> found the bug by compiling +* Bug 2: uv should be uv2 -> found this by reading the code +* Bug 3: glm::reflect should be normalized -> found this by going to stack overflow and looking at reflect example +* Bug 4: eye in glm reflect should be the incident ray -> found this by asking Adam