From 6c24f72b01b0c3bc14892218cd0d50ff89089318 Mon Sep 17 00:00:00 2001 From: sherryli02 <97941858+sherryli02@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:36:25 -0400 Subject: [PATCH 1/2] Update README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index aa0f112..bf73794 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,13 @@ # lab06-debugging +Link to solution with bugs corrected: https://www.shadertoy.com/view/Ds3czj + +1. Line 97: Changed vec to vec2; console was displaying a syntax error +2. Line 100: Changed uv to uv2. I noticed that uv2 wasn't being used +3. Line 11: Changed the second iResolution.x to iResolution.y. Spotted since it was strange to multiply and divide by the same variable +4. Line 75: Changed eye to dir in the reflect inputs. Knew there was an issue with the specular since the reflections weren't showing, and thought it made more sense to pass in dir than eye +5. Line 18: Made i loop for a larger number of iterations. Saw that the back plane wasn't as far as the desired output, so thought to make it march for more steps + # Setup Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc). From a1c784ffebb8df8c2cb0006cf8f7d94ba1a528a0 Mon Sep 17 00:00:00 2001 From: sherryli02 <97941858+sherryli02@users.noreply.github.com> Date: Wed, 20 Sep 2023 11:38:24 -0400 Subject: [PATCH 2/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bf73794..b5deb90 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Link to solution with bugs corrected: https://www.shadertoy.com/view/Ds3czj 2. Line 100: Changed uv to uv2. I noticed that uv2 wasn't being used 3. Line 11: Changed the second iResolution.x to iResolution.y. Spotted since it was strange to multiply and divide by the same variable 4. Line 75: Changed eye to dir in the reflect inputs. Knew there was an issue with the specular since the reflections weren't showing, and thought it made more sense to pass in dir than eye -5. Line 18: Made i loop for a larger number of iterations. Saw that the back plane wasn't as far as the desired output, so thought to make it march for more steps +5. Line 18: Made i loop for a larger number of iterations. Saw that the back "clipping plane" wasn't as far as the desired output, so thought to make it march for more steps # Setup