-
Notifications
You must be signed in to change notification settings - Fork 26
Update the Docker image and CircleCI build image Java version #3414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Java version (25 and 21, respectively)
.circleci/config.yml
Outdated
| clojure: | ||
| docker: | ||
| - image: cimg/clojure:1.11.1-browsers | ||
| - image: cimg/clojure:1.11-openjdk-21.0-browsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we jump to 1.12 series already?
| # For documentation see docs/installing-upgrading.md | ||
|
|
||
| FROM eclipse-temurin:17-jre-alpine | ||
| FROM eclipse-temurin:25-jre-alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also help with #3416.
Macroz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough to merge already but I'd like to try Clojure 1.12 images as they seem to be available too. So cimg/clojure:1.12.0-openjdk-21.0-browsers.
|
Only flaky test fail. Let's merge to get to release. |
Update the Docker image and CircleCI build image Java version to latest available (25 and 21, respectively)
Fixed some subsequent errors in the ci pipeline and browser tests
Related issue #3395
Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Backwards compatibility
Documentation
Testing
Follow-up