You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Possible starting point is the old implementation, we just need to port this to the new version. This old version doesn't implement normalization like ScalarExtractor, which would also be desirable in the new version.
As the example shows, we also need to make sure that StableExtractor wrapping works in an expected way.
One important design decision is how to build the extractor tree, because if we replace several ScalarExtractor nodes with only one new VectorizedScalarExtractor, it will have fewer nodes than e.g. the corresponding Schema, making stuff like HierarchicalUtils.jl traversal codes break. On the other hand, such extractor would have the same structure as the resulting model. Test what exactly are the implications here. One possible solution is to add some "ghost nodes" as children of VectorizedScalarExtractor that wouldn't ever be used, but would complete the tree.
The text was updated successfully, but these errors were encountered:
Implement structure
VectorizedScalarExtractor
, with which we could group the following extractor into a single node:This is mainly an optimization.
Corresponding
suggestextractor
rule is already written, but commented out.Possible starting point is the old implementation, we just need to port this to the new version. This old version doesn't implement normalization like
ScalarExtractor
, which would also be desirable in the new version.As the example shows, we also need to make sure that
StableExtractor
wrapping works in an expected way.One important design decision is how to build the extractor tree, because if we replace several
ScalarExtractor
nodes with only one newVectorizedScalarExtractor
, it will have fewer nodes than e.g. the correspondingSchema
, making stuff likeHierarchicalUtils.jl
traversal codes break. On the other hand, such extractor would have the same structure as the resulting model. Test what exactly are the implications here. One possible solution is to add some "ghost nodes" as children ofVectorizedScalarExtractor
that wouldn't ever be used, but would complete the tree.The text was updated successfully, but these errors were encountered: