Bug fix: don't dispatch if the dialog is already closed

robyww · robyww · commit 2b1f62ad91ff · 2024-03-19T18:28:37.000-06:00
diff --git a/src/firefly/js/core/ComponentCntlr.js b/src/firefly/js/core/ComponentCntlr.js
@@ -38,6 +38,7 @@ export function dispatchShowDialog(dialogId,ownerId=undefined) {
 }
 
 export function dispatchHideDialog(dialogId) {
+    if (!isDialogVisible(dialogId)) return;
     flux.process({type: HIDE_DIALOG, payload: {dialogId}});
 }
 

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ export function dispatchShowDialog(dialogId,ownerId=undefined) {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`export function dispatchHideDialog(dialogId) {`
	`41`	`+ if (!isDialogVisible(dialogId)) return;`
`41`	`42`	`flux.process({type: HIDE_DIALOG, payload: {dialogId}});`
`42`	`43`	`}`
`43`	`44`