From d18a3e73e7bffa15c42317a45fd5e7394cb10ef1 Mon Sep 17 00:00:00 2001 From: Efreak Date: Wed, 17 Jul 2013 15:05:23 -0700 Subject: [PATCH 1/8] Allow users to have unrandomized widgets. If the user adds #sorted hash to the end of the url, the games list won't be randomized. They won't be sorted, but they will appear in the same order they're in in the file. This is a silent action--users have to already know about this to use it. Reason: I've had several people PM me on steam complaining that the list is randomized. I see no problem with this, as it helps you find out about different games. However, I can also see it annoying someone looking through the entire list. Since I'm unwilling to make changes that affect things you've done, I've told people to submit an issue if they don't like it. In the meantime, they can use this to not have the list sorted. --- scripts/script.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/script.js b/scripts/script.js index d39552a..12a13c1 100644 --- a/scripts/script.js +++ b/scripts/script.js @@ -9,7 +9,7 @@ $(function() { self.url = 'http://www.humblebundle.com/store/product/' // Shuffle the games - games = _.shuffle(games) + if(window.location.hash != "#unrandomized") games = _.shuffle(games) // Initialized methods self.renderFilters() From f671e07ae5657f8c3e04ed4edd5e217d8a022131 Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 10:47:54 -0700 Subject: [PATCH 2/8] Revert "Allow users to have unrandomized widgets." This reverts commit d18a3e73e7bffa15c42317a45fd5e7394cb10ef1. --- scripts/script.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/script.js b/scripts/script.js index 12a13c1..d39552a 100644 --- a/scripts/script.js +++ b/scripts/script.js @@ -9,7 +9,7 @@ $(function() { self.url = 'http://www.humblebundle.com/store/product/' // Shuffle the games - if(window.location.hash != "#unrandomized") games = _.shuffle(games) + games = _.shuffle(games) // Initialized methods self.renderFilters() From 042caf2b39a350fc79448e5e5f6f3f5becd23531 Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 10:57:32 -0700 Subject: [PATCH 3/8] Remove 'undefined' from notes --- table.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/table.html b/table.html index 197b7c9..837dc7e 100644 --- a/table.html +++ b/table.html @@ -224,6 +224,7 @@

All games from the Humble Store

Review + Notes Developer Description Notes @@ -446,7 +447,8 @@

All games from the Humble Store

var tdnotes = document.createElement('td'); tdnotes.className = 'tdnotes'; - tdnotes.textContent = tr.dataset.notes; + if(returnIfExist(tr.dataset.notes) != null && tr.dataset.notes != "undefined") + tdnotes.textContent = tr.dataset.notes; tr.appendChild(tdnotes); document.getElementById('gametablebody').appendChild(tr) From 567fc664a6391aa8fe4878955c13962f9895c70c Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 11:43:32 -0700 Subject: [PATCH 4/8] Update JSON with timestamp I've added support for a timestamp to be automatically generated in json.html. The column is added to table view, but hidden by default as no games have dates yet. --- json.html | 11 ++++++----- table.html | 23 ++++++++++++++++++++--- 2 files changed, 26 insertions(+), 8 deletions(-) diff --git a/json.html b/json.html index 9d6fc77..527ae16 100644 --- a/json.html +++ b/json.html @@ -1,10 +1,10 @@ - + @@ -223,6 +223,7 @@

All games from the Humble Store

+ Date Added Review Notes Developer @@ -232,6 +233,7 @@

All games from the Humble Store

Toggle: #, Platforms, DRMs, + Date Added, Reviews, Developer, Description, @@ -271,6 +273,7 @@

All games from the Humble Store

tr.dataset.gog = game.drm.GOG tr.dataset.drmfree = game["drm"]["drm-free"] tr.dataset.extras = game.extras + tr.dataset.timestamp = game.timestamp; if(returnIfExist(game.URL) != null) { tr.dataset.reviewurl = returnIfExist(game.URL.review) tr.dataset.devurl = returnIfExist(game.URL.developer) @@ -400,7 +403,21 @@

All games from the Humble Store

tdost.appendChild(tdostbg); tr.appendChild(tdost); - var tdreview = document.createElement('td'); + var tddate = document.createElement('td'); + tddate.className = 'tddate'; + if(tr.dataset.timestamp=="undefined") { + tddate.setAttribute('sorttable_customkey', "1200000000000"); + var datestring = ""; + } else { + tddate.setAttribute('sorttable_customkey', tr.dataset.timestamp); + var date = new Date(parseInt(tr.dataset.timestamp)); + var datestring = ["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"][date.getMonth()]+" " + + date.getDate() + ", " + date.getFullYear(); + } + tddate.textContent = datestring; + tr.appendChild(tddate); + + var tdreview = document.createElement('td'); tdreview.className = 'tdreview'; tdreview.setAttribute('sorttable_customkey', "1"); var tdreviewsearchlink = document.createElement('a'); From 04563048181b44e040a201d8f5ba27ae2aafb00b Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 11:45:17 -0700 Subject: [PATCH 5/8] Change edit link to json.html json.html enforces consistency because it autogenerates. it also has further, more detailed instructions for adding to the file and adds the timestamp automatically. --- table.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/table.html b/table.html index aeee078..6d01805 100644 --- a/table.html +++ b/table.html @@ -207,7 +207,7 @@

Please use the original frame view un

(The game title, developer, and price will still display correctly, but links, DRM, platform, and sorting are broken)










-->

All games from the Humble Store

-

All your games are stored on your Humble Bundle account. Feel free to edit this list.

+

All your games are stored on your Humble Bundle account. Feel free to edit this list.

Original view with frames

From 09387e6fe597842277419a8836aa9a5f95290bb8 Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 11:45:51 -0700 Subject: [PATCH 6/8] Remove commented note from when table view was broken. --- table.html | 5 ----- 1 file changed, 5 deletions(-) diff --git a/table.html b/table.html index 6d01805..fd88547 100644 --- a/table.html +++ b/table.html @@ -201,11 +201,6 @@
-

All games from the Humble Store

All your games are stored on your Humble Bundle account. Feel free to edit this list.

From 4ff089f9ae865246c3e96f9fd278290f7d432464 Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 12:07:58 -0700 Subject: [PATCH 7/8] Always show steam url, even if a key isn't provided Some games have a steam url defined even though the game isn't listed as giving out a key. In this case, show the link as usual, but fade it out and set title to a warning to indicate a key is not provided. --- table.html | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/table.html b/table.html index fd88547..01a8809 100644 --- a/table.html +++ b/table.html @@ -176,6 +176,10 @@ .tdnotes, .tddate { display: none; } + + .tddrmnosteam { + opacity: 0.4; + } @@ -348,10 +352,19 @@

All games from the Humble Store

tddrmsteamlink.href = 'http://store.steampowered.com/search/?ref=os&term='+tr.dataset.game; } var tddrmsteamimg = document.createElement('img'); - tddrmsteamimg.src="images/steam.png" + tddrmsteamimg.src="images/steam.png"; tddrmsteamlink.appendChild(tddrmsteamimg); tddrmsteam.appendChild(tddrmsteamlink); - } + } else if(tr.dataset.steamurl != "undefined" && tr.dataset.steamurl != null) { + var tddrmsteamlink = document.createElement('a'); + tddrmsteamlink.title="So far as we know, this package doesn't provide a steam key. However, it still has a page on steam. Click here to go to "+tr.dataset.game+" on steam"; + tddrmsteamlink.href = tr.dataset.steamurl; + var tddrmsteamimg = document.createElement('img'); + tddrmsteamimg.src="images/steam.png"; + tddrmsteamimg.className="tddrmnosteam"; + tddrmsteamlink.appendChild(tddrmsteamimg); + tddrmsteam.appendChild(tddrmsteamlink); + } tr.appendChild(tddrmsteam); var tddrmdesura = document.createElement('td'); From b20c579c0b702ebbe525b22918dcc9ca85b5367f Mon Sep 17 00:00:00 2001 From: Efreak Date: Sun, 4 Aug 2013 12:16:06 -0700 Subject: [PATCH 8/8] Table View: move options to top, show steam link Moved the options to the top to make them a little more visible. The steam link was commented out. I've re-enabled it as I intend to continue posting updates to the group, though I left it at the bottom as before. --- table.html | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/table.html b/table.html index 01a8809..23db738 100644 --- a/table.html +++ b/table.html @@ -209,6 +209,14 @@

All games from the Humble Store

All your games are stored on your Humble Bundle account. Feel free to edit this list.

Original view with frames

+

Toggle: #   + Platforms   + DRMs   + Date Added   + Reviews   + Developer   + Description   + Notes

@@ -229,16 +237,7 @@

All games from the Humble Store

# Game Description Notes
-

Toggle: #, - Platforms, - DRMs, - Date Added, - Reviews, - Developer, - Description, - Notes.

- - +

Steam group