-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ck2yaml crashes when parsing a third body reaction with PLOG #1165
Comments
Hi @corykinney … thanks for reporting. To date, third-body collision partners are only supported for |
I was afraid that it might not be supported yet. Is there a recommended way to convert mechanisms with these reactions in them, or any plans to support them in the future, @ischoegl? |
Not sure about a recommended way at the moment. From my perspective, adding this capability to 2.6 would make sense (e.g. most likely by allowing third-body collision partners for any reaction type supported by |
@corykinney How does CHEMKIN handle calculating these rates? Does the rate calculation match what you'd expect from the equation, that is, kf*[C4H6]*P/RT ? I'm asking because I wonder why this hasn't been supported. It seems like something that would be fairly trivial to implement in the initial version of the PLOG calculation (in Cantera), so it seems odd to me that it would not be implemented unless this kind of reaction didn't make sense kinetically, and Chemkin's default behavior is to just ignore the |
When I implemented PLOG reactions in Cantera, I believe I checked what Chemkin did if a third body was specified and came to the conclusion that the rate constant is not multiplied by pdep_arrhenius('C4H6 <=> C2H3 + C2H3',
[(0.0394737, 'atm'), 2.344230e+74, -17.69, 140800.0],
[(0.0789474, 'atm'), 2.290870e+74, -17.51, 142100.0],
[(0.157895, 'atm'), 4.365160e+73, -17.13, 142900.0],
[(0.315789, 'atm'), 1.348960e+72, -16.55, 143400.0]) But maybe it's worth checking again to see if Chemkin thinks |
@speth ... interesting. If it's a quirk of CHEMKIN to ignore it, then |
Sorry, I omitted the fact that I had to ignore transport to get the mechanism to convert with |
Ok, great. AramcoMech 3.0 uses both PLOG with and without third-body collision partners, which by itself doesn’t necessarily imply anything. I don’t have a way to check what CHEMKIN does. If it ignores M as in the past, the ‘fix’ would be simple (I’d still advocate for a warning); if M is now considered by CHEMKIN, then |
@ischoegl If there are PLOG reactions both with and without third-body collision partners, to me that would imply, regardless of whether or not CHEMKIN ignores it, that the mechanism authors intend for it to be considered in the reaction. If it's not difficult to add third-body to other reaction types, I think that would be beneficial for improving the capabilities of Cantera, as long as it makes sense kinetically. If for some reason CHEMKIN does ignore it, perhaps there could be a flag on the |
@corykinney ... while it's not difficult to implement, the change also isn't trivial, so I believe that @speth's suggestion to first check what CHEMKIN does here is the best approach. Regarding using inconsistent conventions, AramcoMech 3.0 also uses the PLOG reaction |
There has been some discussion of issues like this in RMG circles in the past, eg. |
@rwest ... thanks for the links! Regarding CHEB, specifying a third body collision partner is currently ignored by Cantera (with a warning being issued in the upcoming 2.6 release - see #1183). While I haven't worked on this, I am under the impression that this behavior is consistent with CHEMKIN? For PLOG, the question on hand is what to do with the third-body collider in AramcoMech 3.0. @alongd: I'd be curious about the current CHEMKIN behavior with an unspecific collider Fwiw, there is a feature request that would allow for alternative third-body reaction types in Cantera/enhancements#133 (at the moment, they're only considered for |
@ischoegl, I'm no longer a Chemkin user, but I can interpret my comment from a few years ago: Chemkin seemed to work fine when specifying a general collider |
Hi @alongd, thanks for weighing in. I'm wondering if you recall what the specific behavior was in any of these cases. That is, If a PLOG reaction is written as And I guess, similar questions for CHEB reactions. |
Hi @speth, my understanding is that a PLOG reaction in Chemkin is written as CHEB reactions are expressed as
This is a bit confusing since I also think that the interpolated rate is not multiplied by As for the difference between I hope I understood the questions correctly, happy to share anything else that I can. |
While I am not a CHEMKIN user, I tried to investigate this issue with ANSYS 2021 R1 Chemkin (I only have access to the graphical interface). Starting with the example
Comparing CSV files, I don't see any difference in output, indicating that the |
@speth ... based on this outcome (I repeated this test twice, just to make sure), I believe there now is the option to just strip the |
Thanks for doing the dirty work of checking Chemkin's behavior in this case, @ischoegl. I think that sounds like a perfectly reasonable resolution, and I'm glad to know that we don't need to support any weird new reaction type. |
Problem description
ck2yaml crashes when parsing a third body reaction with PLOG.
I've tried searching open/closed issues for this, but either I'm searching with the wrong keywords or this is a new issue.
Steps to reproduce
ck2yaml --input="AramcoMech 3.0.MECH" --thermo="AramcoMech 3.0.THERM" --transport="AramcoMech 3.0.TRAN"
System information
The text was updated successfully, but these errors were encountered: