fix: recover completed browser uploads

Author: richiemcilroy

apps/web/actions/video/trigger-processing.ts

@@ -3,9 +3,32 @@
 import { db } from "@cap/database";
 import { getCurrentUser } from "@cap/database/auth/session";
 import { videos } from "@cap/database/schema";
+import { Storage } from "@cap/web-backend";
 import type { Video } from "@cap/web-domain";
 import { eq } from "drizzle-orm";
+import { Effect, Schedule } from "effect";
+import { runPromise } from "@/lib/server";
 import { startVideoProcessingWorkflow } from "@/lib/video-processing";
+import { decodeStorageVideo } from "@/lib/video-storage";
+
+async function verifyRawFileUploaded(
+	video: typeof videos.$inferSelect,
+	rawFileKey: string,
+) {
+	const [bucket] = await Storage.getAccessForVideo(
+		decodeStorageVideo(video),
+	).pipe(runPromise);
+	const head = await bucket
+		.headObject(rawFileKey)
+		.pipe(
+			Effect.retry({ times: 3, schedule: Schedule.exponential("100 millis") }),
+			runPromise,
+		);
+
+	if ((head.ContentLength ?? 0) <= 0) {
+		throw new Error("Uploaded video file is empty");
+	}
+}
 
 export async function triggerVideoProcessing({
 	videoId,
@@ -27,6 +50,8 @@ export async function triggerVideoProcessing({
 	if (!video) throw new Error("Video not found");
 	if (video.ownerId !== user.id) throw new Error("Unauthorized");
 
+	await verifyRawFileUploaded(video, rawFileKey);
+
 	await startVideoProcessingWorkflow({
 		videoId,
 		userId: user.id,

apps/web/app/(org)/dashboard/import/file/ImportFilePage.tsx

@@ -286,8 +286,10 @@ async function uploadVideoForServerProcessing(
 			};
 
 			const getTotal = () => uploadState.total;
+			const didFinishSending = () =>
+				uploadState.total > 0 && uploadState.uploaded >= uploadState.total;
 
-			return { scheduleProgressUpdate, cleanup, getTotal };
+			return { scheduleProgressUpdate, cleanup, getTotal, didFinishSending };
 		};
 
 		const progressTracker = createProgressTracker();
@@ -309,13 +311,20 @@ async function uploadVideoForServerProcessing(
 					progressTracker.scheduleProgressUpdate(loaded, total);
 				},
 			});
-			progressTracker.cleanup();
-			const total = progressTracker.getTotal() || 1;
-			await sendProgressUpdate(uploadId, total, total);
 		} catch (uploadError) {
-			progressTracker.cleanup();
-			throw uploadError;
+			if (!progressTracker.didFinishSending()) {
+				progressTracker.cleanup();
+				throw uploadError;
+			}
+
+			console.warn(
+				"Upload request failed after all bytes were sent; verifying object before processing:",
+				uploadError,
+			);
 		}
+		progressTracker.cleanup();
+		const total = progressTracker.getTotal() || file.size || 1;
+		await sendProgressUpdate(uploadId, total, total);
 
 		setUploadStatus({
 			status: "serverProcessing",