Skip to content

save_samples is shown in the example configs but it isn't supported by the main branch #27

@mikeogezi

Description

@mikeogezi

save_samples: False

save_samples is not supported by the main branch. When in the config, it causes the following error:

Traceback (most recent call last):
  File "/home/ogezi/miniconda3/lib/python3.9/runpy.py", line 188, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/ogezi/miniconda3/lib/python3.9/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/home/ogezi/projects/Freda/relations-encoding/spatial_rl.py", line 135, in <module>
    config = DRLXConfig.load_yaml("configs/ddpo_sd.yml")
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 325, in load_yaml
    return cls.from_dict(config)
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 354, in from_dict
    train=TrainConfig.from_dict(config["train"]),
  File "/home/ogezi/miniconda3/lib/python3.9/site-packages/drlx/configs.py", line 12, in from_dict
    return cls(**cfg)
TypeError: __init__() got an unexpected keyword argument 'save_samples'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions