Move file metadata population to unit test fixtures (#9994)

* Move datacite schema population out of migration stream
* Move pytest fixuture data populator out of test class

Co-authored-by: John Tordoff <>
Co-authored-by: Longze Chen <[email protected]>

Author: Johnetordoff

api_tests/files/views/test_file_metadata_record_detail.py

@@ -11,14 +11,24 @@
     PreprintFactory,
 )
 
+from osf.migrations import ensure_datacite_file_schema
+
+
+@pytest.fixture(autouse=True)
+def datacite_file_schema():
+    return ensure_datacite_file_schema()
+
+
 @pytest.fixture()
 def user():
     return AuthUserFactory()
 
+
 @pytest.fixture()
 def preprint(user):
     return PreprintFactory(creator=user)
 
+
 @pytest.fixture()
 def preprint_record(user, preprint):
     primary_file = preprint.primary_file
@@ -99,6 +109,7 @@ def test_preprint_file_metadata_record(self, app, user, preprint_record, unpubli
         assert res.status_code == 200
         assert res.json['data']['id'] == unpublished_preprint_record._id
 
+
 @pytest.mark.django_db
 class TestFileMetadataRecordUpdate:
 

api_tests/files/views/test_file_metadata_record_download.py

@@ -7,6 +7,14 @@
     ProjectFactory
 )
 
+from osf.migrations import ensure_datacite_file_schema
+
+
+@pytest.fixture(autouse=True)
+def datacite_file_schema():
+    return ensure_datacite_file_schema()
+
+
 @pytest.mark.django_db
 class TestFileMetadataRecordDownload:
 

api_tests/schemas/views/test_file_metadata_schema_detail.py

@@ -6,6 +6,13 @@
     AuthUserFactory,
 )
 
+from osf.migrations import ensure_datacite_file_schema
+
+
+@pytest.fixture(autouse=True)
+def datacite_file_schema():
+    return ensure_datacite_file_schema()
+
 
 @pytest.mark.django_db
 class TestFileMetadataSchemaDetail:

osf/migrations/0136_add_datacite_file_metadata_schema.py

@@ -40,5 +40,4 @@ class Migration(migrations.Migration):
     ]
 
     operations = [
-        migrations.RunPython(add_datacite_schema, remove_datacite_schema)
     ]

osf/migrations/0137_add_fm_record_to_osfstorage_files.py

@@ -54,6 +54,4 @@ class Migration(migrations.Migration):
         ('osf', '0136_add_datacite_file_metadata_schema'),
     ]
 
-    operations = [
-        migrations.RunPython(add_records_to_files_sql, remove_records_from_files),
-    ]
+    operations = []

osf/migrations/__init__.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 import sys
+import json
 import logging
 
 from django.apps import apps
@@ -230,3 +231,18 @@ def ensure_default_storage_region():
             'waterbutler_url': osf_settings.WATERBUTLER_URL
         }
     )
+
+
+def ensure_datacite_file_schema():
+    ''' Test use only '''
+    from osf.models import FileMetadataSchema
+    with open('osf/metadata/schemas/datacite.json') as f:
+        jsonschema = json.load(f)
+    _, created = FileMetadataSchema.objects.get_or_create(
+        _id='datacite',
+        schema_version=1,
+        defaults={
+            'name': 'datacite',
+            'schema': jsonschema
+        }
+    )

osf_tests/test_file_metadata.py

@@ -7,19 +7,27 @@
 from website.settings import DOI_FORMAT, DATACITE_PREFIX
 from website.project.licenses import set_license
 from osf.models import FileMetadataSchema, NodeLicense, NodeLog
+from osf.migrations import ensure_datacite_file_schema
 from osf_tests.factories import ProjectFactory, SubjectFactory, AuthUserFactory
 from osf.utils.permissions import READ
 from api_tests.utils import create_test_file
 
 
+@pytest.fixture(autouse=True)
+def datacite_file_schema():
+    return ensure_datacite_file_schema()
+
+
 @pytest.fixture()
 def node():
     return ProjectFactory()
 
+
 @pytest.fixture()
 def osf_file(node):
     return create_test_file(target=node, user=node.creator)
 
+
 def inject_placeholder_doi(json_data):
     # the OSF cannot currently issue DOIs for a file, which is required for datacite schema validation.
     # Manually add a placeholder in tests for validation until we handle this better.