Fix duplicate and mismatched type NODE_FILE(S)_UPDATED

Author: cslzchen

notifications.yaml

@@ -462,13 +462,6 @@ notification_types:
     template: 'website/templates/file_updated.html.mako'
     tests: ['tests/test_events.py']
 
-  - name: node_file_updated
-    subject: 'File Updated'
-    __docs__: ...
-    object_content_type_model_name: abstractnode
-    template: 'website/templates/file_updated.html.mako'
-    tests: ['tests/test_events.py']
-
   - name: node_institutional_access_request
     subject: 'Institutional Access Request'
     __docs__: ...

osf/models/notification_type.py

@@ -83,8 +83,7 @@ class Type(str, Enum):
         USER_CROSSREF_DOI_PENDING = 'user_crossref_doi_pending'
 
         # Node notifications
-        NODE_FILE_UPDATED = 'node_file_updated'
-        NODE_FILES_UPDATED = 'node_files_updated'
+        NODE_FILE_UPDATED = 'node_files_updated'
         NODE_AFFILIATION_CHANGED = 'node_affiliation_changed'
         NODE_REQUEST_ACCESS_SUBMITTED = 'node_request_access_submitted'
         NODE_REQUEST_ACCESS_DENIED = 'node_request_access_denied'

tests/test_events.py

@@ -309,7 +309,7 @@ def setUp(self):
         self.file_sub = factories.NotificationSubscriptionFactory(
             object_id=self.project.id,
             content_type=ContentType.objects.get_for_model(self.project),
-            notification_type=NotificationType.objects.get(name=NotificationType.Type.NODE_FILES_UPDATED)
+            notification_type=NotificationType.objects.get(name=NotificationType.Type.NODE_FILE_UPDATED)
         )
         self.file_sub.save()
 
@@ -407,7 +407,7 @@ def setUp(self):
         self.file_sub = factories.NotificationSubscriptionFactory(
             object_id=self.project.id,
             content_type=ContentType.objects.get_for_model(self.project),
-            notification_type=NotificationType.objects.get(name=NotificationType.Type.NODE_FILES_UPDATED)
+            notification_type=NotificationType.objects.get(name=NotificationType.Type.NODE_FILE_UPDATED)
         )
         self.file_sub.save()