From 4aab5650d9ffd5b8b1e569a78719fb21be2e508f Mon Sep 17 00:00:00 2001 From: Marco Hutter Date: Tue, 23 Sep 2025 21:47:06 +0200 Subject: [PATCH 1/2] Use proper URLs for import statements --- scripts/build.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/scripts/build.js b/scripts/build.js index 67c3bb3ada32..136e781ee3fc 100644 --- a/scripts/build.js +++ b/scripts/build.js @@ -4,7 +4,7 @@ import { readFile, writeFile } from "node:fs/promises"; import { EOL } from "node:os"; import path from "node:path"; import { finished } from "node:stream/promises"; -import { fileURLToPath } from "node:url"; +import { fileURLToPath, pathToFileURL } from "node:url"; import esbuild from "esbuild"; import { globby } from "globby"; @@ -664,7 +664,7 @@ const externalResolvePlugin = { export async function getSandcastleConfig() { const configPath = "packages/sandcastle/sandcastle.config.js"; const configImportPath = path.join(projectRoot, configPath); - const config = await import(configImportPath); + const config = await import(pathToFileURL(configImportPath)); const options = config.default; return { ...options, @@ -698,7 +698,9 @@ export async function buildSandcastleGallery(includeDevelopment) { __dirname, "../packages/sandcastle/scripts/buildGallery.js", ); - const { buildGalleryList } = await import(buildGalleryScriptPath); + const { buildGalleryList } = await import( + pathToFileURL(buildGalleryScriptPath) + ); await buildGalleryList({ rootDirectory, From 2fcefac82f7f29ecfcebe95552107357d8a1f82c Mon Sep 17 00:00:00 2001 From: jjspace <8007967+jjspace@users.noreply.github.com> Date: Tue, 23 Sep 2025 16:16:23 -0400 Subject: [PATCH 2/2] make sure imports are strings --- scripts/build.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/build.js b/scripts/build.js index 136e781ee3fc..96be550f1f0f 100644 --- a/scripts/build.js +++ b/scripts/build.js @@ -664,7 +664,7 @@ const externalResolvePlugin = { export async function getSandcastleConfig() { const configPath = "packages/sandcastle/sandcastle.config.js"; const configImportPath = path.join(projectRoot, configPath); - const config = await import(pathToFileURL(configImportPath)); + const config = await import(pathToFileURL(configImportPath).href); const options = config.default; return { ...options, @@ -699,7 +699,7 @@ export async function buildSandcastleGallery(includeDevelopment) { "../packages/sandcastle/scripts/buildGallery.js", ); const { buildGalleryList } = await import( - pathToFileURL(buildGalleryScriptPath) + pathToFileURL(buildGalleryScriptPath).href ); await buildGalleryList({