Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch only the root block #48

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: fetch only the root block #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6ae7b
feat: fetch only the root block
bajtos Dec 12, 2023
630bc16
fixup! standard --fix
bajtos Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/spark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ export default class Spark {
statusCode: null
}
const searchParams = new URLSearchParams({
// See https://github.com/filecoin-project/lassie/blob/main/docs/HTTP_SPEC.md#dag-scope-request-query-parameter
// Only the root block at the end of the path is returned after blocks required to verify the specified path segments.
'dag-scope': 'block',
protocols: retrieval.protocol,
providers: retrieval.providerAddress
})
Expand Down
4 changes: 3 additions & 1 deletion test/spark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import Spark from '../lib/spark.js'
import { test } from 'zinnia:test'
import { assertInstanceOf, assertEquals, assertArrayIncludes } from 'zinnia:assert'
import { SPARK_VERSION, MAX_CAR_SIZE } from '../lib/constants.js'
import { SPARK_VERSION } from '../lib/constants.js'

test('getRetrieval', async () => {
const round = {
Expand Down Expand Up @@ -82,6 +82,7 @@ test('fetchCAR', async () => {
assertEquals(requests, [{ url: URL }])
})

/* Disabled as long as we are fetching the top-level block only
test('fetchCAR exceeding MAX_CAR_SIZE', async () => {
const URL = 'url'
const fetch = async url => {
Expand Down Expand Up @@ -110,6 +111,7 @@ test('fetchCAR exceeding MAX_CAR_SIZE', async () => {
assertEquals(stats.carChecksum, null)
assertEquals(stats.statusCode, 200)
})
*/

test('submitRetrieval', async () => {
const requests = []
Expand Down