Skip to content

Commit 93171ad

Browse files
chore(defaults): update (webpack-contrib#375)
1 parent 4ed9c5a commit 93171ad

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+6302
-10290
lines changed

.babelrc

-35
This file was deleted.

.circleci/config.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ canary_tests: &canary_tests
2929
command: npm i --no-save webpack@next
3030
- run:
3131
name: Run Test.
32-
command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test; fi
32+
command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test || true; fi
3333

3434
version: 2
3535
jobs:
@@ -100,9 +100,9 @@ jobs:
100100
name: Submit coverage data to codecov.
101101
command: bash <(curl -s https://codecov.io/bash)
102102
when: on_success
103-
node6-canary:
103+
node8-canary:
104104
docker:
105-
- image: webpackcontrib/circleci-node10:latest
105+
- image: webpackcontrib/circleci-node8:latest
106106
<<: *canary_tests
107107

108108
workflows:
@@ -136,10 +136,10 @@ workflows:
136136
filters:
137137
tags:
138138
only: /.*/
139-
- node6-canary:
139+
- node8-canary:
140140
requires:
141141
- analysis
142142
- node6-latest
143143
filters:
144144
tags:
145-
only: /.*/
145+
only: /.*/

.editorconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ insert_final_newline = true
99
trim_trailing_whitespace = true
1010

1111
[*.md]
12-
insert_final_newline = false
12+
insert_final_newline = true
1313
trim_trailing_whitespace = false

.eslintignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/node_modules
22
/dist
3-
/test/cases
3+
/test/cases/*/expected
44
/test/js
55
/test/manual

.eslintrc.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
module.exports = {
22
root: true,
3+
parser: 'babel-eslint',
34
plugins: ['prettier'],
45
extends: ['@webpack-contrib/eslint-config-webpack'],
56
rules: {
6-
'prettier/prettier': [
7-
'error',
8-
{ singleQuote: true, trailingComma: 'es5', arrowParens: 'always' },
9-
],
10-
'class-methods-use-this': 'off',
11-
'no-undefined': 'off',
7+
'prettier/prettier': ['error'],
128
},
139
};

.gitattributes

+1
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ package-lock.json -diff
22
* text=auto
33
test/cases/* eol=lf
44
bin/* eol=lf
5+
yarn.lock -diff

.github/CODEOWNERS

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
@webpack-contrib/org-maintainers
44

55
# Add repository specific users / groups
6-
# below here for libs that are not maintained by the org.
7-
@sokra
6+
# below here for libs that are not maintained by the org.

.github/CONTRIBUTING.md

+69-41
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
1-
## Contributing in @webpack-contrib
1+
# Contributing in @webpack-contrib
22

3-
We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
3+
We'd always love contributions to further improve the webpack / webpack-contrib ecosystem!
44
Here are the guidelines we'd like you to follow:
55

6-
* [Questions and Problems](#question)
7-
* [Issues and Bugs](#issue)
8-
* [Feature Requests](#feature)
9-
* [Pull Request Submission Guidelines](#submit-pr)
10-
* [Commit Message Conventions](#commit)
6+
- [Questions and Problems](#question)
7+
- [Issues and Bugs](#issue)
8+
- [Feature Requests](#feature)
9+
- [Pull Request Submission Guidelines](#submit-pr)
10+
- [Commit Message Conventions](#commit)
1111

12-
### <a name="question"></a> Got a Question or Problem?
12+
## <a name="question"></a> Got a Question or Problem?
1313

14-
Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
15-
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
14+
Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack).
15+
StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack).
1616
The issue tracker is for bug reports and feature discussions.
1717

18-
### <a name="issue"></a> Found an Issue or Bug?
18+
## <a name="issue"></a> Found an Issue or Bug?
1919

2020
Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
2121

@@ -31,13 +31,13 @@ We will be insisting on a minimal reproduce scenario in order to save maintainer
3131

3232
Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.
3333

34-
### <a name="feature"></a> Feature Requests?
34+
## <a name="feature"></a> Feature Requests?
3535

36-
You can *request* a new feature by creating an issue on Github.
36+
You can _request_ a new feature by creating an issue on Github.
3737

38-
If you would like to *implement* a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.
38+
If you would like to _implement_ a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project.
3939

40-
### <a name="submit-pr"></a> Pull Request Submission Guidelines
40+
## <a name="submit-pr"></a> Pull Request Submission Guidelines
4141

4242
Before you submit your Pull Request (PR) consider the following guidelines:
4343

@@ -46,9 +46,9 @@ Before you submit your Pull Request (PR) consider the following guidelines:
4646
- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored.
4747
- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account.
4848

49-
### <a name="commit"></a> Webpack Contrib Commit Conventions
49+
## <a name="commit"></a> Webpack Contrib Commit Conventions
5050

51-
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
51+
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
5252
format that includes a **type**, a **scope** and a **subject**:
5353

5454
```
@@ -66,48 +66,56 @@ to read on GitHub as well as in various git tools.
6666

6767
The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
6868

69-
Examples:
69+
Examples:
70+
7071
```
7172
docs(readme): update install instructions
7273
```
74+
7375
```
7476
fix: refer to the `entrypoint` instead of the first `module`
7577
```
7678

77-
#### Revert
78-
If the commit reverts a previous commit, it should begin with `revert: `, followed by the header of the reverted commit.
79+
### Revert
80+
81+
If the commit reverts a previous commit, it should begin with `revert:`, followed by the header of the reverted commit.
7982
In the body it should say: `This reverts commit <hash>.`, where the hash is the SHA of the commit being reverted.
8083

81-
#### Type
84+
### Type
85+
8286
Must be one of the following:
8387

84-
* **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
85-
* **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
86-
* **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
87-
* **docs**: Documentation only changes (example scopes: readme, changelog)
88-
* **feat**: A new feature
89-
* **fix**: A bug fix
90-
* **perf**: A code change that improves performance
91-
* **refactor**: A code change that neither fixes a bug nor adds a feature
92-
* **revert**: Used when reverting a committed change
93-
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
94-
* **test**: Addition of or updates to Jest tests
95-
96-
#### Scope
88+
- **build**: Changes that affect the build system or external dependencies (example scopes: babel, npm)
89+
- **chore**: Changes that fall outside of build / docs that do not effect source code (example scopes: package, defaults)
90+
- **ci**: Changes to our CI configuration files and scripts (example scopes: circleci, travis)
91+
- **docs**: Documentation only changes (example scopes: readme, changelog)
92+
- **feat**: A new feature
93+
- **fix**: A bug fix
94+
- **perf**: A code change that improves performance
95+
- **refactor**: A code change that neither fixes a bug nor adds a feature
96+
- **revert**: Used when reverting a committed change
97+
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons)
98+
- **test**: Addition of or updates to Jest tests
99+
100+
### Scope
101+
97102
The scope is subjective & depends on the `type` see above. A good example would be a change to a particular class / module.
98103

99-
#### Subject
104+
### Subject
105+
100106
The subject contains a succinct description of the change:
101107

102-
* use the imperative, present tense: "change" not "changed" nor "changes"
103-
* don't capitalize the first letter
104-
* no dot (.) at the end
108+
- use the imperative, present tense: "change" not "changed" nor "changes"
109+
- don't capitalize the first letter
110+
- no dot (.) at the end
111+
112+
### Body
105113

106-
#### Body
107114
Just as in the **subject**, use the imperative, present tense: "change" not "changed" nor "changes".
108115
The body should include the motivation for the change and contrast this with previous behavior.
109116

110-
#### Footer
117+
### Footer
118+
111119
The footer should contain any information about **Breaking Changes** and is also the place to
112120
reference GitHub issues that this commit **Closes**.
113121

@@ -116,9 +124,29 @@ reference GitHub issues that this commit **Closes**.
116124
Example
117125

118126
```
119-
BREAKING CHANGE: Updates to `Chunk.mapModules`.
127+
BREAKING CHANGE: Updates to `Chunk.mapModules`.
120128
121129
This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764
122130
Migration: see webpack/webpack#5225
123131
124132
```
133+
134+
## Testing Your Pull Request
135+
136+
You may have the need to test your changes in a real-world project or dependent
137+
module. Thankfully, Github provides a means to do this. Add a dependency to the
138+
`package.json` for such a project as follows:
139+
140+
```json
141+
{
142+
"devDependencies": {
143+
"${package}": "webpack-contrib/${package}#{id}/head"
144+
}
145+
}
146+
```
147+
148+
Where `{id}` is the # ID of your Pull Request.
149+
150+
## Thanks
151+
152+
For your interest, time, understanding, and for following this simple guide.

.github/ISSUE_TEMPLATE.md

+13-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
11
<!--
2-
1. Check the version of package you are using. If it's not the newest version, update and try again (see changelog while updating!).
3-
2. If the issue is still there, write a minimal project showing the problem and expected output.
4-
3. Link to the project and mention Node version and OS in your report.
2+
👉🏽 Need support, advice, or help? Don't open an issue!
3+
Head to StackOverflow or https://gitter.im/webpack/webpack.
54
6-
**IMPORTANT! You should use [Stack Overflow](https://stackoverflow.com/) for support related questions.**
5+
Hey there!
6+
7+
You arrived at this template because you felt none of the other options
8+
matched the kind of issue you'd like to report. Please use this opportunity to
9+
tell us about your particular type of issue so we can try to accomodate
10+
similar issues in the future.
11+
12+
PLEASE do note, if you're using this to report an issue already covered by the
13+
existing template types, your issue may be closed as invalid. Our issue
14+
templates contain fields that help us help you, and without that important
15+
info, we might as well be ice-skating uphill, carrying a wooly mammoth.
716
-->

.github/ISSUE_TEMPLATE/BUG.md

+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
---
2+
name: 🐛 Bug Report
3+
about: Something went awry and you'd like to tell us about it.
4+
5+
---
6+
7+
<!--
8+
Issues are so 🔥
9+
10+
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
11+
of Github will appear and pile-drive the close button from a great height
12+
while making animal noises.
13+
14+
👉🏽 Need support, advice, or help? Don't open an issue!
15+
Head to StackOverflow or https://gitter.im/webpack/webpack.
16+
-->
17+
18+
* Operating System:
19+
* Node Version:
20+
* NPM Version:
21+
* webpack Version:
22+
* mini-css-extract-plugin Version:
23+
24+
### Expected Behavior
25+
26+
<!-- Remove this section if not reporting a bug or modification request. -->
27+
28+
### Actual Behavior
29+
30+
<!-- Remove this section if not reporting a bug or modification request. -->
31+
32+
### Code
33+
34+
```js
35+
// webpack.config.js
36+
// If your bitchin' code blocks are over 20 lines, please paste a link to a gist
37+
// (https://gist.github.com).
38+
```
39+
40+
```js
41+
// additional code, HEY YO remove this block if you don't need it
42+
```
43+
44+
### How Do We Reproduce?
45+
46+
<!--
47+
Remove this section if not reporting a bug.
48+
49+
If your webpack config is over 50 lines long, please provide a URL to a repo
50+
for your beefy 🍖 app that we can use to reproduce.
51+
-->

.github/ISSUE_TEMPLATE/DOCS.md

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
---
2+
name: 📚 Documentation
3+
about: Are the docs lacking or missing something? Do they need some new 🔥 hotness? Tell us here.
4+
5+
---
6+
7+
<!--
8+
Issues are so 🔥
9+
10+
If you remove or skip this template, you'll make the 🐼 sad and the mighty god
11+
of Github will appear and pile-drive the close button from a great height
12+
while making animal noises.
13+
14+
👉🏽 Need support, advice, or help? Don't open an issue!
15+
Head to StackOverflow or https://gitter.im/webpack/webpack.
16+
-->
17+
18+
Documentation Is:
19+
20+
<!-- Please place an x (no spaces!) in all [ ] that apply -->
21+
22+
- [ ] Missing
23+
- [ ] Needed
24+
- [ ] Confusing
25+
- [ ] Not Sure?
26+
27+
### Please Explain in Detail...
28+
29+
30+
### Your Proposal for Changes

0 commit comments

Comments
 (0)